Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    mkr-plse
    @mkr-plse
    @msridhar Do you have any students who will be interested in implementing Piranha for JS over the summer? @akilasankaran_twitter is interested in co-implementing Piranha for JS/JS frameworks.
    Manu Sridharan
    @msridhar
    I don’t think I have a student right now to work on it. But I’ll keep it in mind in case an opportunity arises, it sounds like a great project
    Akila Sankaran
    @akilasankaran_twitter
    Thanks, Manu and Murali. No problem, I can be the first person to start in JS. Today, as most of us use JS it would be helpful if we implement Piranha for JS also. As @mkruber pointed out this conversation https://github.com/uber/piranha/issues/24#issuecomment-606748443, I will explore more and get back.
    Manu Sridharan
    @msridhar
    Sounds great!
    mkr-plse
    @mkr-plse

    As @mkruber pointed out this conversation https://github.com/uber/piranha/issues/24#issuecomment-606748443, I will explore more and get back.

    Great. Looking forward to it

    Santosh
    @sp-magicspells
    Hi! I'm interested in implementing Piranha for Golang . @mkruber has already given me some inputs on this. Please let me know if anyone interested in working on this with me. Although I'm an experienced developer this is the first time I'm contributing a feature to open source. Let me know if anyone wants to work on this as well.
    mkr-plse
    @mkr-plse
    Thanks @sp-magicspells for starting on this. If you are stuck with any aspect of it, we can help unblock you :)
    Abhijith-net
    @Abhijith-net
    Hello @msridhar @mkruber, Is there anybody working on Kotlin?
    Manu Sridharan
    @msridhar
    @Abhijith-net not that I am aware of
    Abhijith-net
    @Abhijith-net
    @msridhar I will pick it up. Is there anywhere I need to register to avoid duplication of efforts?
    Manu Sridharan
    @msridhar
    Awesome! There is this issue: uber/piranha#17 you could mention you are working on it there. Also we can discuss implementation strategy there if you need help
    Also @mkruber may have more guidance
    Abhijith-net
    @Abhijith-net
    Cool thanks @msridhar and @mkruber
    mkr-plse
    @mkr-plse
    Thanks Abhijith. I am unaware of any efforts on Kotlin. There are groups looking at Go and Javascript.
    Akshay Sathe
    @satheaki
    Hi, We were trying to use piranha within our codebase, by creating a sample java project (followed the github documentation (https://github.com/uber/piranha/blob/master/java/README.md)). However, its only removing the feature flag, and not the related code. Here is the sample code we implemented
    https://github.com/vihanparmar/testRepo/blob/master/test/build.gradle
    Any help would be appreciated.
    Thanks :)
    mkr-plse
    @mkr-plse
    You are using 0.0.3 version of Piranha which should be work with the provided json file. Let me try this and get back to you.
    Akshay Sathe
    @satheaki
    @mkr-plse Thanks. :)
    mkr-plse
    @mkr-plse
    temporarily, please give the entire path for -XepOpt:Piranha:Config in the build.gradle file and it should work
    Filed uber/piranha#76 @satheaki
    Akshay Sathe
    @satheaki
    @mkr-plse Tried with the full path (absolute) to the properties file. No luck. Same issue, it just removed the feature flag and not the code. Am I doing something wrong here'
    mkr-plse
    @mkr-plse
    please use version 0.1.0
    i tried it on your repo and it works
    Akshay Sathe
    @satheaki

    Hello, We recently used piranha within our java codebase. I had a question regarding unit Tests. Do we need to have the custom annotation for tests?. In the sample project you have @FlagTesting annotation specified. So in order for pirhana to scan the unit tests do we need to have this annotation on all the feature flags?
    We use Junit with mockito. As an example:

    @Test
    public void testFlagRemoval() {
    when(featureManager.isEnabled(eq(Flags.SAMPLE_FLAG), any())).thenReturn(true);
    }

    This code is not refactored/evaluated. Do we need to do something else. I also added the custom annotation, but still the same issue.
    Any help would be appreciated.
    Thanks :)

    mkr-plse
    @mkr-plse

    featureManager.isEnabled(Flags.SAMPLE_FLAG) will likely be refactored. Since this is using the Mockito API eq to match the arguments, that is creating an issue for Piranha. If Mockito support is added to Piranha and uber/piranha#47 is resolved, that will help address this. There can be simpler intermediate solutions for issue 47 that just handles the when(cond).thenReturn(...) case.

    Can you create a issue asking for Mockito support?

    aakriti-kedia
    @aakriti-kedia
    Hello,
    Are there any leads on getting started with the Piranha Pipeline for Java for automatically detecting & removing stale flags instead of manually providing the flagname in pom.xml?
    Manu Sridharan
    @msridhar
    That pipeline is not part of open source Piranha. It was built specifically for Ubers flag tracking system
    aakriti-kedia
    @aakriti-kedia
    O ok! Thanks
    So is there any way to detect flags other than passing the flagname in pom.xml manually ?
    Or any plans of open-sourcing pipeline any time in future ?
    mkr-plse
    @mkr-plse

    I don't think there are any plans of open sourcing the pipeline in the near future. Mainly because this is not going to be much helpful with different flag management systems, build systems, code review and task tracking systems.

    Regarding passing flag names, how about having a script that sets the flag name as an env variable? You won't need to change the pom.xml beyond using the env variable. See https://stackoverflow.com/questions/10463077/how-to-refer-environment-variable-in-pom-xml