These are chat archives for ujh/iomrascalai

15th
Mar 2015
iopq
@iopq
Mar 15 2015 05:22
Before I fix those things I have a refactoring pull request. I wrote a Strenum crate for keeping all the commands in one place.
iopq
@iopq
Mar 15 2015 08:34
I just got to Parser::from_path and the API is very unsafe and making my tests fail
Urban Hafner
@ujh
Mar 15 2015 08:40
You mean because I just call unwrap() and make the app crash? Yes that is not nice. In all honesty I just added the loadsgf command to reduce the compiler warnings. I mainly use it to set up test boards.
What I mean to say. You can either try to change the SGF parser or remove the loadsgf command again.
iopq
@iopq
Mar 15 2015 08:44
should I add an additional method of loading the sgf that returns an Option to the parser?
Urban Hafner
@ujh
Mar 15 2015 08:48
Shouldn't you return Result instead of Option? But yes, you could add another method.
iopq
@iopq
Mar 15 2015 08:49
I think the error message is just supposed to be "cannot load file" so for my purposes Option suffices, but I guess Result is more precise
iopq
@iopq
Mar 15 2015 09:19
Should I merge that pull request? I have more changes coming in
iopq
@iopq
Mar 15 2015 09:25
OK, I just created a new pull request with additional changes (a super set of the changes in the previous one). I guess ideally I should have changed the other branch, but then I'd have to replicate work or create merge commits (or rebase commits).
Urban Hafner
@ujh
Mar 15 2015 09:35
Just add yourself as the author for the changes in #108 and the feel free to merge it.
Then you should be able to merge it into your new branch or rebase it.
iopq
@iopq
Mar 15 2015 09:36
I'll cherry pick those commits I guess
Urban Hafner
@ujh
Mar 15 2015 09:37
I hope I'll be able to have a look at the other pull request later today.
iopq
@iopq
Mar 15 2015 09:42
ah yes, I have a few questions about the gtp
Do we need to pay attention to the color in time_left
Urban Hafner
@ujh
Mar 15 2015 09:48
According to the spec I think we should pay attention. But in practice you will only ever get time_left commands for one color.
I would paste the link to the spec here, but somehow that doesn't work with the iPhone app.
iopq
@iopq
Mar 15 2015 09:49
I have the spec, that's why I was wondering
I'll leave the TODO in there for future refinements
Urban Hafner
@ujh
Mar 15 2015 09:53
That's probably a good idea. There are quite a few rough edges in the code base. I do love having clean code, but if I don't see regular improvements in the strength of the bot I know I'll just give up.
With that and the Trello board I think I'm just playing "project manager". ;)
iopq
@iopq
Mar 15 2015 09:54
Well I'm playing "open source contributor" because I haven't even seen the actual engine code, I'm still refactoring the first file I got my hands on :D
Urban Hafner
@ujh
Mar 15 2015 09:58
That's better than when I started. Thomas started on his own as I didn't know Rust. Still I commented on his pull requests.
iopq
@iopq
Mar 15 2015 11:03
I'm just taking the long view on this - even if strength-wise you don't make improvements, you can always improve the code base