re unexpectedjs/unexpected#781 - that handles one case, but just noting that we still have the issue the other way round. Namely, if you refactored some code and changed the subject from an
{} to a new Map(), you will have weird results because the properties attached to the Map object will be checked rather than the .set() mappings it contains
perhaps that's a vote for having Map in core so that just can't happen - to answer your Q @papandreou, I think the plugin is actually in a good state as it stands - I did a pretty extensive rework leading up to v2 that ported all the v11 "to satisfy" behaviours
It's a super inefficient implementation for now, but LMK if there's appetite for getting something like this in, or if you have feedback about the syntax or feature set.
I hope we'd be able to use the type generation part of unassessed on top :)
@papandreou sorry for not looking at your camel case spike yet, I'm in Svendborg until Wednesday, but I'll take a look when I have some time.
No rush at all! There's still plenty of stuff to fix on it. It would be nice to get some feedback on the api when you have time, you can just ignore everything except the new test: https://github.com/unexpectedjs/unexpected/pull/784/files#diff-d03ea72142f3971d3a3e4ff1b79deedba7269b7530be66d24150ab4f20520473R1
By default mocha looks for test files in
./test/*.js, and with the --recursive option it will use the equivalent of ./test/**/*.js. I'd like to change that to **/test/*.js and ideally through configuration. I cannot find anything about it in the docs nor on the website. Do you have any clue about how to do that?
Config files in jason/yaml, async functions for tests instead of done callbacks etc
How is this test passing? What am I missing?
import unexpected from 'unexpected';
import unexpectedExpress from 'unexpected-express';
import express from 'express';
import { partnerAdsTrackingMiddleware } from './partnerAdsTrackingMiddleware';
const expect = unexpected.clone().use(unexpectedExpress);
const app = express()
.use(partnerAdsTrackingMiddleware())
.use((req, res) => res.send('OK'));
describe('partnerAdsTrackingMiddleware', () => {
it('should not set a cookie when no partner information is present', () => {
expect(app, 'to yield exchange', {
request: 'GET /?paid=foo&pacid=bar',
response: {
statusCode: 999,
},
});
});
});
async. jesus. I'm getting rusty
Have any of you tested the setting of cookie headers? I think I need a custom assertion with https://www.npmjs.com/package/set-cookie-parser or something
So something like:
const context = await expect(app, 'to yield exchange', ...) and then context.httpResponse.headers.getAll('Set-Cookie')
Error: unexpected-express: Response object specification incomplete.
Ended up with ensuring that there are not multiple
Set-Cookie headers and passing parameters to functions: it('should filter unknown values out of cookie value', async () => {
await expect(app, 'to yield exchange', {
request: 'GET /?paid=foo&pacid=bar&unknown=1234',
response: {
headers: {
'Set-Cookie': expect.it(
'when passed as parameter to',
parse,
'to satisfy',
[
{
name: 'partner-ads',
value: expect.it(
'when passed as parameter to',
JSON.parse,
'to satisfy',
{ paid: 'foo', pacid: 'bar' }
),
maxAge: 3456000,
path: '/',
sameSite: 'Lax',
},
]
),
},
},
});
});