Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Jul 01 22:01
    xuwei-k closed #849
  • Jul 01 22:01

    xuwei-k on 0.11.x

    (compare)

  • Jul 01 22:01

    xuwei-k on 0.11.x

    Update specs2-core to 4.16.1 in… (compare)

  • Jul 01 22:01
    xuwei-k closed #848
  • Jul 01 22:01

    xuwei-k on main

    (compare)

  • Jul 01 22:01

    xuwei-k on main

    Update specs2-core to 4.16.1 in… (compare)

  • Jul 01 16:05
    unfiltered-app[bot] review_requested #849
  • Jul 01 16:05
    unfiltered-app[bot] opened #849
  • Jul 01 16:05

    unfiltered-app[bot] on 0.11.x

    Update specs2-core to 4.16.1 in… (compare)

  • Jul 01 16:05
    unfiltered-app[bot] review_requested #848
  • Jul 01 16:05
    unfiltered-app[bot] opened #848
  • Jul 01 16:05

    unfiltered-app[bot] on main

    Update specs2-core to 4.16.1 in… (compare)

  • Jun 22 22:02

    xuwei-k on main

    (compare)

  • Jun 22 22:02

    xuwei-k on main

    Update jetty-webapp to 11.0.11 … (compare)

  • Jun 22 22:02
    xuwei-k closed #845
  • Jun 22 22:02

    xuwei-k on 0.11.x

    (compare)

  • Jun 22 22:02
    xuwei-k closed #846
  • Jun 22 22:02

    xuwei-k on 0.11.x

    Update jetty-webapp to 10.0.11 … (compare)

  • Jun 22 22:02

    xuwei-k on 0.10.x

    Update jetty-webapp to 9.4.48.v… (compare)

  • Jun 22 22:02

    xuwei-k on 0.10.x

    (compare)

Omar Kilani
@omarkilani
Just wanted to update and say it's now on 100% of production servers. No issues. :+1:
kenji yoshida
@xuwei-k
:tada:
Erlend Hamnaberg
@hamnis
can someone take a look at #369 ?
Omar Kilani
@omarkilani
any chance we can release a beta3? mostly to pick up the new netty
Erlend Hamnaberg
@hamnis
Any reason we shouldnt go to 0.9.0 now?
Omar Kilani
@omarkilani
no
i've been running this in production for more than a month, zero issues
so let's do 0.9.0 if @xuwei-k agrees
kenji yoshida
@xuwei-k
:+1:
Erlend Hamnaberg
@hamnis
should we also change the main branch to 0.9.x or something? Dont really see the point of having branches per minor release
we can do that after the release
Omar Kilani
@omarkilani
yeah it makes no sense
yes please
Erlend Hamnaberg
@hamnis
if no objections, i’ll build and publish 0.9.0 from commit id: a068ffba4a76a594e81c91e22f8a5587490fdbe6
Omar Kilani
@omarkilani
Yup
Erlend Hamnaberg
@hamnis
Released
I changed the default branch to 0.9.x
if we rather want master, then I’m all for
Erlend Hamnaberg
@hamnis
meh. stupid erratic failing test
Erlend Hamnaberg
@hamnis
Someone™ should look into that
kivi
@kivi
Can someone show me some examples, where unfiltered is using a jar file and serves the methods as GET/POST?
Omar Kilani
@omarkilani
is there a reason for this
remote: error: GH006: Protected branch update failed for refs/heads/0.9.x. remote: error: Required status check "continuous-integration/travis-ci" is expected. To github.com:unfiltered/unfiltered.git ! [remote rejected] 0.9.x -> 0.9.x (protected branch hook declined) error: failed to push some refs to 'git@github.com:unfiltered/unfiltered.git'
Omar Kilani
@omarkilani
anyway
Omar Kilani
@omarkilani
any chance we can do a new release to get the netty change in?
Omar Kilani
@omarkilani
it would be really great if we somehow could allow people to enable SO_REUSEPORT for netty
but the definition is only in transport-native-epoll/src/main/java/io/netty/channel/epoll/EpollChannelOption.java 27: public static final ChannelOption<Boolean> SO_REUSEPORT = valueOf(EpollChannelOption.class, "SO_REUSEPORT")
Erlend Hamnaberg
@hamnis
I dont really have time do another release until next week
if anyone else wants to, be my guest
Omar Kilani
@omarkilani
any chance you can detail the release steps
so we can do releases too?
Omar Kilani
@omarkilani
is it just 'sbt publish'? :D
do we need to use the same pgp keys?
Erlend Hamnaberg
@hamnis
I'll try to jot down the steps tomorrow.
no need in using the same pgp-keys.
Omar Kilani
@omarkilani
k
Erlend Hamnaberg
@hamnis
should we release with those changes? I have time to get this done now.
Omar Kilani
@omarkilani
Yes please
Erlend Hamnaberg
@hamnis
will push this tomorrow morning if no issues are discovered
Omar Kilani
@omarkilani
seems fine to me, did you do any commits for that -- i dont see them on gh
Erlend Hamnaberg
@hamnis
not pushed yet
Erlend Hamnaberg
@hamnis
its pushed now
Omar Kilani
@omarkilani
K
Please publish it to the live repo
Omar Kilani
@omarkilani
cool thanks
Jack Low
@wjlow
Hey everyone. I'm looking to serve an image through an Unfiltered endpoint. Could someone please point me to the right direction?
Jack Low
@wjlow
Found a way to do it by streaming :)
123abc
@cavapoo2_twitter
def intent = {
    case req @ POST(Path(Seg("credit" :: "charge" :: Nil))) => { ...}

object Seg {
  def unapply(path: String): Option[List[String]] = path.split("/").toList match {
    case "" :: rest => Some(rest) // skip a leading slash
    case all => Some(all)
  }
}
How is it possible to send List[String] to Seg ?
123abc
@cavapoo2_twitter
is it because its not actually creating the Seg instance, its just using the stuff inside Seg as pattern match. it assumes a string, then does the split and converts it to a List[String]. if there's a leading slash that is ignored. Then a List[String] is returned.