unfiltered/unfiltered

Omar Kilani

@omarkilani

any chance we can do a new release to get the netty change in?

Omar Kilani

@omarkilani

it would be really great if we somehow could allow people to enable SO_REUSEPORT for netty

but the definition is only in

transport-native-epoll/src/main/java/io/netty/channel/epoll/EpollChannelOption.java
27:    public static final ChannelOption<Boolean> SO_REUSEPORT = valueOf(EpollChannelOption.class, "SO_REUSEPORT")

Erlend Hamnaberg

@hamnis

I dont really have time do another release until next week

if anyone else wants to, be my guest

Omar Kilani

@omarkilani

any chance you can detail the release steps

so we can do releases too?

Omar Kilani

@omarkilani

is it just 'sbt publish'? :D

do we need to use the same pgp keys?

Erlend Hamnaberg

@hamnis

I'll try to jot down the steps tomorrow.

no need in using the same pgp-keys.

Omar Kilani

@omarkilani

Erlend Hamnaberg

@hamnis

should we release with those changes? I have time to get this done now.

Omar Kilani

@omarkilani

Yes please

Erlend Hamnaberg

@hamnis

Take it for a spin: https://oss.sonatype.org/content/repositories/wsunfiltered-1004

will push this tomorrow morning if no issues are discovered

Omar Kilani

@omarkilani

seems fine to me, did you do any commits for that -- i dont see them on gh

Erlend Hamnaberg

@hamnis

not pushed yet

Erlend Hamnaberg

@hamnis

its pushed now

Omar Kilani

@omarkilani

Please publish it to the live repo

Omar Kilani

@omarkilani

cool thanks

Jack Low

@wjlow

Hey everyone. I'm looking to serve an image through an Unfiltered endpoint. Could someone please point me to the right direction?

Jack Low

@wjlow

Found a way to do it by streaming :)

123abc

@cavapoo2_twitter

def intent = {
    case req @ POST(Path(Seg("credit" :: "charge" :: Nil))) => { ...}

object Seg {
  def unapply(path: String): Option[List[String]] = path.split("/").toList match {
    case "" :: rest => Some(rest) // skip a leading slash
    case all => Some(all)
  }
}

How is it possible to send List[String] to Seg ?

123abc

@cavapoo2_twitter

is it because its not actually creating the Seg instance, its just using the stuff inside Seg as pattern match. it assumes a string, then does the split and converts it to a List[String]. if there's a leading slash that is ignored. Then a List[String] is returned.

Shawn Garner

@shawndgarner_twitter

Hello, we are using ResponseHeader and it's in conjunction with a filter which is using Pass.fold which is updating and adding a header to the response, but within our plan we also using ResponseHeader intending on it replacing the one in the filter? We are seeing multiple values for the header, is there any way to replace headers rather than add on with ResponseHeader?

Omar Kilani

@omarkilani

@hamnis , @xuwei-k can we push a new 0.10.0-SNAPSHOT release sometime soon?

This message was deleted

Omar Kilani

@omarkilani

i'm trying to update netty to the latest release... but running into a bunch of issues there

one of the issues is this

netty/netty#7170

Omar Kilani

@omarkilani

the other issues are to do with clean up of POST files

Feb 19, 2018 11:28:47 AM io.netty.channel.AbstractChannelHandlerContext invokeExceptionCaught
WARNING: An exception 'java.lang.IllegalStateException: HttpPostMultipartRequestDecoder was destroyed already' [enable DEBUG level for full stacktrace] was thrown by a user handler's exceptionCaught() method while handling the following exception:
java.lang.IllegalStateException: HttpPostMultipartRequestDecoder was destroyed already
    at io.netty.handler.codec.http.multipart.HttpPostMultipartRequestDecoder.checkDestroyed(HttpPostMultipartRequestDecoder.java:210)
    at io.netty.handler.codec.http.multipart.HttpPostMultipartRequestDecoder.cleanFiles(HttpPostMultipartRequestDecoder.java:956)
    at io.netty.handler.codec.http.multipart.HttpPostRequestDecoder.cleanFiles(HttpPostRequestDecoder.java:252)
    at unfiltered.netty.request.PostDecoder.$anonfun$cleanFiles$1(decoder.scala:57)
    at unfiltered.netty.request.PostDecoder.$anonfun$cleanFiles$1$adapted(decoder.scala:57)
    at scala.Option.map(Option.scala:146)
    at unfiltered.netty.request.PostDecoder.cleanFiles(decoder.scala:57)
    at unfiltered.netty.request.CleanUp.$anonfun$cleanFiles$3(decoder.scala:216)
    at scala.Option.foreach(Option.scala:257)
    at unfiltered.netty.request.CleanUp.$anonfun$cleanFiles$2(decoder.scala:216)
    at unfiltered.netty.request.CleanUp.$anonfun$cleanFiles$2$adapted(decoder.scala:216)
    at scala.Option.foreach(Option.scala:257)
    at unfiltered.netty.request.CleanUp.cleanFiles(decoder.scala:216)
    at unfiltered.netty.request.CleanUp.cleanFiles$(decoder.scala:215)
    at unfiltered.netty.cycle.MultiPartPlanifier.cleanFiles(plans.scala:93)
    at unfiltered.netty.cycle.MultiPartDecoder.channelInactive(plans.scala:85)
    at unfiltered.netty.cycle.MultiPartDecoder.channelInactive$(plans.scala:84)
    at unfiltered.netty.cycle.MultiPartPlanifier.channelInactive(plans.scala:93)
    at io.netty.channel.AbstractChannelHandlerContext.invokeChannelInactive(AbstractChannelHandlerContext.java:245)
    at io.netty.channel.AbstractChannelHandlerContext.invokeChannelInactive(AbstractChannelHandlerContext.java:231)
    at io.netty.channel.AbstractChannelHandlerContext.fireChannelInactive(AbstractChannelHandlerContext.java:224)
    at io.netty.channel.ChannelInboundHandlerAdapter.channelInactive(ChannelInboundHandlerAdapter.java:75)
    at io.netty.handler.codec.MessageAggregator.channelInactive(MessageAggregator.java:417)
    at io.netty.channel.AbstractChannelHandlerContext.invokeChannelInactive(AbstractChannelHandlerContext.java:245)
    at io.netty.channel.AbstractChannelHandlerContext.invokeChannelInactive(AbstractChannelHandlerContext.java:231)
    at io.netty.channel.AbstractChannelHandlerContext.fireChannelInactive(AbstractChannelHandlerContext.java:224)
    at io.netty.handler.codec.ByteToMessageDecoder.channelInputClosed(ByteToMessageDecoder.java:377)
    at io.netty.handler.codec.ByteToMessageDecoder.channelInactive(ByteToMessageDecoder.java:342)
    at io.netty.channel.AbstractChannelHandlerContext.invokeChannelInactive(AbstractChannelHandlerContext.java:245)
    at io.netty.channel.AbstractChannelHandlerContext.invokeChannelInactive(AbstractChannelHandlerContext.java:231)
    at io.netty.channel.AbstractChannelHandlerContext.fireChannelInactive(AbstractChannelHandlerContext.java:224)
    at io.netty.channel.ChannelInboundHandlerAdapter.channelInactive(ChannelInboundHandlerAdapter.java:75)
    at io.netty.channel.AbstractChannelHandlerContext.invokeChannelInactive(AbstractChannelHandlerContext.java:245)
    at io.netty.channel.AbstractChannelHandlerContext.invokeChannelInactive(AbstractChannelHandlerContext.java:231)
    at io.netty.channel.AbstractChannelHandlerContext.fireChannelInactive(AbstractChannelHandlerContext.java:224)
    at io.netty.channel.DefaultChannelPipeline$HeadContext.channelInactive(DefaultChannelPipeline.java:1409)
    at io.netty.channel.AbstractChannelHandlerContext.invokeChannelInactive(AbstractChannelHandlerContext.java:245)
    at io.netty.channel.AbstractChannelHandlerContext.invokeChannelInactive(AbstractChannelHandlerContext.java:231)
    at io.netty.channel.DefaultChannelPipeline.fireChannelInactive(DefaultChannelPipe

Omar Kilani

@omarkilani

it doesn't actually fail those tests though, it happens after the tests

Omar Kilani

@omarkilani

for the expect/continue issue, it's unclear if the test is wrong or unfiltered is broken in this case

unfiltered has no special handling for Expect, so this intent

case P("/e") & Expect(v) => ResponseString("pass")

doesn't actually return 'pass', it returns a Status: 100 and body = ''

in unfiltered 4.1.15+

Erlend Hamnaberg

@hamnis

body makes no sense in the 100 Continue case

an expectation failed would be more interesting to test. for instance if the file is too large

Omar Kilani

@omarkilani

it does sort of make sense because the whole response fits in the reply

the rfc allows both

hence jetty

Omar Kilani

@omarkilani

should we do a 0.10.x release sometime? seems like it'd be good to do one soon

Omar Kilani

@omarkilani

it might be worth describing where the library lives / how to use it via sbt in the README.md, instead of expecting people to read the docs

Erlend Hamnaberg

@hamnis

👍

Omar Kilani

@omarkilani

who has admin access on github? need to fle an issue to tell them the cert on https://unfiltered.ws/ didnt autorenew

Omar Kilani

@omarkilani

ok, i filed a ticket and it's fixed

Where communities thrive

People

Repo info

Activity