unfiltered/unfiltered

Omar Kilani

@omarkilani

one of the issues is this

netty/netty#7170

Omar Kilani

@omarkilani

the other issues are to do with clean up of POST files

Feb 19, 2018 11:28:47 AM io.netty.channel.AbstractChannelHandlerContext invokeExceptionCaught
WARNING: An exception 'java.lang.IllegalStateException: HttpPostMultipartRequestDecoder was destroyed already' [enable DEBUG level for full stacktrace] was thrown by a user handler's exceptionCaught() method while handling the following exception:
java.lang.IllegalStateException: HttpPostMultipartRequestDecoder was destroyed already
    at io.netty.handler.codec.http.multipart.HttpPostMultipartRequestDecoder.checkDestroyed(HttpPostMultipartRequestDecoder.java:210)
    at io.netty.handler.codec.http.multipart.HttpPostMultipartRequestDecoder.cleanFiles(HttpPostMultipartRequestDecoder.java:956)
    at io.netty.handler.codec.http.multipart.HttpPostRequestDecoder.cleanFiles(HttpPostRequestDecoder.java:252)
    at unfiltered.netty.request.PostDecoder.$anonfun$cleanFiles$1(decoder.scala:57)
    at unfiltered.netty.request.PostDecoder.$anonfun$cleanFiles$1$adapted(decoder.scala:57)
    at scala.Option.map(Option.scala:146)
    at unfiltered.netty.request.PostDecoder.cleanFiles(decoder.scala:57)
    at unfiltered.netty.request.CleanUp.$anonfun$cleanFiles$3(decoder.scala:216)
    at scala.Option.foreach(Option.scala:257)
    at unfiltered.netty.request.CleanUp.$anonfun$cleanFiles$2(decoder.scala:216)
    at unfiltered.netty.request.CleanUp.$anonfun$cleanFiles$2$adapted(decoder.scala:216)
    at scala.Option.foreach(Option.scala:257)
    at unfiltered.netty.request.CleanUp.cleanFiles(decoder.scala:216)
    at unfiltered.netty.request.CleanUp.cleanFiles$(decoder.scala:215)
    at unfiltered.netty.cycle.MultiPartPlanifier.cleanFiles(plans.scala:93)
    at unfiltered.netty.cycle.MultiPartDecoder.channelInactive(plans.scala:85)
    at unfiltered.netty.cycle.MultiPartDecoder.channelInactive$(plans.scala:84)
    at unfiltered.netty.cycle.MultiPartPlanifier.channelInactive(plans.scala:93)
    at io.netty.channel.AbstractChannelHandlerContext.invokeChannelInactive(AbstractChannelHandlerContext.java:245)
    at io.netty.channel.AbstractChannelHandlerContext.invokeChannelInactive(AbstractChannelHandlerContext.java:231)
    at io.netty.channel.AbstractChannelHandlerContext.fireChannelInactive(AbstractChannelHandlerContext.java:224)
    at io.netty.channel.ChannelInboundHandlerAdapter.channelInactive(ChannelInboundHandlerAdapter.java:75)
    at io.netty.handler.codec.MessageAggregator.channelInactive(MessageAggregator.java:417)
    at io.netty.channel.AbstractChannelHandlerContext.invokeChannelInactive(AbstractChannelHandlerContext.java:245)
    at io.netty.channel.AbstractChannelHandlerContext.invokeChannelInactive(AbstractChannelHandlerContext.java:231)
    at io.netty.channel.AbstractChannelHandlerContext.fireChannelInactive(AbstractChannelHandlerContext.java:224)
    at io.netty.handler.codec.ByteToMessageDecoder.channelInputClosed(ByteToMessageDecoder.java:377)
    at io.netty.handler.codec.ByteToMessageDecoder.channelInactive(ByteToMessageDecoder.java:342)
    at io.netty.channel.AbstractChannelHandlerContext.invokeChannelInactive(AbstractChannelHandlerContext.java:245)
    at io.netty.channel.AbstractChannelHandlerContext.invokeChannelInactive(AbstractChannelHandlerContext.java:231)
    at io.netty.channel.AbstractChannelHandlerContext.fireChannelInactive(AbstractChannelHandlerContext.java:224)
    at io.netty.channel.ChannelInboundHandlerAdapter.channelInactive(ChannelInboundHandlerAdapter.java:75)
    at io.netty.channel.AbstractChannelHandlerContext.invokeChannelInactive(AbstractChannelHandlerContext.java:245)
    at io.netty.channel.AbstractChannelHandlerContext.invokeChannelInactive(AbstractChannelHandlerContext.java:231)
    at io.netty.channel.AbstractChannelHandlerContext.fireChannelInactive(AbstractChannelHandlerContext.java:224)
    at io.netty.channel.DefaultChannelPipeline$HeadContext.channelInactive(DefaultChannelPipeline.java:1409)
    at io.netty.channel.AbstractChannelHandlerContext.invokeChannelInactive(AbstractChannelHandlerContext.java:245)
    at io.netty.channel.AbstractChannelHandlerContext.invokeChannelInactive(AbstractChannelHandlerContext.java:231)
    at io.netty.channel.DefaultChannelPipeline.fireChannelInactive(DefaultChannelPipe

Omar Kilani

@omarkilani

it doesn't actually fail those tests though, it happens after the tests

Omar Kilani

@omarkilani

for the expect/continue issue, it's unclear if the test is wrong or unfiltered is broken in this case

unfiltered has no special handling for Expect, so this intent

case P("/e") & Expect(v) => ResponseString("pass")

doesn't actually return 'pass', it returns a Status: 100 and body = ''

in unfiltered 4.1.15+

Erlend Hamnaberg

@hamnis

body makes no sense in the 100 Continue case

an expectation failed would be more interesting to test. for instance if the file is too large

Omar Kilani

@omarkilani

it does sort of make sense because the whole response fits in the reply

the rfc allows both

hence jetty

Omar Kilani

@omarkilani

should we do a 0.10.x release sometime? seems like it'd be good to do one soon

Omar Kilani

@omarkilani

it might be worth describing where the library lives / how to use it via sbt in the README.md, instead of expecting people to read the docs

Erlend Hamnaberg

@hamnis

👍

Omar Kilani

@omarkilani

who has admin access on github? need to fle an issue to tell them the cert on https://unfiltered.ws/ didnt autorenew

Omar Kilani

@omarkilani

ok, i filed a ticket and it's fixed

they also said this

"You should be able to enforce HTTPS from the repository settings page now."

so maybe we should do this and update our links

Erlend Hamnaberg

@hamnis

Hey guys. I am stepping down as one of our maintainer as I simply cannot find the time or energy to get anything done here.

Omar Kilani

@omarkilani

Hey @hamnis . Sorry to hear that. Thanks for all the work you put into the project. Are you still using scala? Found a better http framework?

Erlend Hamnaberg

@hamnis

@omarkilani thanks. I am still using scala, but most of my efforts have shifted to http4s and the fs2 stack

Unfiltered is still great, I just cant find the time to get stuff done here.

Best of luck to all going forward

Omar Kilani

@omarkilani

Yeah, it’s tough. The ref counting / http continue issues on the netty side have been ... very annoying. :)

i wonder if you guys wouldn’t mind my colleague joining the team here? He’s got some great scala chops and since we literally depend on unfiltered to run our company I can probably get him working on unfiltered and pay him to do it. :)

Omar Kilani

@omarkilani

He’s @

andrewpaprotsky

Hanns Holger Rutz

@Sciss

Hi there. Looking for a Scala 2.13.0-RC2 build. I see a version for Scala 2.13.0-RC1 was published, 0.10.0-M3, but it seems to have a problem; in dispatch/reboot I always get these:

java.lang.NoClassDefFoundError: io/netty/channel/kqueue/KQueueEventLoopGroup

which doesn't happen when using 0.10.0-M2 (ends with Scala 2.13.0-M5). Any ideas if this is a bug in the published artifact?

Hanns Holger Rutz

@Sciss

Seems something got messed up in your pom file, for example I see this entry in 0.10.0-M3 not 0.10.0-M2:

    <dependency>
        <groupId>io.netty</groupId>
        <artifactId>netty-transport-native-kqueue</artifactId>
        <version>4.1.13.Final</version>
        <classifier>osx-x86_64</classifier>
    </dependency>

So that would mean it only shows up in OS X I guess?

I'll open an issue

Omar Kilani

@omarkilani

@xuwei-k please release HEAD for 2.13.0-RC2 support when you're ready :D

kenji yoshida

@xuwei-k

released :smiley: http://repo1.maven.org/maven2/ws/unfiltered/unfiltered_2.13.0-RC2/0.10.0-M4/

Where communities thrive

People

Repo info

Activity