Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    Fulvio Notarstefano
    @unfulvio
    @mflayhart are you using V1 or V2
    Vincent Maglione
    @bigsweater
    Hi, @unfulvio. Have you gotten any reports of this plugin being incompatible with WP 4.5.1? The namespace isn't even registering with my dev site, running 4.5.1 and WP-API v2-beta13. However, the classes are registering with PHP.
    Fulvio Notarstefano
    @unfulvio
    no I haven't seen this on github or wordpress.org being reported
    Vincent Maglione
    @bigsweater
    @unfulvio Odd. Must be something on my end, then. Thanks!
    Vincent Maglione
    @bigsweater
    Figured it out. Managing my plugins with Composer, and it was putting the current version of WP-API into the old directory (json-rest-api/plugin.php), so the conditional check in wp-api-menus.php was loading the V1 version of the plugin.
    Fulvio Notarstefano
    @unfulvio
    regrettably I don't have much time anymore to follow the development of this plugin. It started as something I needed for some website based on a js based frontend. I would be glad if someone could take over project management/adopt the plugin.
    Mathis Wiehl
    @fahrradflucht
    Hey Fulvio, I’m interested in the project and before no one does it I would take it over, but I’m not a very experienced PHP dev. I think it would be much better if someone else would do it.
    Mathis Wiehl
    @fahrradflucht
    @unfulvio thanks for taking care of #18 btw
    Fulvio Notarstefano
    @unfulvio
    hey no worries... actually I should push that on svn too
    I'm just afraid because of another issue in project...
    which I started to tackle today
    #26
    this is I think the result of me merging too hastily another PR from a while ago... but it's not that simple to unwind now and replace it with PHP 5.2 compatible code..
    plugin got mentioned here
    Mathis Wiehl
    @fahrradflucht
    Uses a flat data structure rather than a tree data structure. Clients could change to cope with this difference, but it’d be easier to have things the same from the start.
    Do you get this?
    Fulvio Notarstefano
    @unfulvio
    I should compare the data structure of a json output of v2 REST API with what the extension does now
    probably there's some inconsistency between the two
    WP API Menus was starded long time ago I think in 2013? 2014? when WP API 1.0 was not even finished
    but I never was a contributor to the WP API project directly so this little project existed on a side ever since
    WP REST API needs to address needs of a large and diverse group of people -- I started it to solve one simple problem when I was building a frontend based on js reading on the WP API
    I just needed to read a simple menu
    the WP REST API wants to be bigger than that
    Mathis Wiehl
    @fahrradflucht
    Yes and I think most of the time you would’nt want a truely nested resource where you would have to call menus/:menu_id/:item_id/ to get the items children
    Fulvio Notarstefano
    @unfulvio
    if you like this plugin (I'm flattered for that!) because you need to address something very specific on some site you're building, you might consider a fork or create a very simple solution that works for you (and perhaps ditch v1 support); if you want to try to do a community project and/or bring this to a PoC that at some point you could propose to merge into WP API then yes it's worth maintaining the project from where it is now
    likewise if you do a lot of front end work and need this in different scenarios
    Mathis Wiehl
    @fahrradflucht
    hmm I’m definitely not the one who uses Wordpress all the time, maybe you are right, that just using my fork in production is the better way.
    Fulvio Notarstefano
    @unfulvio
    good news I might have found someone :)
    Mathis Wiehl
    @fahrradflucht
    👍😃
    Fulvio Notarstefano
    @unfulvio
    @Fahrradflucht I think I can still give you commit access if you want, I really don't mind
    there's also another person willing to help
    @mckernanin
    Kevin McKernan
    @mckernanin
    howdy
    Fulvio Notarstefano
    @unfulvio
    hey there
    joDelicious
    @joDelicious
    @mckernanin @Fahrradflucht @Fahrradflucht Hi Kevin, Fulvio, Mathis. It would be -really- awesome for wp-api-menus to generate slugs for items...
    joDelicious
    @joDelicious
    my bad... i just saw 2 files where updated but not on the plugin release itself... great !
    (thank you :))
    joDelicious
    @joDelicious
    ... a great step would be to generate a url_relative in items objects...
    Mathis Wiehl
    @fahrradflucht
    @joDelicious you mean api urls or wp urls?
    Mathis Wiehl
    @fahrradflucht
    @unfulvio nevermind I really don’t need commit access. But it would be great if someone (maybe @mckernanin ?) would review my PRs or could give @underdawgq feedback. I always think that PRs with no answers are very discouraging new people to even bother contributing...
    joDelicious
    @joDelicious
    @Fahrradflucht For now 'url' are generated in the items objects, but they are absolute. In a few cases, in it would awesome to be able to have access to relative urls.
    Mathis Wiehl
    @fahrradflucht
    ah i know what you mean @joDelicious but I think thats a very hard feature since we then have to distinguish between custom links and links to resources and since wp-api does’nt expose relative urls aswell (http://v2.wp-api.org/reference/posts/) I don’t know if thats really a thing we should aim for…
    I think you have to handle this on the client though I know that this can be challenging especialy for the internal ressource links that you get in post/page content.
    Pavel Serikov
    @pavelsr
    Hi colleagues
    Can someone help we with this issue of WP-API ?
    This message was deleted
    WP-API/WP-API#2561
    pobo3
    @pobo3

    Hi guys
    I have trouble with menu.
    I renamed the first level menu item. After this - the order of the menu items has changed and the menu items of the second level of this menu item has ceased to work. And changes in menu not save
    wordpress 4.9.6
    v5.4.23 / g5_helium

    I tryed to create new menu - same, also reinstall theme - nothing changed.

    How possible to fix it?

    Thanks