These are chat archives for ushahidi/Community

9th
Jul 2015
Ushbot
@ushbot
Jul 09 2015 06:27
[Angela Oduor Lungati, Ushahidi] Morning folks!
Ushbot
@ushbot
Jul 09 2015 14:10
[Sophie Shepherd, Ushahidi] morning!
[Jess Shorland, Ushahidi] (coffee) (coffee)
Ushbot
@ushbot
Jul 09 2015 14:20
[Angela Oduor Lungati, Ushahidi] (bacon)
[Sophie Shepherd, Ushahidi] mmmmmmm bacon
Ushbot
@ushbot
Jul 09 2015 14:30
[Jason Mule, Ushahidi] Hi people!
hollycorbett
@hollycorbett
Jul 09 2015 16:05
yo yo :)
Ushbot
@ushbot
Jul 09 2015 16:05
[Brian Herbert, Ushahidi] Yo!
Ushbot
@ushbot
Jul 09 2015 21:22
[Robbie Mackay, Ushahidi] Morning people..
[Will, Ushahidi] Morning
[Robbie Mackay, Ushahidi] Oops dropped off the daily updates already..
[Vaibhav Bhawsar, Ushahidi] morning!
[Robbie Mackay, Ushahidi] Yesterday: mostly spent the day testing and tweaking the set views work Holly did. Hopefully I can just land that soon..
[Robbie Mackay, Ushahidi] Also trawled the open phab tasks
[Robbie Mackay, Ushahidi] Today: Trying to get code reviewed and landed.. and looping back on google grant deployments
[Will, Ushahidi] Today I will be:
  • Fixing the behat errors for the T1641-post-filtering
  • Completing and pushing the collection task
[Will, Ushahidi] @Robbie I have a Q about process now are we continuing with phab or moving to git/reviewable?
[Robbie Mackay, Ushahidi] For right now I'd like to continue with phab.. hopefully we can get your next set of diff's to work smoothly.
[Will, Ushahidi] groovy!
[Robbie Mackay, Ushahidi] If/when we move away it'd be good to move all the task handling out of phab too.. rather than split between 2 places
[Will, Ushahidi] true
Ushbot
@ushbot
Jul 09 2015 21:27
[Robbie Mackay, Ushahidi] I'll keep doing those open pull requests via github though.
[Will, Ushahidi] ok great
Ushbot
@ushbot
Jul 09 2015 21:33
[Vaibhav Bhawsar, Ushahidi] Yes it would be great to use pull requests for reviews.
[Robbie Mackay, Ushahidi] Yup. I'm just going back and forth on the timing: switch now or wait till we're out of our current rush..
[Vaibhav Bhawsar, Ushahidi] i can wait :) i have one diff currently in phab
[Vaibhav Bhawsar, Ushahidi] after that maybe
[Robbie Mackay, Ushahidi] Yea I've got a lot of open stuff in my queue.
[Vaibhav Bhawsar, Ushahidi] how do i update this review? should doing an arc diff be enough? https://phabricator.ushahidi.com/D873
Ushbot
@ushbot
Jul 09 2015 21:38
[Robbie Mackay, Ushahidi] If you arc diff while on the same branch it should update
[Vaibhav Bhawsar, Ushahidi] thats great!
[Vaibhav Bhawsar, Ushahidi] thanks
Ushbot
@ushbot
Jul 09 2015 21:56
[Will, Ushahidi] @Robbie is it possible that Travis is running off a different DB then is instatiated by Base.yml - I can't reporduce the failures it's getting locally
[Robbie Mackay, Ushahidi] Odd. It should be running the same set up as you get locally
[Robbie Mackay, Ushahidi] you can see what it runs in .travis.yml if that helps?
[Will, Ushahidi] perhaps, I must be doing something stupid. I'll tear down my setup and reset it to be certain there aren't artifcats
[Robbie Mackay, Ushahidi] Are you running the full test suite? or just individual tests?
[Will, Ushahidi] running the full tests
[Robbie Mackay, Ushahidi] we don't reset the DB between every test so sometimes that can get different results (which is why some tests have @resetFixtures before them)
[Robbie Mackay, Ushahidi] the only other thing might be that if a table isn't mentioned in behat.yml it will be ignored.. ie. won't get truncated during setup
[Will, Ushahidi] hmm unfortunately, I do have @resetfictures - ok I'll check behat.yml
Ushbot
@ushbot
Jul 09 2015 22:08
[Robbie Mackay, Ushahidi] let me just run locally and see if have any issues too
[Robbie Mackay, Ushahidi] I'm seeing the same error as on travis..
[Will, Ushahidi] ah ha! so it's my side ok I'm rebuilding now
Ushbot
@ushbot
Jul 09 2015 22:16
[Will, Ushahidi] Ok I found it, I had changed stage to be current_stage but did not propagate the change to the feature test :/
[Robbie Mackay, Ushahidi] ah!
[Robbie Mackay, Ushahidi] makes sense.