These are chat archives for ushahidi/Community

5th
Aug 2015
Ushbot
@ushbot
Aug 05 2015 00:19
[Robbie Mackay, Ushahidi] I think community contrib *has* to be reviewed before it lands..
[Robbie Mackay, Ushahidi] I trust you not to break things.. but I don't think I'm clear enough about what each task involves. So code reviews now are 1 part code correctness, 1 part checking if tasks actually do what I expected, 1 part checking how code is structured.
[Robbie Mackay, Ushahidi] So if we were going to post -review that only really works for catching a few code correctness, style & approach things.
We need to document our current or planned approach (architecture etc) more.. and document what is 'done' for each task better.
[Robbie Mackay, Ushahidi] + more tests to make code correctness easier to gauge
Ushbot
@ushbot
Aug 05 2015 01:37
[Vaibhav Bhawsar, Ushahidi] ok got it. so would having acceptance criteria help for the part where we need to have a shared understanding of what the code should accomplish (does the code accomplish the product requirements)?
JavaJediMaster
@JavaJediMaster
Aug 05 2015 04:42
Hello there. I have set up the Ushahidi platform and client but when I open the client in my browser window the CSS does not fully load and the page is mostly incomprehensible. Need some guidance to get the client up and running..
Ushbot
@ushbot
Aug 05 2015 06:26
[Angela Oduor Lungati, Ushahidi] Hey @JavaJediMaster, what issues are you having?
JavaJediMaster
@JavaJediMaster
Aug 05 2015 06:38
@Angela When I debug the client in my browser there is a Syntax Error: missing ) after argument list bundle.js :9:1458 error
Ushbot
@ushbot
Aug 05 2015 07:42
[Robbie Mackay, Ushahidi] JavaJediMaster: its possible either your build hadn't fully finished and you just need to reload. Or the build broke for some reason..
[Robbie Mackay, Ushahidi] did you get any console errors?
JavaJediMaster
@JavaJediMaster
Aug 05 2015 07:48
@Robbie I run the client build twice. There were errors the first time so I run again and it went cleanly but same problem.
Ushbot
@ushbot
Aug 05 2015 07:49
[Robbie Mackay, Ushahidi] also belatedly here's my daily update for the dev team:
Landed several diffs: CSV import (command line only), loading page, cleaning up json encoding
chasing bugs with saved searches. and also trying to fix tests broken by the loading screen
Will be pulling together an updated release tomorrow
[Robbie Mackay, Ushahidi] @JavaJediMaster weird. Does it still fail if you disable uglifyjs ?
[Robbie Mackay, Ushahidi] also can you figure out where that line in bundle.js is? would be useful to know whats just before that and I can see if the code itself is broken
JavaJediMaster
@JavaJediMaster
Aug 05 2015 08:08
@Robbie It works! When I disable uglifyJs. Thanks
Ushbot
@ushbot
Aug 05 2015 08:09
[Robbie Mackay, Ushahidi] Are you running the latest code on master?
JavaJediMaster
@JavaJediMaster
Aug 05 2015 08:09
Yeap
Ushbot
@ushbot
Aug 05 2015 08:09
[Robbie Mackay, Ushahidi] Ok thanks. I'll chase that up tomorrow morning.. really need this to work even with uglifyjs
[Robbie Mackay, Ushahidi] Otherwise its a LOT of JS to ship down the wire
JavaJediMaster
@JavaJediMaster
Aug 05 2015 08:10
Not sure what that means. But
Cool
JavaJediMaster
@JavaJediMaster
Aug 05 2015 11:26
Please what is the default username and password. "
admin-admin does not work
Ushbot
@ushbot
Aug 05 2015 21:10
[Robbie Mackay, Ushahidi] @will thanks for the super fast turn around on header image uploads!
Robbie Mackay
@rjmackay
Aug 05 2015 21:39
@JavaJediMaster user admin password admin should work..
That should be the only user that exists on a new deployment
Have you confirmed you’re API deployed ok?
Robbie Mackay
@rjmackay
Aug 05 2015 23:20
@JavaJediMaster builds should work with uglify on now.. found the stay typo in the code :)
Ushbot
@ushbot
Aug 05 2015 23:32
[Robbie Mackay, Ushahidi] sweet. Fixed client build :)