Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    Joel Kuntz
    @Frozenfire92
    Ok I got the panel setting working
    Andrew Valencik
    @valencik
    BAM got tabs working: https://github.com/tabycat/bookmarks
    The current contents of that repo are the tabs I just had open :D
    Joel Kuntz
    @Frozenfire92
    Thats awesome
    checkout / merge settings
    I'm going to go for a bit
    Andrew Valencik
    @valencik
    ok will do
    sookool99
    @sookool99
    are github repos case sensitive? Not sure and just need to know for comparing two different paths
    Andrew Valencik
    @valencik
    I don't know actually
    sookool99
    @sookool99
    Just found out that it is case sensitive.
    Andrew Valencik
    @valencik
    ahh
    sookool99
    @sookool99
    Just Found out that github has a request limit per hour, because I just exceeded it lol
    Andrew Valencik
    @valencik
    So...
    I am running into problems that I think are GitHub limitation issues
    like how many API requests I can make in a certain amount of time.
    sookool99
    @sookool99
    haha yea it is 60 per hour (not authenticated) and 5000 per hour (authenticated).
    Only problem is you cannot authenticate get request as it will cause it to fail.
    https://developer.github.com/v3/#rate-limiting
    Andrew Valencik
    @valencik
    I don't think we are running into that issue afterall. It seems to be a rapid request in short periods of time issue.
    Checkout development and try pushing bookmarks, they likely won't all go
    I'd had to click push 3 times to get all the books marks to send
    Updated the issue. I am heading to bed. Hopefully I'll wake up with good ideas.
    sookool99
    @sookool99
    have a good one
    sookool99
    @sookool99
    @valencik Im writing this now cause I will forget later. I took a look at how you implemented it that won't work because your are just putting a sleeper on running the main function, but that function does all the querying at once. I will look into it tmrw. as well I fixed updated issue and branch is called updateBookmarks
    Andrew Valencik
    @valencik
    Yeah I forgot setBookmarks would take in an array and handle them. So I was calling it a bunch with an array of just one bookmark.
    Joel Kuntz
    @Frozenfire92
    Has anyone found out when it ends?
    I'm at smu currently doing some homework
    Andrew Valencik
    @valencik
    So we still seem to send too many requests. Not as in too many for our rate, but actually just unneeded requests. Check out this log of a simple bookmark push: http://pastebin.com/kfYhQ94j
    sookool99
    @sookool99
    How do you mean unneeded requests?
    And no Im not sure.
    Andrew Valencik
    @valencik
    Well look at that log. Definitely shouldn't be seeing things like:
    console.log: taby: {"message":"HelpandTutorials.json does not match 36e6f2923fe7625cf2bd202be6d5e10601342893","documentation_url":"https://developer.github.com/v3/repos/contents/"}
console.log: taby: {"message":"HelpandTutorials.json does not match 36e6f2923fe7625cf2bd202be6d5e10601342893","documentation_url":"https://developer.github.com/v3/repos/contents/"}
console.log: taby: {"message":"HelpandTutorials.json does not match 36e6f2923fe7625cf2bd202be6d5e10601342893","documentation_url":"https://developer.github.com/v3/repos/contents/"}
console.log: taby: {"message":"HelpandTutorials.json does not match 36e6f2923fe7625cf2bd202be6d5e10601342893","documentation_url":"https://developer.github.com/v3/repos/contents/"}
    sookool99
    @sookool99
    Yes that is very weird. but I am not able to reproduce that when I log in incomplete with console.log(bookmark.path + " update finished"); there is no repeated paths. which means there is no repeated requests
    Andrew Valencik
    @valencik
    Where do you log that?
    Oh, the onComplete
    sookool99
    @sookool99
    yea, so that would be data after a call has been completed and I don't have any repeats
    Andrew Valencik
    @valencik
    Well, either way it looks like with are sending too many requests in a short period of time. I am not sure why else we wouldn't be able to send all bookmarks in one go, and instead have to click push multiple times.
    Joel Kuntz
    @Frozenfire92
    So Volta commented back, the pitching/judging starts at 1
    sookool99
    @sookool99
    I Got IT!
    all data is saved! one go!
    checkout my branch "updateBookmarks"
    So, I'm probably going to just head over to Volta now then
    Andrew Valencik
    @valencik
    Fucking nice. And apparently good timing since we only have 2 hours haha
    Yeah I am going to head there too.
    Joel Kuntz
    @Frozenfire92
    Ok, I'm going down there too :D
    Andrew Valencik
    @valencik
    @sookool99 Your branch appears to perform better but it still won't send all 5 bookmarks in one go.
    Heading to McDonalds for breakfast sandwhich and then to Volta. Anyone want anything?
    sookool99
    @sookool99
    its too late for breakfast its past 11. and It works for me for all bookmarks, but we will look into in when I am there.
    Andrew Valencik
    @valencik
    FUUUUUUCKCKCNJKCHIUWDHCINWKJDCNWNDjno NO BREAKFAST
    At Volta now. Hungry... starving... wasting away without McDonalds.
    Andrew Valencik
    @valencik
    Great job folks! We'll be releasing version 1.0 followed by our incorporation and IPO in no time at all.
    Joel Kuntz
    @Frozenfire92
    :+1: :shipit: