Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
Boris Petrov
@boris-petrov
Yes.
nu.validator:validator:20.7.2 just means get that package version from Maven.
Or from whatever repository is set.
But "latest" is not on Maven Central I believe?
sideshowbarker
@sideshowbarker:mozilla.org
[m]
Yeah I haven't released a new Maven package since then
Boris Petrov
@boris-petrov
Would you kindly? :D
sideshowbarker
@sideshowbarker:mozilla.org
[m]
Not this week or next, no
So I recommend using the jar releases in the meantime
Boris Petrov
@boris-petrov
The jar release == the link to GitHub releases?
1 reply
sideshowbarker
@sideshowbarker:mozilla.org
[m]
I don't personally understand the use case for the Maven packages unless you are doing some integration into another java app
Boris Petrov
@boris-petrov
That's what I'm doing. But what other case is there for the JAR release?
2 replies
sideshowbarker
@sideshowbarker:mozilla.org
[m]
The jar release gets updated/rebuilt every time I push
Boris Petrov
@boris-petrov
I see... well, it's generally not nice for an application to depend on an artifact that changes every so often and one cannot pin the exact version they need.
That's why it's nice to have Maven Central releases.
In any case, thanks for the info. Please do a Maven Central release when you have the time
Boris Petrov
@boris-petrov
hm, I see that this vnu.jar is a fat-jar so it contains a bunch of classes that I don't want - for example org/slf4j/impl/StaticLoggerBinder.class. Because of it I get SLF4J: Class path contains multiple SLF4J bindings..
1 reply
Boris Petrov
@boris-petrov
Is there at least a way to locally build a maven bundle? ./checker.py bundle seems to do that but only for the "validator" package and not for the rest - cssvalidator, htmlparser, etc.
2 replies
sideshowbarker
@sideshowbarker:mozilla.org
[m]
wait, I have them already
./checker.py cssvalidator-bundle, for example
I am not sure I know how to fix that — that version issue
The thing is, I don’t use the Maven packages myself. At all.
I provide them because some people asked for them
and I spent a huge amount of time writing up a the build code for them
…which by the way I fully realize is idiosyncratic build code, and the “right” way to do it all would be directly with mvn and whatever
Boris Petrov
@boris-petrov
I see. Well, if you remember how you did the releases last time, you could just do the same for a new release. I'm not sure where version numbers come from, for example. I just built the "master" css-validator package and it still has 1.0.8 which is the version in MC.
sideshowbarker
@sideshowbarker:mozilla.org
[m]
I think the version numbers are static ones that I bump myself
the dependency ones are not generated numbers or automatically bumped
Boris Petrov
@boris-petrov
Only for the "main" package?
validator?
sideshowbarker
@sideshowbarker:mozilla.org
[m]
for the vnu.jar releases, that one gets automatically bumped
anyway, the version numbers are hardcoded into the ./build/build.py file
Boris Petrov
@boris-petrov
Right. I really don't want to take much of your time. The best solution for me would be to get new versions for all the packages on MC. If you can do that in the next few days/weeks, that's great. If not, in any case I will try to create my own packages in a local Maven repo so I can continue using the validator package from my app.
sideshowbarker
@sideshowbarker:mozilla.org
[m]
OK, I will try to get new Maven packages released this weekend or early next week
Boris Petrov
@boris-petrov
Thanks a lot!
kent7301
@kent7301
Hello
Boris Petrov
@boris-petrov
@sideshowbarker:mozilla.org - I don't want to be pushy but did you have time to look at releasing a new version at Maven Central of all the packages? :)
sideshowbarker
@sideshowbarker:mozilla.org
[m]
I have not had time
and I am not sure when I can make time
Boris Petrov
@boris-petrov
Ah, that's a pity. :( You suggest I start using the fat-jar instead of embedding the validator in my application?
sideshowbarker
@sideshowbarker:mozilla.org
[m]
@boris-petrov: if that’s what would work for you, yes
as far as I can see, whatever code you’ve written now would work exactly the same with the fat jar — the API doesn’t change
I guess there might be some Maven problem due to the fat jar including some dependencies that you already have installed through Maven
but I don’t know, because I’ve never actually ever used Maven myself
Boris Petrov
@boris-petrov

I guess there might be some Maven problem due to the fat jar including some dependencies that you already have installed through Maven

Yes, that's the problem I have. And also the fact that this fat-jar is updated all the time and I can't set a specific version (for example if the new one has some bug or introduces a check I can't fix right away or something). And that's why the Maven artifacts are nice. But isn't the process for releasing the fat-jar similar to the one for Maven Central? I also see there is an artifact in GitHub packages - https://github.com/validator/validator/packages/892686 - I could in theory use that one (I guess it's the same as in Maven Central) - so perhaps you could at least keep this one up-to-date?

Boris Petrov
@boris-petrov
I just tried using that GitHub package and it works fine, however I see that it still depends on nu.validator:cssvalidator:1.0.8 which is very old - it's the same version that validator from Maven Central (from 2020) depends on. So I guess that should be updated as well.
sideshowbarker
@sideshowbarker:mozilla.org
[m]
yeah that’s the issue
what I mean is, it’s not sufficient for me to update just the validator maven package itself, but also need to update any of the dependencies that have changes
at this point, the two that have significant changes are the css-validator package, and the htmlparser package
however, creating the packages for those is a lot less time-consuming than doing the validator package