Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
    Renan Montebelo
    @renanmontebelo
    I see some open PRs including auto-generated files, maybe we should consider merging validatorjs/validator.js#1590 as it would avoid confusion (and merge conflicts)
    Sarhan Aissi
    @tux-tn
    @renanmontebelo auto-generated files have already been removed in validatorjs/validator.js#1553
    Anthony Nandaa
    @profnandaa
    I'll try clear the PR backlog soonest starting with #1553. We didn't meet our 2 months release cadence but we should be good soon.
    Julia Muiruri
    @julzajules

    @julzajules -- welcome! :)

    Thanks. Great to be here! I've added the MSA Tag to the respective PRs

    Renan Montebelo
    @renanmontebelo
    @tux-tn #1553 missed /index.js
    Renan Montebelo
    @renanmontebelo
    (which is easy to miss since it's only modified when adding a new validator rather than modifying an existing one)
    Muhammad Hussein Fattahizadeh
    @mhf-ir
    why some of files are commited even in .gitignore
    like index.js, validator.min.js
    Muhammad Hussein Fattahizadeh
    @mhf-ir
    seems many PR is under queue, please take look validatorjs/validator.js#1595
    Renan Montebelo
    @renanmontebelo

    why some of files are commited even in .gitignore

    I believe it was accidently checked-in in validatorjs/validator.js#1495
    There are many PRs fixing it like yours, #1553 and #1590

    seems many PR is under queue, please take look validatorjs/validator.js#1595

    PRs are waiting for validatorjs/validator.js#1553 which sets up the new CICD using Github Actions

    Sarhan Aissi
    @tux-tn

    (which is easy to miss since it's only modified when adding a new validator rather than modifying an existing one)

    The index.js has been deleted when i made the PR. I probably need to merge the new commits in the PR

    Renan Montebelo
    @renanmontebelo
    @tux-tn as you'll be including (removing?) /index.js in your PR then I'll close validatorjs/validator.js#1590 as it won't be necessary anymore. Thank you.
    Sarhan Aissi
    @tux-tn
    @renanmontebelo as i told you, /index.js does not exist on my branch. I just synced my PR with master and added your suggestion concerning latest tag for the virtual-environment
    Sarhan Aissi
    @tux-tn
    @profnandaa i hope you will find time in the next days to check validatorjs/validator.js#1553 Travis-ci.org is shutting down by the end of month and we have all the tests failing with NodeJS 15 on Travis (probably travis related issue)
    Anthony Nandaa
    @profnandaa
    @tux-tn -- sorry for my delay! I have merged the PR but noticed that we need to do against master. Let me know when you can abe available for a quick call we go over this till NPM_SECRET stuff and close this completely. This will also unlock several other PRs that only have merge conflics on validator.js and validator.min.js
    Rubin Bhandari
    @rubiin
    so good to have this
    Rubin Bhandari
    @rubiin
    i see there are so many old prs lying around some of them are from october. The ones with label discussions are fine but fpr the ones with update flag, i think we need to inform the authors about what are they going to do. If they wont respond or couldnt continue with the pr, then someone else can takeover
    Anthony Nandaa
    @profnandaa
    @rubiin -- most are to do with validator.min.js, etc which will be sorted by #1553 work.
    Sarhan Aissi
    @tux-tn
    @profnandaa i'm available if you want to discuss the implementation of NPM_SECRET
    Anthony Nandaa
    @profnandaa
    image.png
    @tux-tn -- sorry yesterday turned busy, here is my availabilty today ^
    GMT+3
    Sarhan Aissi
    @tux-tn
    @profnandaa is 3PM GMT+3 okay for you?
    Anthony Nandaa
    @profnandaa
    @tux-tn -- no, the blue spots are filled up spots, how is 7 pm GTM+3 for you?
    Sarhan Aissi
    @tux-tn
    @profnandaa it's okay for me, see ya later
    Muhammad Hussein Fattahizadeh
    @mhf-ir
    is there any require review for validatorjs/validator.js#1595 ? it's independent PR.
    Sarhan Aissi
    @tux-tn
    @mhf-ir i'll take a look at it, can you please fix conflicts in README.md (It will allow the PR to be merged when everything is good, and run the new github workflow CI pipeline)
    Muhammad Hussein Fattahizadeh
    @mhf-ir
    @tux-tn Done
    Muhammad Hussein Fattahizadeh
    @mhf-ir
    @tux-tn Conflict again also resolve again, wait for Merge
    Muhammad Hussein Fattahizadeh
    @mhf-ir
    Is there any estimation for Merge ? validatorjs/validator.js#1595.
    Sarhan Aissi
    @tux-tn
    @mhf-ir i'll take a look right now, sorry for the delay
    Muhammad Hussein Fattahizadeh
    @mhf-ir

    I answer the comment, I can't find to tell you guys, isLuhn is not dependent to isCreditCard. it's itself could use. Consider you dont have isCreditCard.

    Example

    for example isHexadecimal is indepened for isHash:
    isHexadecimal(str) => isLuhn
    isHash(str) => isCreditCard

    We dont have isHexadecimal yet

    Muhammad Hussein Fattahizadeh
    @mhf-ir
    BTW i can remove isLuhn for merge other changes and continue discussion how to merge isLuhn and isCreditCard. Please follow the PR for merge ASAP. thanks guys
    Muhammad Hussein Fattahizadeh
    @mhf-ir
    @tux-tn isLuhn removed
    Muhammad Hussein Fattahizadeh
    @mhf-ir
    hi guys, any schedule for next version? merge accepted PRs...
    Anthony Nandaa
    @profnandaa
    Hey folks, really sorry for the delayed release, this is on me. Working on releasing this weekend.
    Muhammad Hussein Fattahizadeh
    @mhf-ir
    @profnandaa Thanks :thumbsup:
    Anthony Nandaa
    @profnandaa
    @tux-tn @rubiin @ezkemboi — draft release out, please review and let me know if all looks good. Will publish to NPM tomorrow - https://github.com/validatorjs/validator.js/releases/tag/13.6.0
    Sarhan Aissi
    @tux-tn
    @profnandaa i will take a look, btw i probably fixed both ReDOS , if i make a PR can it be added to the release?
    Sarhan Aissi
    @tux-tn
    validatorjs/validator.js#1651
    Rubin Bhandari
    @rubiin

    @tux-tn @rubiin @ezkemboi — draft release out, please review and let me know if all looks good. Will publish to NPM tomorrow - https://github.com/validatorjs/validator.js/releases/tag/13.6.0

    will check it

    also we need some house cleaning to do on the pull requests , bunch of them are stale
    Sarhan Aissi
    @tux-tn
    I suggest opening an issue to list all stale PR in order to allow the community to help on that.
    @profnandaa @ezkemboi do you agree?
    Rubin Bhandari
    @rubiin
    yeah. We can track all stale pr on that issue
    Rubin Bhandari
    @rubiin
    @profnandaa @ezkemboi i have opened a pr validatorjs/validator.js#1656
    Sarhan Aissi
    @tux-tn
    @rubiin you may want to reference the initial PR and give credit to original author when doing clean up next time
    https://github.com/validatorjs/validator.js/wiki/Maintenance:-PR-Clean-Up
    Anthony Nandaa
    @profnandaa
    👍