git checkout -b your_branch_name upstream/master
isMagnetURI
PR. It looks like keeping the +
doesn't impact significantly performance and i don't know what quantifier to put since the magnet definition didn't set a length limit and each browser have his own limit for URI (Chrome 64K+, IE 2048 characters, etc)
isBetween
I add a new validator isBetween where check if the string length is between min and max numbers which return true otherwise return false, but the incomplete thing is true write a test for this function , can someone help to acceptable test or teach me where to write it ??
You just need to use the existing test
method and cover all the cases of the validator you are adding. Example with isLength
https://github.com/validatorjs/validator.js/blob/master/test/validators.js#L4170