Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
    Rubin Bhandari
    @rubiin
    @profnandaa @ezkemboi i have opened a pr validatorjs/validator.js#1656
    Sarhan Aissi
    @tux-tn
    @rubiin you may want to reference the initial PR and give credit to original author when doing clean up next time
    https://github.com/validatorjs/validator.js/wiki/Maintenance:-PR-Clean-Up
    Anthony Nandaa
    @profnandaa
    👍
    salah alhashmi
    @alguerocode
    so, I do mistake now
    • I fork the repo and make changes to the main branch
      I want to remove the changes from the main branch and move it to new branch
      how I can do that????
    Sarhan Aissi
    @tux-tn
    hello @alguerocode
    you don't need to fork the repo again
    salah alhashmi
    @alguerocode
    hello bro
    Sarhan Aissi
    @tux-tn
    use the existing master branch of your fork
    the commits you add there will be added to the PR without any intervention
    why do you need to remove the changes from your main branch?
    salah alhashmi
    @alguerocode
    so I have a lot of ideas to improve the validator.js package, so I want multi branches to add my changes, and the main is set-upstream to the original repo
    the only way I have to delete my forked repo and create a new one
    • you can help me to use another approach??
    Sarhan Aissi
    @tux-tn
    gotcha
    you just need to set your branch to track upstream master :
    git checkout -b your_branch_name upstream/master
    no need to delete the existing repo
    salah alhashmi
    @alguerocode
    thank you so much bro
    Sarhan Aissi
    @tux-tn
    You are welcome
    Anthony Nandaa
    @profnandaa
    👍
    salah alhashmi
    @alguerocode
    sorry, now I want to delete my forked repo and start new fresh repo and recreate all my changes,
    thank for help bro
    Sarhan Aissi
    @tux-tn
    @profnandaa i just saw your comment on the isMagnetURI PR. It looks like keeping the + doesn't impact significantly performance and i don't know what quantifier to put since the magnet definition didn't set a length limit and each browser have his own limit for URI (Chrome 64K+, IE 2048 characters, etc)
    Should we put chrome limits to be safe?
    Sarhan Aissi
    @tux-tn
    never mind, i found a better solution
    salah alhashmi
    @alguerocode
    I add license badges (tag) to the readme file, you see it in PR
    Sarhan Aissi
    @tux-tn
    @alguerocode will check it
    salah alhashmi
    @alguerocode
    I add a new validator isBetween where check if the string length is between min and max numbers which return true otherwise return false, but the incomplete thing is true write a test for this function , can someone help to acceptable test or teach me where to write it ??
    and I update the readme file to describe is between function
    Sarhan Aissi
    @tux-tn
    isn't that a duplicate of validatorjs/validator.js#1733 ?
    We closed the PR because isLength is already doing what you tried to do with isBetween
    Please check the comment i left in the old PR https://github.com/validatorjs/validator.js/pull/1733#pullrequestreview-758986136

    I add a new validator isBetween where check if the string length is between min and max numbers which return true otherwise return false, but the incomplete thing is true write a test for this function , can someone help to acceptable test or teach me where to write it ??

    You just need to use the existing test method and cover all the cases of the validator you are adding. Example with isLength https://github.com/validatorjs/validator.js/blob/master/test/validators.js#L4170

    salah alhashmi
    @alguerocode
    IMHO, the name of the isLength function name is not good description , can we change it to other name??
    Sarhan Aissi
    @tux-tn
    You can open an issue concerning the name change, but the main issue is that changing the name will introduce breaking changes, it means that people already using isLength will need to change all occurrences to isBetween when they update the package
    salah alhashmi
    @alguerocode
    so, it make a lot of issue bor
    bro
    doesn't matter
    other thing I would talk is there validator for check is valid SQL query or not ??
    I can work on it doesn't there
    Sarhan Aissi
    @tux-tn
    all existing validators can be found in the README documentation
    https://github.com/validatorjs/validator.js#validators
    salah alhashmi
    @alguerocode
    you miss my license pull request bro
    Siddharth Sabale
    @sid4618
    @tux-tn India already existed in the list, my eyes didn't catch that. Closed the PR. was I supposed to do anything else?
    Sarhan Aissi
    @tux-tn
    @sid4618 already answered you in the PR. Feel free to reopen it with the suggested changes
    Siddharth Sabale
    @sid4618
    Yes, thanks again.
    Anthony Nandaa
    @profnandaa
    Release Alert: I have staged our next release, ready for release tomorrow - validatorjs/validator.js#1853
    Sarhan Aissi
    @tux-tn
    Thank you @profnandaa ! great work
    Serhii [boonya] Buinytskyi
    @boonya
    Hello there. When you guys are going to release a new version of validator.js?
    Serhii [boonya] Buinytskyi
    @boonya
    Is there any plans?
    Sarhan Aissi
    @tux-tn
    @boonya Thank you for your interest in validator.js. We probably need to wait for more PRs to be ready and merged before having a new release. Our best case scenario is to have a new release each quarter!
    salah alhashmi
    @alguerocode
    Hey, I've been working on this schema builder project, Volder for a while. Would you be interested in using it or contributing to it? It would be great if I can get some feedback on this project, or just add a star
    https://github.com/devSupporters/volder