-fPIEto the CXXFLAGS_<something> field after toggling to advanced mode in ccmake
ermo@solmate:~/repos/Vega-Strike-Engine-Source ⑂0.8.x $ ./bin/vegasettings --target ../privateer_wcu Set data directory to ../privateer_wcu Error: Failed to find Version.txt anywhere. ermo@solmate:~/repos/Vega-Strike-Engine-Source ⑂0.8.x $ ls -la ../privateer_wcu/Version.txt -rw-rw-r-- 1 ermo ermo 4 Jun 9 23:20 ../privateer_wcu/Version.txt
Thread 1 "vegastrike-engi" received signal SIGFPE, Arithmetic exception. 0x0000555555b77566 in Movable::Movable (this=0x7fffffffc1b0) at /home/ermo/repos/Vega-Strike-Engine-Source/engine/src/cmd/movable.cpp:74 74 sec = GameConfig::GetVariable( "graphics", "insys_jump_ani_second_ahead", 4) / (GameConfig::GetVariable( "physics", "game_speed", 1) * GameConfig::GetVariable( "physics", "game_accel", 1)); (gdb) bt #0 0x0000555555b77566 in Movable::Movable (this=0x7fffffffc1b0) at /home/ermo/repos/Vega-Strike-Engine-Source/engine/src/cmd/movable.cpp:74 #1 0x0000555555b25064 in Unit::Unit (this=0x555557842710) at /home/ermo/repos/Vega-Strike-Engine-Source/engine/src/cmd/unit_generic.cpp:391 #2 0x0000555555a2442c in GameUnit::GameUnit (this=0x555557842710) at /home/ermo/repos/Vega-Strike-Engine-Source/engine/src/cmd/unit.cpp:85 #3 0x0000555555733fa2 in main (argc=2, argv=0x7fffffffe658) at /home/ermo/repos/Vega-Strike-Engine-Source/engine/src/main.cpp:445 (gdb)
insys_jump_any_second_aheaddoesn't exist, but should default to 4 unless I'm misreading things?
@Loki1950 @nabaco @stephengtuggy @royfalk I updated https://github.com/vegastrike/Vega-Strike-Engine-Source/wiki/Pull-Request-Validation with some additional parameters around testing - mostly I've noticed a lot of my own PRs have had to deviate because of not being things that the play test would cover. The intent is that such cases need to be documented in the PR as an alternative to the play test and improve our PR testability. Please review the updated wiki for feedback/rewording/etc. All feed back welcome.
I think it's reasonable. I admit it's very hard to test certain things using play-testing and the lack of unit tests is hurting us too.
Looks good to me. Just a couple of typos.
forms is misspelled as
forums in a couple of places. And
cover is missing the
Hm. Could it be a divide-by-zero?
@BenjamenMeyer I've updated vegastrike/Vega-Strike-Engine-Source#474 with my findings and a patch that fixes the issue for me.