Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • May 06 2020 19:13
    dependabot[bot] labeled #40
  • May 06 2020 19:13
    dependabot[bot] opened #40
  • May 06 2020 19:13

    dependabot[bot] on npm_and_yarn

    Bump eslint from 1.10.3 to 6.8.… (compare)

  • May 06 2020 19:12

    jallers on S-70636-cors-doc-update

    (compare)

  • May 06 2020 19:12

    jallers on master

    S-70636 Initial Cut at update Incorporated feedback Updated to indicate that CORS i… and 1 more (compare)

  • May 06 2020 19:12
    jallers closed #39
  • Apr 27 2020 21:25
    jerryo opened #39
  • Apr 21 2020 22:10

    jerryo on S-70636-cors-doc-update

    Updated to indicate that CORS i… (compare)

  • Apr 21 2020 13:31

    jerryo on S-70636-cors-doc-update

    Incorporated feedback (compare)

  • Apr 20 2020 22:37

    jerryo on S-70636-cors-doc-update

    S-70636 Initial Cut at update (compare)

  • Apr 20 2020 22:37

    jerryo on S-70636-cors-doc-update

    (compare)

  • Aug 17 2017 10:04
    AnuragAmbuj closed #38
  • Aug 17 2017 10:04
    AnuragAmbuj edited #38
  • Aug 17 2017 10:03
    AnuragAmbuj opened #38
  • May 16 2017 21:09

    mhh on master

    D-12087 add 2.x and `withImplic… 2.3.0 (compare)

  • May 16 2017 21:09

    mhh on v2.3.0

    D-12087 add 2.x and `withImplic… 2.3.0 (compare)

  • May 16 2017 21:09

    mhh on v2.2.4

    (compare)

  • May 16 2017 20:36

    mhh on master

    D-12087 add support for implici… 2.2.5 (compare)

  • Feb 28 2017 19:45

    mhh on master

    2.2.4 (compare)

  • Feb 28 2017 14:50

    andrew-codes on master

    Posting from SDK with jquery ne… (compare)

Josh Gough
@JogoShugh
We will convert our users to js !!! Die .net and java clients, die die
We will probably need a way for the axios and jquery connectors to accept parameters for things like access tokens, basic auth creds, and the User Agent header
Anyway...well fogure it out, have a good one man
Andrew Smith
@andrew-codes
I think the SDK should do that. The connector probably should just glue post/get funcs
no need to handle the headers, functions or authorization at all 😉
Cory Wheeler
@corywheeler
late to the party, love we have the room up!
Andrew Smith
@andrew-codes
😄
Josh Gough
@JogoShugh
The different libraries have their own calling conventions for doing get or post or specific headers, and maybe even for the format of the fulfilled promise result... so I was thinking each connector would need to implement "an interface" so to speak that allows the client to speak to them without knowing which one is actually loaded
I wonder if there's a library that does thisnkijd of facade already
Andrew Smith
@andrew-codes
I am almost done with a candidate. The proposed syntax looks like this:
import sdk, {axiosConnector} from ‘v1sdk’;
import axios from ‘axios’;

var axiosConnectedSdk = axiosConnector(axios)(sdk); // higher order function to augment sdk with axios
var v1 = axiosConnectedSdk.withAccessToken(‘token’); // or withCreds(‘username’, ‘password’)
v1.create(‘Actual’, {Value: 5.5});
most of the existing SDK remains unchanged, though I am cleaning it up some as well, but that proposed syntax with the higher order function means that V1Meta can be what it is now and not need to be updated much (if at all)
also means that you can create your own higher order func connectors
and they can be part of the SDK without needing to pull in the axios/whatever library
Andrew Smith
@andrew-codes
as that is passed into the connector instead of used underneath
thoughts @/all
Josh Gough
@JogoShugh
love it so far!
Cory Wheeler
@corywheeler
looks good dude!
Josh Gough
@JogoShugh
take that, .NETJava!
we really need to provide a simplified meta-free approach for .net, java, and python too
Andrew Smith
@andrew-codes
agreed
Andrew Smith
@andrew-codes
I am almost done. I can push what I have if you want a sneak peek
otherwise, maybe in an hour or less I will have that done
including a bunch of refactoring
simplier tests and break down of responsibilities
Andrew Smith
@andrew-codes
@JogoShugh, @corywheeler, @walkerrandolphsmith
check this out: versionone/VersionOne.SDK.JavaScript#30
see the code snippet for in example or readme for an example
API of v1 is almost the same, but getting there is different; no more post/get funcs
Josh Gough
@JogoShugh
Looks like some awesome changes man
I left a couple comments, one issues is that access tokens prefix with Bearer
Instead of Basic
And I didn't understand if jquery is not handling params for query string ?
Andrew Smith
@andrew-codes
@JogoShugh good point about the bearer versus basic. I’ll check out your other comments also
Andrew Smith
@andrew-codes
@walkerrandolphsmith there, last commit supports both basic and token based authentication
Andrew Smith
@andrew-codes
@walkerrandolphsmith Would you mind adding an issue for the remove versus add mechanism in transformDataToAsset?
Josh Gough
@JogoShugh
@andrew-codes is that return { ...output, etc }} syntax expand the "output" object into the new literal object?
@andrew-codes 30 looks good... want me to merge it?
Josh Gough
@JogoShugh
I merged it and also I linked the Gitter chatroom from the README
Andrew Smith
@andrew-codes
cool thanks @JogoShugh
do we still need to publish #30 it to npm?
Josh Gough
@JogoShugh
yeah, i don't know how we do that
Andrew Smith
@andrew-codes
I think there is a npm publish task that lints, tests, builds, and publishes
you'll need to set your npm credentials to do so
I'll send you a link
Josh Gough
@JogoShugh
I got this working in C# now too, on a branch in one of my old pet projects:
var client = new VersionOneRestClient(V1_REST_API_URL, USERNAME, PASSWORD);
            var res = client.Update("Story:1083", new
            {
                Name = "It's a test from VersionOneRestSharpClient",
                Description = "And this is a description from VersionOneRestSharpClient",
                ToDo = 9.5
            });
Andrew Smith
@andrew-codes
oh nice!
Cory Wheeler
@corywheeler
@JogoShugh I that looks sexy, my wants it
Walker Randolph Smith
@walkerrandolphsmith
can I have :point_up: yesterday ????!!
Mike Mahon
@jetstreamin
? anyone around here?