brisvag on main
fix marker size scaling Merge pull request #2359 from b… (compare)
@brisvag Yes, this would require a new type of object in vispy. Like a DataSource object or something that has special properties/accessors for accessing the data in different ways and it would cache the GPU-level objects. Like maybe someone wants to use a 1D array provided to DataSource as a vertex buffer or maybe as a texture. The Visuals can request the specific format they need.
This type of object could even handle dask arrays and/or provide a tiling functionality where the Visuals using them attach to some events or assign a callback to the DataSource. Or maybe just tell the DataSource that they are attached. The DataSource gets an update from the user, the DataSource tells the Visual(s) that there was an update, the Visual updates anything it needs and redraws itself.
Complications: There are two conflicting but still similar ideas here. The idea of a data source (numpy array, dask array, etc) and the idea of a GPU-level object that is shared between Visuals. They should maybe be two different types of classes.
@brisvag and others, CI is failing now. Looks like an impossible to fix:
___________________________________ test_dpi ___________________________________
vispy/util/dpi/tests/test_dpi.py:11: in test_dpi
dpi = get_dpi()
vispy/util/dpi/_linux.py:66: in get_dpi
raise RuntimeError('could not determine DPI')
E RuntimeError: could not determine DPI
We may need to have a "if we're running tests on CI then default to 100"
WARNING: could not determine DPI
WARNING: Could not load the Qt platform plugin "xcb" in "" even though it was found.
WARNING: This application failed to start because no Qt platform plugin could be initialized. Reinstalling the application may fix this problem.
Available platform plugins are: eglfs, linuxfb, minimal, minimalegl, offscreen, vkkhrdisplay, vnc, wayland-egl, wayland, xcb.
/home/runner/work/_temp/d6b424e8-09fa-46b3-95da-0073f0cbe448.sh: line 10: 5244 Aborted (core dumped) python -c "import vispy; print(vispy.sys_info())"
Looking at what I think is the repository that configures what ubuntu-latest
maps to in CI, I think they just updated the images used: https://github.com/actions/virtual-environments/commits/main
Still the same major version of Ubuntu but newer
Yep, ubuntu image changed. Working job:
https://github.com/vispy/vispy/runs/7296668312?check_suite_focus=true
Virtual Environment
Environment: ubuntu-20.04
Version: 20220626.1
Included Software: https://github.com/actions/virtual-environments/blob/ubuntu20/20220626.1/images/linux/Ubuntu2004-Readme.md
Image Release: https://github.com/actions/virtual-environments/releases/tag/ubuntu20%2F20220626.1
Failing job:
https://github.com/vispy/vispy/runs/7303113757?check_suite_focus=true
Virtual Environment
Environment: ubuntu-20.04
Version: 20220710.1
Included Software: https://github.com/actions/virtual-environments/blob/ubuntu20/20220710.1/images/linux/Ubuntu2004-Readme.md
Image Release: https://github.com/actions/virtual-environments/releases/tag/ubuntu20%2F20220710.1