Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
    Daniel Pryor
    @pryorda
    git ref-log?
    Jc2k
    @Jc2k
    so it was this PR: pryorda/vmware_exporter#67
    it has 2 commits, the 1st commit worked for me but was slower than the loopy approach so i adopted the approach from #66 instead
    ugh but theres a bunch of other stuff in the 2nd commit as well
    so i used batch_fetch_properties to fetch all folders, then as a seperate task i map each folder moId to a datcenter
    bah
    for dc in dcs: labels[moid] = [ result = yield threads.deferToThread(lambda: _collect(dc, dc.hostFolder)) host['name'], labels.update(result)
    da fu
            for dc in dcs:
                labels[moid] = [                result = yield threads.deferToThread(lambda: _collect(dc, dc.hostFolder))
                    host['name'],                labels.update(result)
    that part is what throws the error above
    if you do if hasattr(dc, dc.hostfolder): or or dc.datastoreFolder it gets further
    when you have a folder at the root level.
    Jc2k
    @Jc2k
    i have to head off home, but i've pulled some relevant bits out of old commits
    interested if that works for you
    its not finished
    the main thing thats missing is ds_cluster is hardcoded to ds_cluster
    and i've only tested against an esxi box
    will see if i can add ds_cluster tonight as well
    there is a performance hit on ESXi, but its still only around 11s
    Jc2k
    @Jc2k
    might have ds_cluster added but might need to take you up on vCenter creds to finish testing
    @pryorda going to bed now but if you could try ^ and let me know how you get on (just pushed a bit more)
    Daniel Pryor
    @pryorda
    Ill work on trying it out today, sorry for the delay been working on "work"
    Daniel Pryor
    @pryorda
    @Jc2k fix_folders works for nested directories. I'm going to create a beta build it it will let me.
    Daniel Pryor
    @pryorda
    @Jc2k let me know what you think about missing labels.
    Jc2k
    @Jc2k
    heya
    sorry its been a while i've forgotten what i did
    vague feeling the missing labels was maybe intentional because i didn't fully finish it yet
    Jc2k
    @Jc2k
    @pryorda left some requests on the PR
    Daniel Pryor
    @pryorda
    Ill take a peak
    added the logs statements
    running it now
    Jc2k
    @Jc2k
    Coo
    Office -> Home but will try to touch base later, I have some other PR farming to do as well hopefully
    Daniel Pryor
    @pryorda
    heh okay
    New output added
    Daniel Pryor
    @pryorda
    @Jc2k let me know if you need anything else from me.
    Martin Kremers
    @kremers
    Hi there :)
    Jc2k
    @Jc2k
    Afternoon =)
    Martin Kremers
    @kremers
    I've tested 9f75cdc against the VSphere environment, works as expected.
    Jc2k
    @Jc2k
    Nice one
    Martin Kremers
    @kremers
    Would be nice to add pypy3 to the build matrix. Haven't tested it yet
    Jc2k
    @Jc2k
    if it works i'd be very happy about that. their 3.6 support is still beta i think, so we might want to have it be allowed to fail rather than a hard fail?
    Martin Kremers
    @kremers
    Regarding the stages in travisci i've rather no experience. If you can provide a follow up PR that would be great

    if it works i'd be very happy about that. their 3.6 support is still beta i think, so we might want to have it be allowed to fail rather than a hard fail?

    Yes! Allow to fail is a good idea IMO

    Jc2k
    @Jc2k
    can do a follow up pr for stages. will mean that the semantic-release only happens if all mandatory steps pass
    Martin Kremers
    @kremers
    Awesome :)
    Jc2k
    @Jc2k
    your PR made me realise that we can release with failing travis steps atm D: