it has 2 commits, the 1st commit worked for me but was slower than the loopy approach so i adopted the approach from #66 instead
ugh but theres a bunch of other stuff in the 2nd commit as well
so i used batch_fetch_properties to fetch all folders, then as a seperate task i map each folder moId to a datcenter
bah
for dc in dcs:
labels[moid] = [ result = yield threads.deferToThread(lambda: _collect(dc, dc.hostFolder))
host['name'], labels.update(result)
da fu
for dc in dcs:
labels[moid] = [ result = yield threads.deferToThread(lambda: _collect(dc, dc.hostFolder))
host['name'], labels.update(result)
that part is what throws the error above
if you do if hasattr(dc, dc.hostfolder): or or dc.datastoreFolder it gets further
when you have a folder at the root level.
interested if that works for you
its not finished
the main thing thats missing is ds_cluster is hardcoded to ds_cluster
and i've only tested against an esxi box
will see if i can add ds_cluster tonight as well
there is a performance hit on ESXi, but its still only around 11s
@pryorda going to bed now but if you could try ^ and let me know how you get on (just pushed a bit more)
sorry its been a while i've forgotten what i did
vague feeling the missing labels was maybe intentional because i didn't fully finish it yet
added the logs statements
running it now
Office -> Home but will try to touch base later, I have some other PR farming to do as well hopefully
New output added
if it works i'd be very happy about that. their 3.6 support is still beta i think, so we might want to have it be allowed to fail rather than a hard fail?
Yes! Allow to fail is a good idea IMO
:(