Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • 00:00
    careykwan synchronize #601
  • 00:00

    careykwan on VP-1048

    VP-1048: fixed linting issues (compare)

  • Jan 26 23:50
    careykwan synchronize #601
  • Jan 26 23:50

    careykwan on VP-1048

    VP-1048: fixing test (compare)

  • Jan 26 23:28
    careykwan synchronize #601
  • Jan 26 23:28

    careykwan on VP-1048

    VP-1048: fixing test (compare)

  • Jan 26 23:04
    careykwan opened #601
  • Jan 26 23:02

    careykwan on VP-1048

    VP-1048: made the avatar and na… (compare)

  • Jan 26 22:45
    careykwan commented #597
  • Jan 26 18:27

    avowkind on VP-1047-orgdetailpage-members-tab-invite-new-member-re

    (compare)

  • Jan 26 18:23

    avowkind on VP-1042

    (compare)

  • Jan 26 18:23

    avowkind on master

    VP-1042 Respect sendEmailNotifi… Merge branch 'master' into feat… Merge pull request #600 from vo… (compare)

  • Jan 26 18:23
    avowkind closed #600
  • Jan 25 03:50
    codecov[bot] commented #600
  • Jan 25 03:35
    guttmann synchronize #600
  • Jan 25 03:35

    guttmann on VP-1042

    removed body from .populate new story/ blog creation compon… More changes for story creation and 34 more (compare)

  • Jan 25 03:35
    guttmann opened #600
  • Jan 25 02:16

    avowkind on VP-1041

    (compare)

  • Jan 25 02:16
    avowkind closed #599
  • Jan 25 02:16

    avowkind on master

    VP-1041 Add email notification … VP-1041 Regenerate en.json lang… Merge branch 'master' into feat… and 1 more (compare)

Eteroa Lafaele
@Eteroa123
@/all ^^^^^^^^
Andrew Watkins
@avowkind
Don’t be shy everyone. You are all invited.
aswinks88
@aswinks88
@/all need some help on testing opOrder component. The wrapper.find("Select') is not rendering the children component. This is what I have done on OpOrderby,js and OpOrderBy.spec.js.
s1.png
s2.png
Blair
@BlairMcc
@Eteroa123 I have just emailed you :)
Eteroa Lafaele
@Eteroa123
@BlairMcc i just sent through the details see you there
Andrew Watkins
@avowkind
Morena @/all - your next checkout from master will require an npm installas theres a couple of package.json changes.
Andrew Watkins
@avowkind
Kia ora @/all its been quiet here recently so I've a few updates for you.
  1. We are seeking a volunteer contributor to help set up hosting of storybook on github.io. This is a secondary service we have in the Vly2 code base that provides a style guide and component test environment. The codes all in the code base and we just need someone to configure github so that the static storybook site is built and deployed to the _pages branch. - might this be you?
Andrew Watkins
@avowkind
  1. Alpha now demonstrating a bunch of new features - all designed to help people get started using Voluntarily. We can now send an invitation email to someone representing a school that lets them sign-in and setup the school: I’ve written about it here: https://voluntarily.atlassian.net/wiki/spaces/VP/pages/57081857/Invite+someone+to+setup+a+new+Organisation.
One thing that needs attention here is the Auth0 sign up page. This is UI thats provided by Auth0 and thus mostly out of our control. I'm seeking a volunteer to read through their manuals and see what we can do to make the experience more in line with our UI and friendlier.
We now have a major new concept called Personal Goals - https://voluntarily.atlassian.net/wiki/spaces/VP/pages/51740680/Personal+Goals. When you first sign up and when various things happen you'll get these Goal Cards added to your home page. They guide you to do stuff like completing your profile and other workflows including gaining badges. While the basic functions are in place we need volunteers to help implement the card activities themselves. Let me know if you are interested.
Andrew Watkins
@avowkind
We did not manage to get a Code Party organised this side of Christmas so now it's looking like there won't be one until February 2020! However, if you or any friends fancy some summer coding projects and a chance to learn up to date react and node features I'll be around to hand out tickets and answer questions.
Careful watchers of Pull Requests will have noticed the Code Coverage go down recently from nearly 95% to under 80%. What happened? Well, we changed the NYC config so that it counted all the files in the system instead of just those touched by the tests. This showed up some escapee files that were missing out on tests as well as a bunch of things that we didn't intend to test. Another opportunity for volunteer contributors is to pick one of these uncovered components and add some unit tests. Good experience with Ava and Enzyme.
Toby
@thjcse_twitter
Good to hear the updates Andrew. Still trying to track down the next/Ava/Babel cache issues over here. No amazing leads so far, but learnt a bit more and am not giving up yet.
Andrew Watkins
@avowkind
thanks for your persistance.
James Goodman
@guttmann
@avowkind @thjcse_twitter is there a card in jira for the parallel tests/cache issues? I think I have a fix
James Goodman
@guttmann
I've just had two successful test runs in a row without --serial and under 5 minutes to complete
James Goodman
@guttmann
I had a look but couldn't find one so I've created VP-950
should have the PR ready in the next 20 minutes
Walter Lim
@waltzaround
Much appreciated @guttmann
It'll save a lot of pain waiting for the tests to complerte :joy:
Toby has been looking at it - but we will all be happy if you have a solution.
@Eteroa123 any chance of interviewing James for one of our profiles?
Eteroa Lafaele
@Eteroa123
@avowkind yup sweet !
Eteroa Lafaele
@Eteroa123
@guttmann i just slacked you let me know what you think !
Toby
@thjcse_twitter
Merry Christmas all
Walter Lim
@waltzaround
Merry Christmas @toby
Andrew Watkins
@avowkind
Hope everyone is enjoying the post Christmas, pre-new year lull.
Andrew Watkins
@avowkind
alpha.voluntarily.nz has been moved from aws southeast-1 singapore to aws southeast-2 sydney. There should be no detectable change in behaviour - let me know if anything strange happens.
The vly2-alpha database has been moved to vly-alpha so naming of dbs is more consistent.
aswinks88
@aswinks88
Good morning @/all, hope everyone had an amazing holiday.
@avowkind I am looking for some task to work on. :-)
Andrew Watkins
@avowkind
welcome back Aswin - have a read of https://voluntarily.atlassian.net/browse/VP-246 and let me know if you are up for it.
aswinks88
@aswinks88
@avowkind, sorry for the late response. I have assigned the task myself. 🙂
Eteroa Lafaele
@Eteroa123

Kia ora whanau @/all I have a API question , so im working on the education drop down and the api is working because the data I want is coming out when im doing this " localhost:3122/api/education" but anyone know how to fetch that data into the drop down?

From last year i remember that I did this with Andrew

EducationSelector.GetInitialProps = async () => {
const ed = await fetch('/api/education')
//setEducationLevels(ed)
console.log(ed)
}

Does this mean I have to set educationlevel to ed??? Soz fam just getting back into it hahahahaha

James Goodman
@guttmann
I think you need to take the education data from the api and put it into a prop so that would look something like:
EducationSelector.GetInitialProps = async () => {
  const ed = await fetch('/api/education')

  return {
    education: ed
  }
}
Andrew Watkins
@avowkind
Morena @Eteroa123 . GetInitialProps must return an object that contains the properties that you want to be available to the render function. A function returns whatever is the result of the last executed statement in the function. So you need to return the property.
James Goodman
@guttmann
and then in your render function you can access that data with this.props.education
Andrew Watkins
@avowkind
James' example is correct - although if ed is an object already you can just return ed, and access as this.props.ed.
also as EducationSelector is a function not a class you get at the props with props.ed - no this required.
Eteroa Lafaele
@Eteroa123
THANK YOU FAM !!! really appreciate it !!!!!
Eteroa Lafaele
@Eteroa123
Screen Shot 2020-01-07 at 1.26.55 PM.png
@/all kia ora fam i didn't touch this but im getting this error when running local !
OH NAHHHHH FIXED NOW hahahahahaha
Andrew Watkins
@avowkind
Hi all - I’m going to be refactoring the opdetailpage so if anyone is planning on working in that area let me know.
Andrew Watkins
@avowkind
Hi All - Alpha is down this morning due to a build problem caused by some recent package update. I'm investigating.
Andrew Watkins
@avowkind
Alpha back up. please don't update to next 9.1.7
Andrew Watkins
@avowkind
@/all Wed night drinks is on tonight - Corner Bar 5:30