by

Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    keforbes
    @keforbes
    I've never actually used the <Plug> or <Leader> features in Vim so I'm not sure how much work would be required to implement them in order to allow users to remap these subword functions. I agree this would be the 'proper' way and it would be more extensible. I know users have asked for at least the <Leader>feature in the past so it'd be useful for other users even if they don't need/want subword motions.
    Bert Jacobs
    @albertdev
    @keforbes, agreed on the plugin. Do you think muellan's request of making it look for Pascal- / Camel- / Snake-case all in the same textobject possible?
    Bert Jacobs
    @albertdev
    @keforbes Awesome job you did with your spring cleaning and feature implementation run!
    keforbes
    @keforbes
    Ha, thanks. :smile: I'm hoping I'll be able to spend more time with Vrapper now.
    This message was deleted
    Bert Jacobs
    @albertdev
    I'm working on implementing vim-sneak but I'll have to invent more integration points so that the plugin can listen to mode changes and command completion. It's quite extraordinary in which ways this plugin works.
    keforbes
    @keforbes
    Wow, that'd be awesome. I hope you can get it working. Why do you need to listen to mode changes though? I thought it only defined a motion.
    Bert Jacobs
    @albertdev
    It actually has a "submode" called sneak-streak. This will highlight the next few matches in normal and visual mode, but this submode will exit automatically as soon as you run anything other than a new sneak command or repeat ; / ,.
    keforbes
    @keforbes
    @albertdev, I'm seeing some odd behavior in the latest unstable build and I'm curious if you see it too... In Normal mode, I'll hit i or a. The cursor stays as a block cursor and the mode indicator still shows --NORMAL--. And yet as soon as I type a character, that character is shown, the cursor changes to the bar, and the mode indicator changes to --INSERT--. It's like the cursor and mode indicator aren't updating when I enter Insert Mode; they're only updating after I type a character in Insert mode. Everything is functioning correctly, it's just a display issue.
    Bert Jacobs
    @albertdev
    Let me check...
    Bert Jacobs
    @albertdev
    @keforbes I can't reproduce it, though I'm using Windows 10 and JDK 1.6.0 u45.
    keforbes
    @keforbes
    ok, hopefully it's just my environment. I'm on linux fwiw.
    keforbes
    @keforbes
    @albertdev, do you have any thoughts on simplifying our plugin organization? It always bothers me that we have separate *.core, *.eclipse, and *.feature projects in Eclipse for each plugin. I'd rather have one Eclipse project per plugin and I don't think there's any technical limitation preventing us. But, I don't know enough about Eclipse to know if *.feature is required to be a separate project or if it was just a convention the original developers started which we now copy/paste every time.
    Bert Jacobs
    @albertdev
    @keforbes I don't think we can drop the features projects without changing the way we work; Eclipse's interactive build always requires a feature project to have just one feature xml.
    Bert Jacobs
    @albertdev
    With regards to the other projects... I was thinking of keeping the .eclipse projects for the cases where the plugin has a real dependency on Eclipse code (e.g. the window commands plugin) or when it uses other APIs. For all other cases there should be no dependency on Vrapper.Eclipse or any other Eclipse stuff, so ideally we should rework the state provider classes so that they are situated in Vrapper.Core's platform package.
    As for changing how we work: I guess Gradle could automate some build stuff for us, the only stuff we got to check is if we can still combine it with Eclipse for debugging.
    keforbes
    @keforbes
    @albertdev , I'm not sure I understand. Let me try again. I'm fine with having one feature.xml file per project, I was just hoping we could merge (e.g.) ipmotion.core, ipmotion.eclipse, and ipmotion.feature into a single project. One project per plugin. Whether that plugin would have a dependency on vrapper.eclipse would simply depend on whether that plugin required anything in the vrapper.eclipse project. Right now we typically put the Provider classes in a *.eclipse project even though the Providers don't actually use anything from any vrapper.eclipse.* package.
    You're right we have some plugins (like JDT and CDT) which need eclipse packages, but I think we would just include a reference to vrapper.eclipse when that's needed.
    By "reference" I mean the "Plug-in Dependencies" library would reference the vrapper.eclipse project if the plugin needed it, but I don't think that would mean the plugin would require its own separate <plugin>.eclipse project.
    keforbes
    @keforbes
    methodtextobj.png
    For example, methodtextobj.eclipse doesn't actually reference vrapper.eclipse
    keforbes
    @keforbes
    Nevermind. I found my answer http://stackoverflow.com/a/17238477
    Bert Jacobs
    @albertdev
    Exactly, Eclipse is annoying in that regard. We could still merge the .core and .eclipse projects though if we could move the stateprovider stuff to Vrapper.Core.
    Luke deGruchy
    @lukedegruchy
    what's the standard for developing vrapper source files? tabs or spaces? I suspect it's spaces but I've seen a mix of tabs and spaces in some files I don't really have an opinion on either just want to stick with what's recommended
    keforbes
    @keforbes
    I personally prefer spaces but I haven't gone through the codebase to remove all tabs. Also, sometimes Eclipse inserts tabs for me when I want it to insert spaces but I don't notice until I commit. I won't yell at you about either one, I'm just personally a fan of spaces.
    Luke deGruchy
    @lukedegruchy
    ok thanks
    Luke deGruchy
    @lukedegruchy
    I'm trying to test my plugin changes and I've discovered the following problem:
    org.eclipse.core.runtime.CoreException: Problems parsing the feature ${PATH_TO_ECLIPSE_APP}/Eclipse.app/Contents/Eclipse/features/org.eclipse.epp.package.rcp.feature_4.5.2.20160218-0600/feature.xml.
        at org.eclipse.pde.internal.build.site.BuildTimeFeatureFactory.parseBuildFeature(BuildTimeFeatureFactory.java:85)
        at org.eclipse.pde.internal.build.site.BuildTimeFeatureFactory.createFeature(BuildTimeFeatureFactory.java:50)
        at org.eclipse.pde.internal.build.site.BuildTimeSite.createFeature(BuildTimeSite.java:458)
        at org.eclipse.pde.internal.build.site.compatibility.FeatureReference.getFeature(FeatureReference.java:39)
        at org.eclipse.pde.internal.build.site.BuildTimeSite.resolveFeatureReferences(BuildTimeSite.java:316)
        at org.eclipse.pde.internal.build.site.BuildTimeSite.findFeature(BuildTimeSite.java:285)
        at org.eclipse.pde.internal.build.site.BuildTimeSite.findFeature(BuildTimeSite.java:277)
        at org.eclipse.pde.internal.build.BuildScriptGenerator.generateFeatures(BuildScriptGenerator.java:249)
        at org.eclipse.pde.internal.build.BuildScriptGenerator.generate(BuildScriptGenerator.java:127)
        at org.eclipse.pde.internal.core.exports.FeatureExportOperation.doExport(FeatureExportOperation.java:257)
        at org.eclipse.pde.internal.core.exports.FeatureBasedExportOperation.run(FeatureBasedExportOperation.java:50)
        at org.eclipse.core.internal.jobs.Worker.run(Worker.java:55)
    Contains: Error parsing feature: "require" must include at least one "import" element.
    this seems to be unrelated to the feature I'm developing.... that feature.xml file has all of the contents of its <requires> element commented out:
       <requires>
       <!--
          <import feature="org.eclipse.egit"/>
          <import feature="org.eclipse.egit.import"/>
          <import feature="org.eclipse.egit.mylyn"/>
          <import feature="org.eclipse.epp.package.common.feature"/>
          <import feature="org.eclipse.help"/>
          <import feature="org.eclipse.jdt"/>
          <import feature="org.eclipse.m2e.feature"/>
          <import feature="org.eclipse.m2e.logback.feature"/>
          <import feature="org.eclipse.mylyn.bugzilla_feature"/>
          <import feature="org.eclipse.mylyn.context_feature"/>
          <import feature="org.eclipse.mylyn.gerrit.feature"/>
          <import feature="org.eclipse.mylyn.git"/>
          <import feature="org.eclipse.mylyn.hudson"/>
          <import feature="org.eclipse.mylyn.ide_feature"/>
          <import feature="org.eclipse.mylyn.java_feature"/>
          <import feature="org.eclipse.mylyn.pde_feature"/>
          <import feature="org.eclipse.mylyn.wikitext_feature"/>
          <import feature="org.eclipse.pde"/>
          <import feature="org.eclipse.platform.source"/>
          <import feature="org.eclipse.rap.tools.feature"/>
          <import feature="org.eclipse.rcp.source"/>
          <import feature="org.eclipse.recommenders.rcp.feature"/>
          <import feature="org.eclipse.recommenders.mylyn.rcp.feature"/>
          <import feature="org.eclipse.recommenders.snipmatch.rcp.feature"/>
          <import feature="org.eclipse.wb.core.ui.feature"/>
          <import feature="org.eclipse.wb.rcp.feature"/>
          <import feature="org.eclipse.wst.xml_ui.feature"/>
          <import feature="org.eclipse.swtbot.eclipse"/>
          <import feature="org.eclipse.swtbot.eclipse.gef"/>
          <import feature="org.eclipse.swtbot.ide"/>
       -->
    
    <!-- redundant features (already included in other features
          <import feature="org.eclipse.mylyn_feature"/>
          <import feature="org.eclipse.rcp"/>
          <import feature="org.eclipse.wb.core.feature"/>
          <import feature="org.eclipse.wb.swt.feature"/>
          <import feature="org.eclipse.wb.layout.group.feature"/>
          <import feature="org.eclipse.jgit"/>
          <import feature="org.eclipse.platform"/>
          <import feature="org.eclipse.equinox.p2.user.ui"/>
      -->
       </requires>
    is there a known workaround for this?
    first few hits of google weren't useful, even when searching over the past year
    Bert Jacobs
    @albertdev
    That sounds like an Eclipse problem alright. Could you try some Eclipse walk-through to see if it works for simple cases?
    Maybe you simply need to use "Run Eclipse application" and pick the right features?
    Luke deGruchy
    @lukedegruchy
    I'm able to run the plugin in dev mode by Run Eclipse application without issue it's deploying the plugin that I'm having problems with
    the above mentioned issue I corrected by editing the above features.xml to add a single line under "requires"
    Luke deGruchy
    @lukedegruchy
    I've tried deploying to a zip and deploying to a directory but every time I get a provisioning exception no repository found
    of course I have zero experience developing eclipse plugins, which is a big part of the problem
    keforbes
    @keforbes
    I'm not sure if you've looked at any of the feature.xml files within vrapper, but typically all we need in the <requires> block is a reference to vrapper itself:
       <requires>
          <import plugin="net.sourceforge.vrapper.eclipse" version="0.69.20160610" match="greaterOrEqual"/>
          <import feature="net.sourceforge.vrapper" version="0.69.20160610"/>
       </requires>
    Luke deGruchy
    @lukedegruchy
    the feature.xml file I created for my new feature has those two requires imports that's not the issue
    keforbes
    @keforbes
    @albertdev , can you confirm if the :set <option>? feature works? We should be able to append ? to any property name to see its current value but that doesn't display anything for me on my system. I don't know how we would've broken that so I'd just like someone else to verify the behavior. Thanks!
    Bert Jacobs
    @albertdev
    @keforbes, it looks like one of my commits, vrapper/vrapper@1ed8510 is causing it.
    I call commandDone() from enterMode(..) which will apparantly clear the info message. This is no problem for regular Normal mode commands because CommandBasedMode will check the isInfoSet() flag but in this case the info message is lost.
    Bert Jacobs
    @albertdev
    I can't remember why I was calling commandDone() there... Maybe it was my initial attempt to fix #734. I've undone it and pushed it to master.
    Matthew Clark
    @mrclark32493

    Hi all, I seem to be having an issue, not sure what went wrong,
    I installed the plugin via the eclipse market place, and after first install, everything was working fine.

    Now, on each relaunch of eclipse, nothing (vrapper) seems to be working. How can I troubleshoot this?

    Matthew Clark
    @mrclark32493
    Scratch that, was my own mistake. All is well.
    Luke deGruchy
    @lukedegruchy
    on centos 7 I'm noticing an intermittent issue with two eclipse windows and two monitors where the cursor will disappear on the other monitor when alt-tabbing between windows entering insert mode will make it reappear I can't always reproduce it is this a known issue?
    Bert Jacobs
    @albertdev
    @lukedegruchy I had to read that twice, periods and commas are very welcome.
    Luke deGruchy
    @lukedegruchy
    ok
    I'll keep that in mind next time. Is this a known issue?
    Bert Jacobs
    @albertdev
    As for your issue: I don't know about it as I don't know who is running CentOS. It does sound like it could be an OS thing though. Does it also happen when you disable Vrapper? Is the caret completely gone or did it change back to a vertical line?
    Luke deGruchy
    @lukedegruchy
    I haven't been able to reproduce this after disabling vrapper (specifically, by clicking the vrapper button in the task bar)