Please provide a minimal reproduction of your issue in a repo when asking for help on a specific problem.
Why would one need to keep recreating the pipeline? Just create pipelines for each shader right at load-time and hang onto them, right? It would only really be a load-time issue, probably faster than OpenGL anyway because of the lack of need to compile the high level shader code (assuming SPIR-V is used).
I already understand that this isn't really a core "goal" of Vulkan which is why I suggested it as an add-on library.
So I'm trying to create a pipeline for instanced draws, like here: https://github.com/vulkano-rs/vulkano/blob/master/examples/src/bin/instancing.rs
But I need to store
pipeline inside of a struct. What is the type of pipeline? It seems like it has to be an Arc of a GraphicsPipeline, where the GraphicsPipeline takes three template parameters. I can't figure out the third parameter. Best I can come up with is Arc<RenderPass<<Self as DrawControl>::new::scope::CustomRenderPassDesc>> but the compiler says that <Self as DrawControl>::new::scope::CustomRenderPassDesc is not an associated type. I am creating the pipeline within the associated new() function of my struct. Somehow it's creating a new type within that function? How do I use it to fill in the pipeline definition in my struct?
that's the full question, to save spamming here. but basically i can't figure out how to use a
[u8; 4] instead of a [f32; 4] in the vertex struct, since i can't figure out where to specify the attribute's format
@pac85_gitlab Are there any advantages in using Concurrent sharing?
you can use the resource from multiple queues without transitioning the ownership which could perform better if you would have to do them frequently .On the other end if you upload some data from a queue after loading it and the always access it from one queue you are better of transitioning the ownership since resources with exclusive sharing will have better performance when you access them. .
in any case vulkano is still at 0.19.0, I'm started to be worried that it might have been abandoned.
So in the call to AutoCommandBufferBuilder::draw_indexed(), according to this example, you can pass a tuple for the vertex buffer to have a vertex/instance pairing https://github.com/vulkano-rs/vulkano/blob/master/examples/src/bin/instancing.rs#L327
But when I try it in my application, I'm told that it expects a Vec instead. Should this be a Vec?
Also, I'm having difficulty using BufferSlice, because I want to only draw the portion of the buffer that has been filled with data. If I try
BufferSlice::from() and use an &Arc<CpuAccessibleBuffer<T>> as suggested in the documentation, I'm told instead that it's expecting another BufferSlice
I'm trying to figure out some performance issues with my new Vulkano renderer - the drawing overhead currently is even worse than glium. Seems like if I call CpuBufferPool::chunk() about 3000 times a frame performance just dies, not only in try_next_impl() but also cleanup_finished() dropping lots and lots of Arcs. What is the correct way to use CpuBufferPool? It doesn't seem like it's doing any reusing of resources at all!
CpuBufferPool::chunk() is being called every time I submit a draw
What is the best way to resolve this?
The performance is really bad and the existing tutorial resource about buffer usage is insufficient
Vulkano seems to provide no resources about how to 1. reuse buffer resources by putting them in a struct (the examples all exist in a vacuum, nothing about the types of the buffers to store them for later), 2. write data to certain structs (the tutorial seems outdated and I can't access a CpuAccessibleBuffer by index after a call to write(), and no way to rewrite the contents of a CpuBufferPool chunk), 3. use two different types of buffers for the vertex and instance buffers in a draw() call (putting them in a tuple does not compile, and putting them in a vec means both need to be an Arc type, so I have to create a new Arc for each submit, which seems to be adding a lot of overhead) - I don't understand what type the vertex parameter is looking for, and how to make something that satisfies the type with my vertex and instance buffers while still being performant
I have so many questions. Does anyone still read the gitter?
Will I have to contact individual project maintainers to ask for help?
Where are the maintainers?
hi, i'm trying to port some code from an online tutorial to vulkano v0.19. the code looks like:
fn create_command_buffers(&mut self) {
let queue_family = self.graphics_queue.family();
self.command_buffers = self.swapchain_framebuffers.iter()
.map(|framebuffer| {
let vertices = BufferlessVertices { vertices: 3, instances: 1 };
Arc::new(AutoCommandBufferBuilder::primary_simultaneous_use(self.device.clone(), queue_family)
.expect("failed to initialise command buffer builder")
.begin_render_pass(framebuffer.clone(), false, vec![[0.0, 0.0, 1.0].into()])
.expect("failed to begin render pass")
.draw(self.graphics_pipeline.clone(), &DynamicState::none(), vertices, (), ())
.expect("failed to draw")
.end_render_pass()
.expect("failed to end render pass")
.build()
.expect("failed to build render pass"))
})
.collect();
}the full source is here: https://github.com/bwasty/vulkan-tutorial-rs/blob/master/src/bin/14_command_buffers.rs
but there's a change in v0.19 that seems to break stuff: "AutoCommandBufferBuilder methods now take a mutable reference to self instead of taking ownership"
and sure enough, i get an error when building:
error[E0507]: cannot move out of a mutable reference
the compiler says the move is at
.expect("failed to end render pass"), and the reason is "because value has type vulkano::command_buffer::AutoCommandBufferBuilder, which does not implement the Copy trait". any ideas?
@cosmicchipsocket Hi!
Regarding maintenance issue, I put a comment here: vulkano-rs/vulkano#1435 Basically, we are currently on our own. But if someone wants to merge something into the repo, if he needs and wants to fix something he can do so and I can help with merging the PR as I was granted PRs merging access recently.
@korteland Well,
AutoCommandBufferBuilder is not Copy, yes. I think maybe you forgot to put let mut in front of buffer builder variable declaration? Also since AutoCommandBufferBuilder accepting commands by &mut self you have to call each command on separate line. And in the end call .build() by value, not by reference: https://docs.rs/vulkano/0.19.0/vulkano/command_buffer/struct.AutoCommandBufferBuilder.html#method.build
@eliah_lakhin_twitter thanks. I ended up having to rewrite similar to what you said, I ended up with this:
fn create_command_buffers(&mut self) {
let queue_family = self.graphics_queue.family();
self.command_buffers = self.swapchain_framebuffers.iter()
.map(|framebuffer| {
let vertices = BufferlessVertices { vertices: 3, instances: 1 };
let mut builder = AutoCommandBufferBuilder::primary_simultaneous_use(self.device.clone(), queue_family)
.expect("failed to initialise command buffer builder");
builder.begin_render_pass(framebuffer.clone(), false, vec![[0.0, 0.0, 1.0].into()])
.expect("failed to begin render pass")
.draw(self.graphics_pipeline.clone(), &DynamicState::none(), vertices, (), ())
.expect("failed to draw")
.end_render_pass()
.expect("failed to end render pass");
let command_buffer = builder.build().expect("failed to build render pass"));
Arc::new(command_buffer)
})
.collect();
}Hi, I'm rendering a scene twice and the second time i render it I use Equal for depth testing. It works until I put a compute dispatch in between the two, the depth gets all corrupted so I guess the layout isn't being transitioned. For the second pass on the scene I'm binding it to the frame buffer but not writing to it. Any ideas?
does anyone rember this? As it been fixed?
I rewrote my hole app using the unsafe APIs (so I don't really need a fix), but perhaps it is something that can be worked on
@GoncaloFDS Hi, Gonçalo. As far as I know Ray tracing is not supported yet, but there was an attempt in implementation vulkano-rs/vulkano#1350 . And the developer was asking for help. So, if you would like to assist it will be very welcome! :)
Hey this is driving me nutty I am trying to update an old project to "0.20.0" and it was going great but then I ran headfirst into the removal of "window_size_dependent_setup". I was like ok there must be a new way to do this and this but I barely know what I am doing so how do I use this new format
let framebuffer = Framebuffer::start(render_pass.clone())
.add(**Here**).unwrap()
.build().unwrap();