by

Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
    Jack Pryne
    @jpryne
    Ok, I filed a PR. As I'm expecting additional details will be necessary to get this up & running, I'll take charge of testing & revising until I can get this going.
    Thanks for your guidance, Antonio!
    Antonino Siena
    @nifker
    You forgot an 'n' in my name ;)
    Antonino Siena
    @nifker
    Is there actually a specific reason why Vulkano uses structs for extensions and not enums?
    Jack Pryne
    @jpryne
    Oops, my apologies, Antonino. :D
    Eliah Lakhin
    @eliah_lakhin_twitter

    Is there actually a specific reason why Vulkano uses structs for extensions and not enums?

    @nifker I think it was done this way to make Vulkano seamlessly compatible with the external Vulkan-based libraries not aware of Vulkano internals: https://github.com/vulkano-rs/vulkano/blob/master/vulkano/src/extensions.rs#L98 Enums are always sealed, and cannot be extended easily

    Vincenzo Comito
    @clynamen
    @eliah_lakhin_twitter thanks for your answer. I would like to use vulkano to both learn rust and vulkan at the same time. The fact that vulkano is really close to the original API makes it suitable to the scope. However sometime I need to lookup at examples, that's why I asked for a list of projects.
    Jeff Uren
    @jdu_gitlab
    Does this vulkano-rs/vulkano#1245 fix the type annotations needed error being raised in metal when trying to compile the examples?
    Lukas Kalbertodt
    @LukasKalbertodt
    Hello! I'd like to help improve vulkano, especially vulkano-shaders. How is the maintenance situation right now? Not to be too negative, but the project doesn't look too active right now?
    Also: are there some big roadmaps or plans for the near and far future?
    On their Patreon page, rukai says "I used to maintain Vulkano". So who is maintaining Vulkano now?
    Eliah Lakhin
    @eliah_lakhin_twitter
    @LukasKalbertodt Hi, Lukas! The situation is improving. https://github.com/AustinJ235 was recently assigned as a maintainer(by his own initiative). And he is actively reviewing and merging new PRs. So, I believe this is perfectly fine and very welcome to contribute. Despite the issues with maintenance, there are people(including myself) who are actively using Vulkano in their own projects and are interested in the project continuation. Even if we face issues with maintenance in the future we can fork, and there are enough people who can support this initiative too.
    Eliah Lakhin
    @eliah_lakhin_twitter
    Also, you can open a topic in Github Issues. They are active too.
    Austin Johnson
    @AustinJ235
    @jdu_gitlab Some issues may have been solved with MacOS. At this time I don't have the ability to test it. These deps were updated so the CI would be satisfied. It is a requirement for a pull request to pass CI before being merged so this was holding things up. But yes the type annotations needed I believe is the errors that the CI was spitting out, so this will probably fix that issue.
    Right now the prime focus is getting things fixed up and merged that have been awaiting review for a while. I am looking for a release whenever winit gets past its alpha stage of 0.20.
    Azorlogh
    @Azorlogh
    Hey, has anyone encountered this issue when trying to build on Windows ? https://pastebin.com/raw/CAanhs47
    Florian Hänel
    @heeen
    can someone tell a rust beginner how to add an extension by string to the extensions list
    Eliah Lakhin
    @eliah_lakhin_twitter
    @heeen Perhaps, you can call device_extensions! { khr_extension_name => b"extension_key" } macro right in your code. I think it should be compatible to Vulkano as it is not sealed there
    Florian Hänel
    @heeen
    @eliah_lakhin_twitter how do I get that macro
    Eliah Lakhin
    @eliah_lakhin_twitter
    @heeen Sorry, I was wrong. That macro isn't exported. ok. Maybe you can instantiate https://docs.rs/vulkano/0.14.0/vulkano/device/struct.RawDeviceExtensions.html and then just call .insert() to put an extension by name
    Florian Hänel
    @heeen
    @eliah_lakhin_twitter how do I get that into Instance::new
    let rawExt = RawInstanceExtensions::new( vec![
    CString::new("foo").unwrap(),
    CString::new("bar").unwrap()
    ]);
    is there a simpler way to write this
    the trait std::convert::From<&vulkano::instance::extensions::RawInstanceExtensions> is not implemented for vulkano::instance::extensions::RawInstanceExtensions
    Eliah Lakhin
    @eliah_lakhin_twitter
    @AustinJ235, @nifker Guys, can you advice on @heeen 's question, please?
    Florian Hänel
    @heeen
    let ext = InstanceExtensions::from(&raw_ext);
    let instance = Instance::new(None, &ext, None).unwrap();
    this seems to work
    Eliah Lakhin
    @eliah_lakhin_twitter
    ok )
    Lukas Kalbertodt
    @LukasKalbertodt
    @eliah_lakhin_twitter Thanks for the information! :)
    Florian Hänel
    @heeen
    ok so it does not actually work
    Eliah Lakhin
    @eliah_lakhin_twitter
    @heeen I think you can debug it down a little. My apology I cannot give you more useful answer, I'm learning too. Maybe someone understands this topic better. If not, once you describe it you can share with us or open a PR with the fix
    Florian Hänel
    @heeen
    ok so this is odd
    I managed to pass a list of extensions
    and if one does not exist, it fails to create the instance
    however, if it succeeds, the list of loaded extensions is still empty
    Florian Hänel
    @heeen
    vulkano-rs/vulkano#1253 here's the issue
    Austin Johnson
    @AustinJ235
    interesti
    Lucas Kent
    @rukai
    @AustinJ235 it's great to see the work you've been doing on vulkano! Well done.
    Austin Johnson
    @AustinJ235
    thanks @rukai
    Austin Johnson
    @AustinJ235
    @heeen I have responded to your issue. Hope I've helped
    Florian Hänel
    @heeen
    Thanks @AustinJ235
    imho the thing returned from loaded_extensions should be able to list any extension, not just the ones hardcoded into volkano. I'm not proficient enough in rust yet to figure out how that would be done
    while not breaking API too much that is
    actually even better would be to be able to construct InstanceExtensions from either enum symbols or string names
    Austin Johnson
    @AustinJ235
    the function does take anything that impl IntoIterator CString we could look at chaning that to Strings. But the non raw version is a struct with each extension as a bool, so unless we add an extra field that is a vec of Strings.
    DamonPalovaara
    @DamonPalovaara
    I've been reading through the documentation for the past hour and cannot figure out how to send a uniform buffer
    Florian Hänel
    @heeen
    so with the simple triangle example when I press close it takes 10 or so seconds until the window actually closes
    my windowmanager actually complains about the unresponsive window
    when I add a println in the close handler and the loop handler I can see it happily looping, then the close handler gets called after several seconds, then still some seconds later the window closes
    I tried the simplest example from the winit docs and there it will loop 3 times more after the close handler, then closes which is reasonable