stefanha: that's good. do you have a plan to use "milestones" or "project boards" where shows the project progression status? it's basic github features.
I am now re-studying C++ development, it was new for me. SPDX license header looks smart. replaced traditional fat license header.
One question, no more signed-off-by in source files ?
(I confirmed it's used in commit messages)
I am not familiar with modern open projects. few years blanks.
tea There is a list of completed/in-progress features in README.md. The readme is displayed on the main page of the repository.
I'm not adding authorship information into source files since git already tracks it for each line of code. This varies between projects, many still put "Copyright 2021 My Name" at the top of files, which helps when the file is copied to another project but it doesn't capture the true line-by-line authorship information.
I see, now I understood it the check list in README.md shown the status.
about signed commit. commit signature verification can replace ? I setup GPG signed commit.
stefanha: which code base do you implement
there are two known issues about audio (not wahjam's. this is a general original ninjam code or JamTaba code topics)
ninjam: can take stereo input but output (upload?) is mixed as mono
jamtaba: can stereo output, but buffer size large, so users have to wait the first two intervals.
reaninjam: resolves both, but not open source as I know.
tea The new client I'm working on is Wahjam2. It's written from scratch and does not use NINJAM code.
I still maintain Wahjam and that is based on the NINJAM code.
Wahjam is mono. It mixes down stereo inputs.
Wahjam2 it's designed for stereo but will be mono until the first release because it needs to stay compatible with Wahjam until users migrate to Wahjam2.
I didn't know Jamtaba requires 2 intervals for stereo. That sounds strange. In Wahjam2's stereo code I'm using Ogg Vorbis stereo support and that is designed to take advantage of duplicate information in stereo audio to reduce the compressed size. I expect it will be possible to run stereo without waiting two intervals after connection.
stefanha: I was thinking what I can contribute, (1) Translation resource (2) AppVeyor for windows CI/CD (without ASIO/VST for license reason) (3) Plugin frameworks (4) Discord Bot (5) Songbook with metronome component.
right now, nothing to commit publish. I will start as personal repo
and make it reusable for another projects. the use scenario are
I need your advice about the license.
is MIT Ok ? or Apache license is popular now?
my basic stance is, I did not care license of code-I-wrote,
I care when copy other's code. open as possible.
I worry here is if the license had issue and have to change later.
I want to select flexible one first.
The Output fader is for sending to server?
it's a good idea to separate local channel monitor and sending volume.
one of big confusion in NINJAM UI, local channel effect to monitor only,
when users ask to down volume more, they down the local channel fader
not sending volume. they does not care which "volume"
Output volume can show the actual volume which others will hear.
tea "Output" is the master volume for monitoring the whole jam. It doesn't affect the upload volume. Thanks for the suggestion, the current prototype let's the user control the local channel upload volume, but I realized it doesn't let them see a different monitoring volume.
Personally I monitor myself at the same volume as the upload volume, but I know some people like to hear themselves louder.