Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
    canandlamp
    @canandlamp
    .
    stefanha
    @stefanha:matrix.org
    [m]
    Welcome, canandlamp!
    canandlamp
    @canandlamp
    thanks. if it's all ok to you all, i'll need to limit any focus here, this side, on basic generic web-browser integration of a jam client compatible with jammr, rather than on the standalone client. my programming skill is very limited, so i'm not sure to what extent i can actually contribute working code for actual distributed implementation, but i will see what i can do
    Stefan Hajnoczi
    @stefanha
    @canandlamp Yes, we can discuss non-Wahjam implementations. If you want to do a web-based client then https://github.com/BHSPitMonkey/ninjam-js is a good starting point. I'm not very familiar with its code but let me know if you have any questions or ideas you want to discuss.
    tea
    @teamikl:matrix.org
    [m]

    Hello, I am new to Matrix. using Element client.
    it look good like Slack.

    question, does the community have sub category(room or channel, I dont know Matrix term yet) for notification?

    Stefan Hajnoczi
    @stefanha
    Right now I'm working on Wahjam2 (https://github.com/wahjam/wahjam2), a new implementation of the stand-alone and VST/AudioUnit plugin client. It will improve things that are hard to address in the current Wahjam client.
    Welcome @tea! :)
    @tea Additional chat rooms can be created on gitter.im. There is a Wahjam "community" and this is the main room.
    tea
    @teamikl:matrix.org
    [m]
    Hi, I've just installed now.
    it was just interest for now, where I will see those notification (like commit, issue messages from github)
    Stefan Hajnoczi
    @stefanha
    @tea Good question, I'm new to gitter.im. I'll check if there is a GitHub chat bot.
    tea
    @teamikl:matrix.org
    [m]
    oh, I had used gitter. there is webhooks settings in github repo
    I am not sure how it work via Matrix. community can have multiple sub-rooms ? or here is single room ? (then every messages received here)
    Stefan Hajnoczi
    @stefanha
    Matrix does not have sub-rooms. They would be separate rooms but probably named wahjam_one, wahjam_two, wahjam_three.
    @tea Should we create a wahjam_notifications room so the GitHub webhook can send commit notifications?
    tea
    @teamikl:matrix.org
    [m]
    I do not know how it's used in modern project. I know is discord or slack use case. they can have sub-channel(room ? or something sub-categoly) for notifications
    it's ok if Client had a filtering feature.
    Stefan Hajnoczi
    @stefanha
    I have added a new wahjam/notifications gitter chat room. The Matrix name is #wahjam_notifications:gitter.im.
    The GitHub webhook is set up so you should see pushes from now on.
    One sec, I'll try a test push to wahjam.git.
    tea
    @teamikl:matrix.org
    [m]
    ok, I joined. read-only room ? I did not mean I want separate room now. it's ok later when we felt notification logs make mess chat.
    Stefan Hajnoczi
    @stefanha
    I see the test notification. The gitter web client shows the event in the "Activity" panel on the right side of the screen.
    Hmm...I don't see anything in my Matrix client (Element on Android). I guess the GitHub activity is not yet visible via Matrix :(.
    It's probably a gitter.im web-only feature.
    @tea There is probably a Matrix GitHub integration we could use instead of the native gitter.im integration. Then the push would be visible in Matrix too.
    If we don't get the notifications working in a useful way I will delete the wahjam/notifications room again. We can set it up properly when it becomes necessary.
    I'm going to go cook dinner now. Have a nice weekend!
    tea
    @teamikl:matrix.org
    [m]
    ok. I will search more info too. you too, here it late time. sleep for now
    Stefan Hajnoczi
    @stefanha
    @tea Remote channel download and playback is working for the first time in Wahjam2! This is just the beginning (no UI, probably still has bugs). Tomorrow I'll start working on local channel recording and upload.
    tea
    @teamikl:matrix.org
    [m]

    stefanha: that's good. do you have a plan to use "milestones" or "project boards" where shows the project progression status? it's basic github features.

    I am now re-studying C++ development, it was new for me. SPDX license header looks smart. replaced traditional fat license header.

    One question, no more signed-off-by in source files ?
    (I confirmed it's used in commit messages)
    I am not familiar with modern open projects. few years blanks.

    stefanha
    @stefanha:matrix.org
    [m]

    tea There is a list of completed/in-progress features in README.md. The readme is displayed on the main page of the repository.

    I'm not adding authorship information into source files since git already tracks it for each line of code. This varies between projects, many still put "Copyright 2021 My Name" at the top of files, which helps when the file is copied to another project but it doesn't capture the true line-by-line authorship information.

    tea
    @teamikl:matrix.org
    [m]

    I see, now I understood it the check list in README.md shown the status.

    about signed commit. commit signature verification can replace ? I setup GPG signed commit.

    stefanha
    @stefanha:matrix.org
    [m]
    Signed-off-by is not related to GPG signed commits. Signed-off-by has a legal meaning (called Developer Certificate of Origin). It declares that you have permission to contribute the code. Here is the full DCO text: https://developercertificate.org/
    GPG signing is used for trust/security but doesn't necessarily have a legal meaning.
    Some open source projects use DCO. Some use signed GPG commits or tags. It depends on the project.
    stefanha
    @stefanha:matrix.org
    [m]
    Signed commits are especially useful if you want to merge commits without being able to trust the communications channel. For example, email is famous for spoofing. I think signing is less useful on GitHub because an attacker would need the ssh private key and/or GitHub credentials of a developer to send a pull request on their behalf.
    Signing still adds extra security on GitHub, but less compared to email. Not many projects on GitHub require signing (I have never seen it).
    tea
    @teamikl:matrix.org
    [m]
    stefanha: thx info it's called DCO. I see those has different roles.
    stefanha
    @stefanha:matrix.org
    [m]
    tea I have implemented minimal local channel support so that audio is uploaded to the server by the Wahjam2 client. Next I need to test it and start working on the QML user interface (mixer, Send button, VU meters, etc).
    Stefan Hajnoczi
    @stefanha
    It still requires some debugging but I think the audio upload is close to working now.
    tea
    @teamikl:matrix.org
    [m]

    stefanha: which code base do you implement
    there are two known issues about audio (not wahjam's. this is a general original ninjam code or JamTaba code topics)

    ninjam: can take stereo input but output (upload?) is mixed as mono
    jamtaba: can stereo output, but buffer size large, so users have to wait the first two intervals.
    reaninjam: resolves both, but not open source as I know.

    stefanha
    @stefanha:matrix.org
    [m]

    tea The new client I'm working on is Wahjam2. It's written from scratch and does not use NINJAM code.

    I still maintain Wahjam and that is based on the NINJAM code.

    Wahjam is mono. It mixes down stereo inputs.

    Wahjam2 it's designed for stereo but will be mono until the first release because it needs to stay compatible with Wahjam until users migrate to Wahjam2.

    I didn't know Jamtaba requires 2 intervals for stereo. That sounds strange. In Wahjam2's stereo code I'm using Ogg Vorbis stereo support and that is designed to take advantage of duplicate information in stereo audio to reduce the compressed size. I expect it will be possible to run stereo without waiting two intervals after connection.

    tea
    @teamikl:matrix.org
    [m]
    @stefanha: stereo and two intervals are independent topics, I might explain it wrong.
    no worry if the new code was written from scratch.
    I understand the migration plan.