def doStuff(x: Thing) = { x.doThing(); list.add(x) } so that list holds the Things I have operated on. How would I write that with Warts.unsafe?
I had code that did
if (list.isEmpty) {
stuff(list.head, list.tail)
} else {
otherStuff()
}Warts.TraversibleOpts told me to use headOption instead. Warts.OptionPartial won't like
list.headOption.ifPresent(stuff(_, list.tail)).orElse(() => otherStuff()).getbut I don't see another way to do it. getOrElse(otherStuff()) is wrong, because calling otherStuff is wrong if the list is not empty.
I suspect the problem is that Option should have a getOrElse that takes a function to build the result, not just getOrElse(T). Is there another way to do this?
=>T and not T, so the parameter will not be evaluated in the nonEmpty case
Hi guys, I have a question, although it might be more of an sbt-in-general type of question, but anyway.
I have a multi-project build for which I'd like to enable wartremover in one place.
I'd like to use something like the following, but it doesn't seem to work.
ThisBuild / Compile / wartremoverErrors := Warts.all
ThisBuild / Test / wartremoverErrors := Seq.emptyI can use the common settings approach, but there must be a better solution.
trying to install wartremover, added to plugins.sbt
addSbtPlugin("org.wartremover" % "sbt-wartremover" % "2.4.3")and
wartremoverErrors ++= Warts.unsafe to build.sbtsbt compile produces errors like[error] bad option: -P:wartremover:traverser:org.wartremover.warts.Any
[error] bad option: -P:wartremover:traverser:org.wartremover.warts.AsInstanceOf
[wartremover:NonUnitStatements] Statements must return Unit
[error] alist(arr).map { case k =>
[error] ^
[error] one error foundobject WeightedShuffle {
private def swap[T](arr: Array[T], a: Int, b: Int): Unit = {
val t = arr(a)
arr(a) = arr(b)
arr(b) = t
}
def shuffle[T: ClassTag](wpts: Seq[T], getWeight: T => Double): Seq[T] = {
val eps = 1e-6
val rnd = Random
val arr = wpts.toArray
(0 to arr.length - 1).map { k =>
val weights = arr.view.slice(0, arr.length - k).map(getWeight(_) + eps)
val totalWt = weights.sum
val rWt = rnd.nextDouble * totalWt
val cWt = weights.scan(0d)(_ + _) // cumulative sum
val tgt = cWt.indexWhere(_ > rWt) - 1
swap(arr, tgt, arr.length - k - 1)
}
arr.reverse
}
}
Hi,
I have a question If I need to add some custom rules for project build for example
- If the number of tests less than 2 let the build fail.
- If there is any "println" or some special commands.
I don't have any experience with wartremover library, But How can we use it for this purpose?
shouldEqual from ScalaTest with this rule: [wartremover:NonUnitStatements] Statements must return Unit.I don't want to disable this rule on the whole file or even on the tests because it's useful, I just want to disable it for all ScalaTest things. Is it possible?
Hi All, I know Wartremover uses Scala compiler's built-in warning system. Do you know whether there is any SBT plugin or any other possibility to generate the XML or HTML report from the analysis?
That would be something similar to what Scapegoat offers, but it includes only this linter related inspections in the report. I want to find a way to collect the default and Wartremover's warnings.
Is there any SBT plugin making it possible? Do you have any other idea?
Hi
I am trying to disable the Var, Return and MutableDataStructures warts. This works fine with something like
wartremover -traverser org.wartremover.warts.Return -traverser org.wartremover.warts.Var -traverser org.wartremover.warts.MutableDataStructures file.scalaThe problem is that wartremover complains about the code
Using(Source.fromFile(name))which has nothing to do with the warts above. "Plain" Scala would accept this code (wart remover complains that the value Using is not found). Is this because Using was introduced in Scala 2.13, but wart remover seems to be only tested with Scala 2.12? Thanks!
[wartremover:TraversableOps] head is disabled - use headOption instead and doesn't suggest whether it's an error or warning
ExplicitResultTypes that automatically inserts the inferred type annotations on public members https://scalacenter.github.io/scalafix/docs/rules/ExplicitResultTypes.html I use it in several of my projects and it's worked pretty well in my experience
@rfan-debug no worries, I tried using wart remover v2.3.7 with sbt 0.13.8 and scala 2.11.11..works fine for me (refer this https://github.com/wartremover/wartremover/blob/da1e629e3367c0ec/docs/_posts/2017-02-11-install-setup.md)
Thank you! that's really helpful!
toString and StringPlusAny with wartremover. It works well, but we use a lot of integer/long/etc for metrics log, I get tons (several hundreds) of warning, which make it almost unusable. I would like to know if there is a way to tell wartremover "except integer"?