wartremover/Lobby

Sanjiv Sahayam

@ssanj

I guess the question I have at the moment is whether to fix the errors outlined by the wart, because even though at the definition point Right and Left infer Nothing, when actually returned through the function in which they are defined in, the types are correct. So any code using the function would get the correct types. But I will have a look with the typer to see what's going on.

Greg Pfeil

@sellout

wartremover/wartremover#263

Dmitry Polienko

@nigredo-tori

@ssanj, here it is. Works as expected.

    def withTypes(value: Int): Either[String,Int] = if (value.>(10))
      scala.`package`.Right.apply[Nothing, Int](value)
    else
      scala.`package`.Left.apply[String, Nothing](scala.StringContext.apply("less than 10: ", "").s(value))

Greg Pfeil

@sellout

@ssanj Ah, couldn’t figure out your handle via the iOS app. But that issue number is for you.

Sanjiv Sahayam

@ssanj

@sellout Thanks! :)

Sanjiv Sahayam

@ssanj

@nigredo-tori Your sample does work as expected, but the version I presented earlier doesn't. I wonder why?

Dmitry Polienko

@nigredo-tori

@ssanj, I probably was not clear enough. The sample I gave is what the typer produces, and it's what wartremover sees. So as expected it sees Nothing and complains.
However if you feed this fully typed code to the compiler from the start, the typer does not mark the Nothing node as an inferred type, so wartremover assumes it was provided by the user, and does not raise any warnings.

Sanjiv Sahayam

@ssanj

@nigredo-tori oh right. Cool. Yeah, I'm trying to avoid giving the compiler the full definition of Right and Left. If I do I can give it the correct types from the start as you mentioned. I don't have to because the compiler infers the correct types to return from withTypes which is how the callers of this method see it and nothing within the withTypes method uses the incorrectly inferred types. Not sure if that makes sense? So I guess what I'm saying is that even if the compiler infers Nothing for a Left or Right, if that expression has an explicit Either type defined (either via a type ascription or return type) that doesn't have Nothing in it, then wartremover can relax because the expected type will be chosen.

example:

val l: Either[String, Int] = Left("error") 
//I don't expect WR to complain because the type ascription sets the correct type for all intents and purposes for the use of l.

Dmitry Polienko

@nigredo-tori

@ssanj, here, again, the typer infers Nothing...

if that expression has an explicit Either type defined (either via a type ascription or return type) that doesn't have Nothing in it, then wartremover can relax because the expected type will be chosen.

It would be nice, but that means the wart would have to analyze the parent nodes, and to somehow guess that the types are explicit enough (whatever this means), which sounds kind of arbitrary and needlessly complicated (read "fragile"). It gets more difficult the more possibilities we consider, and before long we're basically reimplementing the typer...
It seems like the only sane way to disable the warning for such cases is to disable it for all or some contravariant positions, which arguably defeats the point.
As an aside, you might want to challenge yourself by using the combinators that don't need covariance. E.g. with the mouse library (complementing cats), your initial example turns to this:

def withTypes(value: Int): Either[String, Int] =
  (value > 10).either(s"less than 10: $value", value)

which does not include any type arguments that can be Nothing.

Sanjiv Sahayam

@ssanj

@nigredo-tori Thanks for taking the time to talk this through. I see what you mean. I would like not to turn this wart off. I like the either usage from mouse. I'll give that a go. :)

Ghost

@ghost~54f4b69115522ed4b3dcb16d

Trying to build current master with fresh clone, does anyone else see:

[error] Modules were resolved with conflicting cross-version suffixes in {file:/Users/andrew/tmp/wartremover/}sbt-plugin:
[error]    org.scala-lang.modules:scala-xml _2.13.0-M3, _2.12
java.lang.RuntimeException: Conflicting cross-version suffixes in: org.scala-lang.modules:scala-xml
    at scala.sys.package$.error(package.scala:27)
    at sbt.ConflictWarning$.processCrossVersioned(ConflictWarning.scala:46)
    at sbt.ConflictWarning$.apply(ConflictWarning.scala:32)

Martin

@mrt181

hi, I can't configure the wartremoverExclude correctly

this is wHat i have configured:

 lazy val wartremoverSettings =                               
   Seq(                                                       
     wartremoverErrors in (Compile, compile) ++= Warts.unsafe,
     wartremoverExcluded += sourceManaged.value               
   )

and this is what I get (abbreviated)

[error] C:\cygwin64\home\r892107\sourcecode\topgun\target\scala-2.12\src_managed\main\com\google\api\AuthProvider.scala:81:11: [wartremover:Var] var is disabled
[error]       var _done__ = false
[error]           ^
[error] C:\cygwin64\home\r892107\sourcecode\topgun\target\scala-2.12\src_managed\main\com\google\api\AuthRequirement.scala:118:19: [wartremover:Any] Inferred type containing Any
[error]       __fieldsMap.getOrElse(__fields.get(0), "").asInstanceOf[_root_.scala.Predef.String],
[error]                   ^
[error] C:\cygwin64\home\r892107\sourcecode\topgun\target\scala-2.12\src_managed\main\com\google\api\AuthRequirement.scala:119:19: [wartremover:Any] Inferred type containing Any
[error]       __fieldsMap.getOrElse(__fields.get(1), "").asInstanceOf[_root_.scala.Predef.String]
[error]                   ^
[error] C:\cygwin64\home\r892107\sourcecode\topgun\target\scala-2.12\src_managed\main\com\google\api\AuthRequirement.scala:118:50: [wartremover:AsInstanceOf] asInstanceOf is disabled
[error]       __fieldsMap.getOrElse(__fields.get(0), "").asInstanceOf[_root_.scala.Predef.String],
[error]                                                  ^
[error] C:\cygwin64\home\r892107\sourcecode\topgun\target\scala-2.12\src_managed\main\com\google\api\AuthRequirement.scala:119:50: [wartremover:AsInstanceOf] asInstanceOf is disabled
[error]       __fieldsMap.getOrElse(__fields.get(1), "").asInstanceOf[_root_.scala.Predef.String]
[error]                                                  ^
[error] C:\cygwin64\home\r892107\sourcecode\topgun\target\scala-2.12\src_managed\main\com\google\api\AuthRequirement.scala:34:5: [wartremover:DefaultArguments] Function has default arguments
[error]     providerId: _root_.scala.Predef.String = "",
[error]     ^
[error] C:\cygwin64\home\r892107\sourcecode\topgun\target\scala-2.12\src_managed\main\com\google\api\AuthRequirement.scala:71:24: [wartremover:NonUnitStatements] Statements must return Unit
[error]       while (!_done__) {
[error]                        ^
[error] C:\cygwin64\home\r892107\sourcecode\topgun\target\scala-2.12\src_managed\main\com\google\api\AuthRequirement.scala:93:35: [wartremover:Null] null is disabled
[error]           if (__t != "") __t else null
[error]                                   ^
[error] C:\cygwin64\home\r892107\sourcecode\topgun\target\scala-2.12\src_managed\main\com\google\api\AuthRequirement.scala:97:35: [wartremover:Null] null is disabled
[error]           if (__t != "") __t else null
[error]                                   ^
[error] C:\cygwin64\home\r892107\sourcecode\topgun\target\scala-2.12\src_managed\main\com\google\api\AuthRequirement.scala:126:62: [wartremover:OptionPartial] Option#get is disabled - use Option#fold instead
[error]         __fieldsMap.get(scalaDescriptor.findFieldByNumber(1).get).map(_.as[_root_.scala.Predef.String]).getOrElse(""),
[error]                                                              ^
[error] C:\cygwin64\home\r892107\sourcecode\topgun\target\scala-2.12\src_managed\main\com\google\api\AuthRequirement.scala:127:62: [wartremover:OptionPartial] Option#get is disabled - use Option#fold instead
[error]         __fieldsMap.get(scalaDescriptor.findFieldByNumber(2).get).map(_.as[_root_.scala.Predef.String]).getOrElse("")
[error]                                                              ^
[error] C:\cygwin64\home\r892107\sourcecode\topgun\target\scala-2.12\src_managed\main\com\google\api\AuthRequirement.scala:129:15: [wartremover:Throw] throw is disabled
[error]     case _ => throw new RuntimeException("Expected PMessage")
[error]               ^
[error] C:\cygwin64\home\r892107\sourcecode\topgun\target\scala-2.12\src_managed\main\com\google\api\AuthRequirement.scala:133:113: [wartremover:Throw] throw is disabled
[error]   def messageCompanionForFieldNumber(__number: _root_.scala.Int): _root_.scalapb.GeneratedMessageCompanion[_] = throw new MatchError(__number)
[error]

I can't ignore the generated code

Martin

@mrt181

nevermind found the solution: wartremoverExcluded ++= PathFinder(sourceManaged.value).**("*.scala").get

Dmitry Bugakov

@dmitrybugakov

Hello,
I have subprojects in sbt file, how I can add them in wartremover?
Can you help?

ritschwumm

@ritschwumm

@dmitrybugakov with the latest version i just have sth like this in my build.sbt: inThisBuild(Seq(wartremoverErrors ++= Seq( ... )))

Dmitry Bugakov

@dmitrybugakov

@ritschwumm thank you)

PsyfireX

@PsyfireX

Does wart remover support flagging discarded values out of the box, or would I have to write a custom rule for that?

Bijan Chokoufe Nejad

@bijancn

@PsyfireX there is a compiler warning for that (which you can turn into an error): "-Ywarn-value-discard"

PsyfireX

@PsyfireX

There's an unfortunate side-effect that -Xfatal-warnings is an "all or nothing" flag, converting every warning into a compiler error.

There are workarounds, but I'm trying to consider all options which is why I'm also looking at wartremover

Bijan Chokoufe Nejad

@bijancn

yeah I had some success with https://github.com/ghik/silencer for the cases that don't allow any other work arounds

PsyfireX

@PsyfireX

That does seem to be the quickest solution.

Rob Cornell

@rcornell

Hey all, with Maven, is there a way to pass the equivalent of this argument: wartremoverErrors ++= Warts.allBut(Wart.NonUnitStatements)

Rob Cornell

@rcornell

@PsyfireX Any idea about the maven implementation above?

John-Michael Reed

@JohnReedLOL

I am working on a horrible codebase and if I run WartRemover on it, the thing will blow up with thousands of warnings and errors. Is there a way for me to run WartRemover just on a single file in the codebase so that I can ignore all the issues from all the other files? The file consists of a single Scala object or class.

Rob Cornell

@rcornell

You could potentially set it to warnings only: "-P:wartremover:only-warn-traverser:org.wartremover.warts.Unsafe"

Could also build up exclusions to packages other thanthe one you're focused on:

To exclude a file or directory from all checks, use wartremoverExcluded in your build.sbt file:

wartremoverExcluded += baseDirectory.value / "src" / "main" / "scala" / "SomeFile.scala"
wartremoverExcluded += sourceManaged.value

@JohnReedLOL

Philipp Martini

@maphi

Hey, it looks like wartremover and better-monadic-for get in their way:

for {
  ...
  (a,b) = foo
} yield ()

this reports error: [wartremover:NonUnitStatements] Statements must return Unit

any suggestions? is there an order to specify for sbt scalac plugins?

Philipp Martini

@maphi

btw: using wartremover 2.3.7 and better-monadic-for 0.3.0-M4

Philipp Martini

@maphi

Problem solved by better-monadic-for maintainer: Fix is adding scalacOptions ++= Seq("-P:bm4:no-map-id:n", "-P:bm4:no-tupling:n"),

Nikolay Danshin

@nDanshin

hello, guys. I have sbt 0.13.6 and Scala version 2.12.4. And I try to add wartremover. Which version of it should I use?
addSbtPlugin("org.wartremover" % "sbt-wartremover" % "2.3.7") thats ok?

John-Michael Reed

@JohnReedLOL

@nDanshin - just copy-pasting whatever it says on the website/docs. If you don't know how to use sbt, read the sbt docs first.

Hey, I want to add WartRemover to an old multi-project Build.scala file. I am talking sbt version 13.5 old. How do I do that?

Victor Viale

@Koroeskohr

hi there ! I tried fiddling with the project today, and realised that the Var wart wasn't caught when a var is defined inside a trait, is there a reason why ? :)

Ólafur Páll Geirsson

@olafurpg

@Koroeskohr that could be because var inside traits desugar into private fields with a setter method

Nicolas Rinaudo

@nrinaudo

I'm hitting something that feels like a bug: with Scala 2.13, the StringPlusAny wart will trigger on string interpolation

is that working as intended?

Greg Pfeil

@sellout

@nrinaudo I feel like that is the correct behavior (unless you’re interpolating a String).

Nicolas Rinaudo

@nrinaudo

oh, it's been pointed out that there's actually a bug open for that: wartremover/wartremover#447

@sellout I think it's debatable. You might want to disallow string interpolation with non string members, but:

that seems harsh!
it's really odd that it'd trigger StringPlusAny

I think I understand the purpose of StringPlusAny, and that's not it

Where communities thrive

People

Repo info

Activity