Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
    WanderWang
    @WanderWang
    @octogonz hey pete, does rush change can execute with full args instead of " Interactive command line ” ? for example : ```rush change --projectA:type=A,message=B --projectB:type=C,message=D
    I want to add a git pre-commit hook , it will recieve git specific message and execute rush change with this message
    Other way is can i use programming rush API ?
    instead of cli rush command
    Pete Gonzalez
    @octogonz
    @iclanton was working on adding command-line options for automating rush change in PR microsoft/web-build-tools#1389
    A while ago we had also started work on an ChangeManager API; if you have specific scenarios you'd like to see supported, feel free to propose them
    Jacob Raihle
    @raihle
    Hi! I'm moving a few packages into one rush repository. One of the packages is built with rollup, which prints to STDERR for all output files (which clutters rush's output and causes a non-zero exit code). I've failed to make rollup stop doing this (without suppressing all warnings), can I somehow tell rush that this output is safe?
    Jacob Raihle
    @raihle
    Apparently a bug in our version of rollup, nevermind
    Nikolas Poklitar
    @nik0kin
    @raihle which rollup version fixes this?
    Jacob Raihle
    @raihle
    @nik0kin 1.6.5
    Nikolas Poklitar
    @nik0kin
    I dont see that version... we made a wrapper for rollup that redirects rollups's stderr to stdout. The stderr was mostly the "created dist/index.js in 1.1s" messages, and for any other warnings we use rollupConfig's "onwarn" to throw an error on any warnings, which causes a non-zero exit for rollup
    Darsi Anandarajah
    @darsi-an
    Hey I am trying to build and debug rush but I keep coming across '[@microsoft/node-core-library] failed to build!' error when i use 'rush rebuild' or 'rush build'. Any suggestions?
    Danny Wolf
    @wolfd
    Is there no stacktrace anywhere? Have you checked build error output in libraries/node-core-library/node-core-library.build.error.log or the like?
    Darsi Anandarajah
    @darsi-an
    Yeah I'm getting Error - 'jest' sub task errored after 3.92 s Jest tests failed
    Jacob Raihle
    @raihle
    @nik0kin My bad, 1.16.5
    Jacob Raihle
    @raihle
    And now that I have it, running with --silent and just using onwarn: function(w, h) { h(w); } does the trick
    Pete Gonzalez
    @octogonz

    Hey I am trying to build and debug rush but I keep coming across '[@microsoft/node-core-library] failed to build!' error when i use 'rush rebuild' or 'rush build'. Any suggestions?

    @darsi-an Is this a clean clone of the master branch? If so, could you tell us your OS and Git commit hash?

    I just tried rush rebuild and it's working fine for me.
    Darsi Anandarajah
    @darsi-an
    @octogonz Thanks for responding, Yeah I am using a clean clone of the master branch. I run into the same error when trying to build off my forked repo. I am using Windows 10 and git commit hash: 2cf2e48ae.
    Pete Gonzalez
    @octogonz
    Hrmmm... That's the hash that just built successfully for me. Is there anything interesting in your node-core-library.build.log?
    (Also, did you try rush install --purge?)
    Pete Gonzalez
    @octogonz
    Rush aims to have deterministic behavior on different developer machines, so I'm pretty interested in your issue @darsi-an
    Darsi Anandarajah
    @darsi-an
    So I ran rush install --purge, then tried to rebuild and ran into an error. This one however, is different from the node-core-library.build.error earlier, 'test' errored after 16 s and Process terminated before summary could be written, possible error in async code not continuing!, I investigated this just a little and might be a gulp related issue. Also, I tried to build just the node-core library using gulp as suggested in the contributions wiki, but that also failed.
    Pete Gonzalez
    @octogonz
    which version of NodeJS are you using?
    Darsi Anandarajah
    @darsi-an
    10.16.3
    Pete Gonzalez
    @octogonz
    BTW if you do rush rebuild --verbose it should show the errors on the console
    Darsi Anandarajah
    @darsi-an
    Okay, noted.
    Pete Gonzalez
    @octogonz
    I'll try rebuilding with 10.16.3 and see if that changes anything
    is your Git clone under a long folder path that might be hitting the MAX_PATH limit?
    Darsi Anandarajah
    @darsi-an
    I never set the flag
    Pete Gonzalez
    @octogonz
    I mean what's the path for your working folder. E.g. mine is D:\GitRepos\wbt
    Darsi Anandarajah
    @darsi-an
    clone it right to desktop
    C:\Users\<NAME>\Desktop\test\wbt
    Pete Gonzalez
    @octogonz
    How many characters are in <NAME>?
    Darsi Anandarajah
    @darsi-an
    Darsi An
    Pete Gonzalez
    @octogonz
    It's a bit of a longshot, but maybe you could try cloning into C:\wbt to eliminate this possibility
    Darsi Anandarajah
    @darsi-an
    Includes a space
    yeah in will try that
    I*
    Pete Gonzalez
    @octogonz
    Everything built successfully for me using Node 10.16.3 and 2cf2e48ae on Windows 10 Enterprise
    Are you using the Linux subsystem by any chance?
    Darsi Anandarajah
    @darsi-an
    No, but I may have tried building it earlier this week using gitbash. I will try on on the C drive and keep you updated.
    Pete Gonzalez
    @octogonz
    Also check if there's anything unusual in your C:\Users\<NAME>\.npmrc file
    From your notes above it sounds like a test is failing, so it would be super helpful to see which test is failing, and what the error is
    Darsi Anandarajah
    @darsi-an
    @octogonz longshot worked, thanks for the help!
    Pete Gonzalez
    @octogonz
    Hmmm... I wonder if Rush should check the MAX_PATH length somehow.
    (And are you 100% certain that the path length was the issue? Versus e.g. starting over with a clean clone?)
    Darsi Anandarajah
    @darsi-an
    yes 100%
    Pete Gonzalez
    @octogonz
    Cool, I've opened microsoft/web-build-tools#1479 to see if Rush can warn about this in the future
    Darsi Anandarajah
    @darsi-an
    Okay I will look into this as well