Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
    David Dias
    @thedaviddias
    🤗
    Tony Ross
    @antross
    Live sprint retrospective and planning going on now: https://www.youtube.com/watch?v=5PItENe8dgI
    Tony Ross
    @antross
    Sprint retrospective and planning going on now:
    https://www.youtube.com/watch?v=Raw25JSWH8c
    Tony Ross
    @antross
    Sprint retrospective and planning going on now:
    https://www.youtube.com/watch?v=PsOkQafw7NE
    Antón Molleda
    @molant
    There's a blog post to review 🙄
    Tony Ross
    @antross
    Sprint retrospective and planning: https://www.youtube.com/watch?v=sw5DFRPUvM4
    Rachel Simone Weil
    @hxlnt
    A new blog post to announce the browser extension is online. Feel free to share if you're so inclined! https://medium.com/webhint/announcing-the-webhint-browser-extension-abb22f4cfeb
    Antón Molleda
    @molant
    Nice!
    Are there captions in the images?
    Can the sharing text be changed? Right now is:
    “Announcing the webhint browser extension” by @partytimeHXLNT
    But maybe we should use “... the @webhintio browser extension"?
    Rachel Simone Weil
    @hxlnt
    There's one caption but I'll add captions to the others now.
    @molant What do you mean by "sharing text?"
    Antón Molleda
    @molant
    From the app when you click on the share button
    Don't know about the web
    Rachel Simone Weil
    @hxlnt
    Oh, it just pulls it from the title of the article, yeah?
    I don't think you change it independently
    Jaspreet Singh
    @jaspreet57

    Hi all,
    I am setting up https://github.com/webhintio/hint repo.
    After fork and clone, I did yarn and yarn test
    But many test cases are failing. Is there any local configuration file required to run test cases? or any specific node version?

    I have tried with two node versions:

    node : v10.15.3
    yarn: 1.16.0

    and

    node : v10.16.0
    yarn: 1.17.3
    webhint-initial-test-runs.png
    Failing test cases says something like above
    Tony Ross
    @antross
    Hi @jaspreet57, don’t worry about running the entire test suite
    You can run tests for individual packages from each directory under the “packages” folder in the repo
    That said, the spe
    Jaspreet Singh
    @jaspreet57
    @antross Oh ok. I will try that one. And will first go through some codebase. Thanks.
    Tony Ross
    @antross
    The specific failure you’re seeing looks like we may have accidentally taken a dependency on the OS language being en-US in one of our tests, though. I’d recommend filing a bug for the package where you’re seeing the failure.
    Jaspreet Singh
    @jaspreet57
    Ok most test cases are failing with same reason. Might be single reason for all. I will have a closer look. And will file a bug for same.
    Tony Ross
    @antross
    Also, you may want to still run “yarn build” for the entire repo before testing individual packages (if you haven’t already).
    Jaspreet Singh
    @jaspreet57
    yes I missed that. It seems yarn build is not mentioned in contributor guide. I will check again.
    Tony Ross
    @antross
    Sprint planning and retrospective going on now https://www.youtube.com/watch?v=ypjHauE0QHY
    Tony Ross
    @antross
    Sprint planning and retrospective going on now https://www.youtube.com/watch?v=d9fNw-a7_SY
    Jesus David García Gomez
    @sarvaje
    Hi,
    I have a question about the worker service in the online scanner. Until now, hint runs in a separate process, I don't remember exactly why, but probably it is related with the "docker machine" being reused for multiple scans and also to control the execution time. Now that we are going to move to azure functions and we don't have that scenario anymore, should we remove the new process and just use the node API to run hint? I don't know if the API has any mechanism to timeout or not. Or should we just continue using what we have?
    Tony Ross
    @antross
    Yes, I like migrating to use the Node API directly. I don't think we should need to run this in a separate process anymore. Talking with @molant it sounds like that was originally to work around some problems with jsdom that we're no longer using in the scanner. Also, if the API doesn't have a mechanism to timeout we should consider adding one.
    Jesus David García Gomez
    @sarvaje
    Ok, and now my second question/concern, for the worker, we are going to need hint and @hint/utils as dependencies, but not for the other functions, I suppose we will control this during the build/deployment process, right?
    Tony Ross
    @antross
    Guess I need to take another look at how these end up fitting together in source, but won't we have separate package.json files for these?
    Not to say we couldn't take care of this later in the pipeline, but I think ideally each function can specify different unique dependencies.
    Antón Molleda
    @molant

    @antross I've done a bit of research on sites using less dynamically:
    Desktop

    • total sites: 4352935
    • sites using it: 6372

    Mobile

    • total sites: 5274771
    • sites using it: 7249

    so about 0.1% in both cases

    For those interested the query I used is:
    SELECT count(distinct(page)) FROM `httparchive.response_bodies.2019_08_01_mobile`
    where ends_with(url, "less")
    I checked a few of the sites to confirm they were downloading .less resources
    not sure if we should create a hint for this
    Rachel Simone Weil
    @hxlnt
    I posted some suggested updates for the webhint.io homepage to feature the VS Code and browser extensions. Soliciting feedback from any interested parties. :) webhintio/webhint.io#764
    Antón Molleda
    @molant
    @hxlnt @antross do we want access to GitHub Actions now?
    or are we OK as things are?
    Tony Ross
    @antross
    Sprint planning and retrospective going on now: https://youtu.be/PBSPBvw3Kug
    Rachel Simone Weil
    @hxlnt
    @molant Were you thinking that you wanted to use GitHub Actions for something in our repo? Personally, I'd be interested in seeing if creating a GitHub Action for webhint might be useful for others. https://github.com/actions/toolkit
    Antón Molleda
    @molant
    both, there's someone that would like to add an action to our repo to further compress images automatically
    and if we can create a webhint action even better
    Antón Molleda
    @molant
    @hxlnt @antross we probably want to start cleaning up the repo for hacktoberfest: https://dev.to/devteam/hacktoberfest-starts-in-six-days-3hi2
    and post in dev.to
    Rachel Simone Weil
    @hxlnt
    Collaborative tagfest over lunch, anyone?
    Antón Molleda
    @molant
    sure, I have a meeting 11-12 but can meet after it. My office?
    Tony Ross
    @antross
    Sprint planning and retrospective going on now: https://youtu.be/aggnbC4PIv4
    Brendyn Alexander
    @brendyna
    Saw we released v1 of the extensions--congrats, everyone! Super exciting to see us hit this milestone, and awesome to see the collaboration w/our FF friends bear awesome fruit :)