Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
    Artem Sapegin
    @sapegin
    We have four unmerged PRs.
    Vlad Zhukov
    @vlad-zhukov
    Can someone merge my refactor PR if it's ok? Would like to do some more
    @andywer Thanks!
    Andy Wermke
    @andywer
    Sure thing =)
    Vlad Zhukov
    @vlad-zhukov
    I am going to remove fileTypes entirely, what do you think?
    Andy Wermke
    @andywer
    I wouldn't hurry too much. We have enough breaking changes for now 😅
    Artem Sapegin
    @sapegin
    Highly recommend to check docs: https://github.com/sapegin/textlint-rule-terminology ;-)
    Vlad Zhukov
    @vlad-zhukov
    I need a css block w/o style-loader, should I create a PR with such option for the css block?
    Andy Wermke
    @andywer
    Sure. Just out of curiosity... What's the use case? :)
    Vlad Zhukov
    @vlad-zhukov
    There are few actually, one is obvious when you want to output it into a file
    the other one if you want to load css as a string inside of a bundle
    css-loader has a toString method
    Jan van Brügge
    @jvanbruegge
    the first one can be accomplished by thr extract text plugin
    Vlad Zhukov
    @vlad-zhukov
    I know but I dislike it
    Artem Sapegin
    @sapegin
    Nobody likes it ;-)
    Vlad Zhukov
    @vlad-zhukov
    file-loader + extract-loader work much better
    Artem Sapegin
    @sapegin
    Should we merge this? andywer/webpack-blocks#216
    Artem Sapegin
    @sapegin
    Last thing that still bothers me in 1.0 is that extract text plugin deprecation warning.
    Andy Wermke
    @andywer
    Yeah, the deprecation messages are annoying, but not necessarily a blocker
    Artem Sapegin
    @sapegin
    I’d suggest to get rid of webpack 2 ;-)
    Andy Wermke
    @andywer
    i opened an issue in the extract-text-plugin repo, but something was blocking
    Artem Sapegin
    @sapegin
    From their side?
    Andy Wermke
    @andywer
    here it is: https://github.com/webpack-contrib/extract-text-webpack-plugin/issues/567#issuecomment-322865069
    they said the webpack@2 version is not compatible with webpack@3 and i needed to check back with you, since i haven't tried and am lacking the time to investigate myself
    Artem Sapegin
    @sapegin
    Wrote a comment there. But it may be to late. There’s not much sense to support webpack 2 as much as I can see.
    Andy Wermke
    @andywer
    Yeah, probably
    Thx for your efforts 😊
    Artem Sapegin
    @sapegin
    They’ve answered. And it means we don’t support webpack 3 ;-|
    Andy Wermke
    @andywer
    Yeah, I saw it. Well, then let's rather have two major versions of extract-text, one for webpack v2 and one for v3 and ship the v3-compatible version with the unscoped webpack-blocks package
    Artem Sapegin
    @sapegin
    Sounds good!
    Artem Sapegin
    @sapegin
    How can I help with that?
    Artem Sapegin
    @sapegin
    Here it is: andywer/webpack-blocks#225
    Work in progress, need some feedback ;-)
    Anyone have any feedback for this PR by @vlad-zhukov? Looks good to me.
    andywer/webpack-blocks#224
    Vlad Zhukov
    @vlad-zhukov
    If no one has any objections against this approach I am going to fix tests and update docs tomorrow
    Andy Wermke
    @andywer
    commented on @vlad-zhukov's PR

    @sapegin

    We need to make sure we have a version of extractText block that works in webpack 2.
    Shouldn't it be "that works in webpack 3"?

    (see PR)
    Artem Sapegin
    @sapegin

    Shouldn't it be "that works in webpack 3"?

    I mean the older version that would still work with webpack 2.

    Andy Wermke
    @andywer
    Ahh. Maybe you can edit the PR description a little bit to make that more clear? =)
    Artem Sapegin
    @sapegin
    Done. I also don’t understand why CI is failing.
    Andy Wermke
    @andywer
    Just ran into timeouts...
    Artem Sapegin
    @sapegin
    Any feedback on this PR?
    andywer/webpack-blocks#225
    Andy Wermke
    @andywer
    Left some feedback =)
    Andy Wermke
    @andywer
    are we ready to release v1.0 RC?
    we might need the extract-text update, the other open PRs shouldn't be critical
    Jan van Brügge
    @jvanbruegge
    yeah, extract-text should be merged
    if you run a config with 1.0 it should not print deprecation warnings :)
    Andy Wermke
    @andywer
    true, but under which (non-beta) version number do we publish the current block that works with webpack 2?
    Jan van Brügge
    @jvanbruegge
    I think we can tie it to the webpack version. The sole reason why extract-text might become breaking is a webpack API change (aka webpack major version), isn't it?
    So the major version would always be correct