Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
    Andy Wermke
    @andywer
    Yeah, I saw it. Well, then let's rather have two major versions of extract-text, one for webpack v2 and one for v3 and ship the v3-compatible version with the unscoped webpack-blocks package
    Artem Sapegin
    @sapegin
    Sounds good!
    Artem Sapegin
    @sapegin
    How can I help with that?
    Artem Sapegin
    @sapegin
    Here it is: andywer/webpack-blocks#225
    Work in progress, need some feedback ;-)
    Anyone have any feedback for this PR by @vlad-zhukov? Looks good to me.
    andywer/webpack-blocks#224
    Vlad Zhukov
    @vlad-zhukov
    If no one has any objections against this approach I am going to fix tests and update docs tomorrow
    Andy Wermke
    @andywer
    commented on @vlad-zhukov's PR

    @sapegin

    We need to make sure we have a version of extractText block that works in webpack 2.
    Shouldn't it be "that works in webpack 3"?

    (see PR)
    Artem Sapegin
    @sapegin

    Shouldn't it be "that works in webpack 3"?

    I mean the older version that would still work with webpack 2.

    Andy Wermke
    @andywer
    Ahh. Maybe you can edit the PR description a little bit to make that more clear? =)
    Artem Sapegin
    @sapegin
    Done. I also don’t understand why CI is failing.
    Andy Wermke
    @andywer
    Just ran into timeouts...
    Artem Sapegin
    @sapegin
    Any feedback on this PR?
    andywer/webpack-blocks#225
    Andy Wermke
    @andywer
    Left some feedback =)
    Andy Wermke
    @andywer
    are we ready to release v1.0 RC?
    we might need the extract-text update, the other open PRs shouldn't be critical
    Jan van Brügge
    @jvanbruegge
    yeah, extract-text should be merged
    if you run a config with 1.0 it should not print deprecation warnings :)
    Andy Wermke
    @andywer
    true, but under which (non-beta) version number do we publish the current block that works with webpack 2?
    Jan van Brügge
    @jvanbruegge
    I think we can tie it to the webpack version. The sole reason why extract-text might become breaking is a webpack API change (aka webpack major version), isn't it?
    So the major version would always be correct
    Andy Wermke
    @andywer
    yeah, we could. the only issue is that all other packages are v1.0 now and that would be the only one out of line
    Jan van Brügge
    @jvanbruegge
    ¯_(ツ)_/¯
    I dont really care much about the number
    Vlad Zhukov
    @vlad-zhukov
    What about keeping it at 1.0-beta? :smile:
    Webpack 4 is going out soon and I assume a new version of ETP is going to be released that will be incompatible with the webpack 3
    Jan van Brügge
    @jvanbruegge
    1.0-legacy would also work
    Artem Sapegin
    @sapegin
    I’m fine with weback 2 support only in 1.0-beta.

    we might need the extract-text update

    I’ll finish it as soon as I’m back from React Alicante :sun_with_face:

    Andy Wermke
    @andywer
    You lucky bastard 😄 😉 👍
    I can help with your extract-text PR as well. will have a look
    i'd really love to release the v1.0 RC this weekend
    Artem Sapegin
    @sapegin
    I couldn’t work on that until tomorrow. Flying back today.
    Andy Wermke
    @andywer
    Sure. Im with my family right now and basically offline...
    Andy Wermke
    @andywer
    Please have a look at andywer/webpack-blocks#225. Will release v1.0 RC after merging it unless someone screams "NOT YET" 😉
    Jan van Brügge
    @jvanbruegge
    :+1:
    Andy Wermke
    @andywer
    Everything published. Branch master is now v0.4. Branch release/1.0 is now master 🚀🚀
    Artem Sapegin
    @sapegin
    👍👍👍
    Jan van Brügge
    @jvanbruegge
    one sad and one good news: I had to cancel my Berlin visit due to an important appointment and I migrated my boilerplate for cyclejs (the one that is used the most) to webpack blocks 1.0
    Andy Wermke
    @andywer
    That really is bad and good news, respectively 🙈😉
    Artem Sapegin
    @sapegin
    For some reason webpack tests are failing for me today:
    > @webpack-blocks/webpack@1.0.0-rc test /Users/tema/webpack-blocks/packages/webpack
    > ava && standard
    
    
    [at-loader] Using typescript@2.4.2 from typescript and "tsconfig.json" from /Users/tema/webpack-blocks/packages/webpack/tsconfig.json.
    
    
    [at-loader] Checking started in a separate process...
    
    [at-loader] Checking finished with 2 errors
    [at-loader] ../../../node_modules/@types/node/index.d.ts:48:13
        TS2403: Subsequent variable declarations must have the same type.  Variable 'process' must be of type 'any', but here has type 'Process'.
    
    [at-loader] ../../../node_modules/@types/node/index.d.ts:85:13
        TS2403: Subsequent variable declarations must have the same type.  Variable 'module' must be of type 'any', but here has type 'NodeModule'.
    Also weird, I don’t hat /Users/tema/webpack-blocks/packages/webpack/tsconfig.json.
    Andy Wermke
    @andywer
    That looks pretty weird 😳
    But works on my machine... 😅
    (Also didn't fail on Travis CI today)
    Artem Sapegin
    @sapegin
    Could you try to make a fresh clone?