Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
    Jan van Brügge
    @jvanbruegge
    So the major version would always be correct
    Andy Wermke
    @andywer
    yeah, we could. the only issue is that all other packages are v1.0 now and that would be the only one out of line
    Jan van Brügge
    @jvanbruegge
    ¯_(ツ)_/¯
    I dont really care much about the number
    Vlad Zhukov
    @vlad-zhukov
    What about keeping it at 1.0-beta? :smile:
    Webpack 4 is going out soon and I assume a new version of ETP is going to be released that will be incompatible with the webpack 3
    Jan van Brügge
    @jvanbruegge
    1.0-legacy would also work
    Artem Sapegin
    @sapegin
    I’m fine with weback 2 support only in 1.0-beta.

    we might need the extract-text update

    I’ll finish it as soon as I’m back from React Alicante :sun_with_face:

    Andy Wermke
    @andywer
    You lucky bastard 😄 😉 👍
    I can help with your extract-text PR as well. will have a look
    i'd really love to release the v1.0 RC this weekend
    Artem Sapegin
    @sapegin
    I couldn’t work on that until tomorrow. Flying back today.
    Andy Wermke
    @andywer
    Sure. Im with my family right now and basically offline...
    Andy Wermke
    @andywer
    Please have a look at andywer/webpack-blocks#225. Will release v1.0 RC after merging it unless someone screams "NOT YET" 😉
    Jan van Brügge
    @jvanbruegge
    :+1:
    Andy Wermke
    @andywer
    Everything published. Branch master is now v0.4. Branch release/1.0 is now master 🚀🚀
    Artem Sapegin
    @sapegin
    👍👍👍
    Jan van Brügge
    @jvanbruegge
    one sad and one good news: I had to cancel my Berlin visit due to an important appointment and I migrated my boilerplate for cyclejs (the one that is used the most) to webpack blocks 1.0
    Andy Wermke
    @andywer
    That really is bad and good news, respectively 🙈😉
    Artem Sapegin
    @sapegin
    For some reason webpack tests are failing for me today:
    > @webpack-blocks/webpack@1.0.0-rc test /Users/tema/webpack-blocks/packages/webpack
    > ava && standard
    
    
    [at-loader] Using typescript@2.4.2 from typescript and "tsconfig.json" from /Users/tema/webpack-blocks/packages/webpack/tsconfig.json.
    
    
    [at-loader] Checking started in a separate process...
    
    [at-loader] Checking finished with 2 errors
    [at-loader] ../../../node_modules/@types/node/index.d.ts:48:13
        TS2403: Subsequent variable declarations must have the same type.  Variable 'process' must be of type 'any', but here has type 'Process'.
    
    [at-loader] ../../../node_modules/@types/node/index.d.ts:85:13
        TS2403: Subsequent variable declarations must have the same type.  Variable 'module' must be of type 'any', but here has type 'NodeModule'.
    Also weird, I don’t hat /Users/tema/webpack-blocks/packages/webpack/tsconfig.json.
    Andy Wermke
    @andywer
    That looks pretty weird 😳
    But works on my machine... 😅
    (Also didn't fail on Travis CI today)
    Artem Sapegin
    @sapegin
    Could you try to make a fresh clone?
    Andy Wermke
    @andywer
    Just did. Fresh clone + npm install + npm test. Everything ok
    Artem Sapegin
    @sapegin
    :cry:
    Trying to restart and clean npm cache (though it doesn’t like the idea).
    Andy Wermke
    @andywer
    webpack-blocks/packages/webpack on  master [!] via ⬢ v8.0.0
    ➜ npx ava
    
    [at-loader] Using typescript@2.5.3 from typescript and "tsconfig.json" from /private/tmp/webpack-blocks/packages/webpack/t
    sconfig.json.
    
    
    [at-loader] Checking started in a separate process...
    
    [at-loader] Ok, 0.001 sec.
    
      21 passed
    (when running npm test in the root directory I didn't see the typescript output)
    Artem Sapegin
    @sapegin
    Still cleaning the cache…
    Artem Sapegin
    @sapegin

    added 666 packages in 197.36s

    It was 15 s with cache :scream:

    Nope, same error ;-(
    Artem Sapegin
    @sapegin
    WTF?!
    ~
    ❯ npm ls @types/node
    /Users/tema
    └─┬ enzyme@3.1.0
      └─┬ cheerio@1.0.0-rc.2
        └─┬ parse5@3.0.2
          └── @types/node@6.0.88
    Andy Wermke
    @andywer
    is that the source of your troubles?
    Artem Sapegin
    @sapegin
    Yep, I had node_modules in my home folder since October 4 ;-|
    Andy Wermke
    @andywer
    Artem Sapegin
    @sapegin
    andywer/webpack-blocks#230
    And I’m going to bed — it’s too late already :sleeping:
    Artem Sapegin
    @sapegin

    @jvanbruegge Similar issue was reported at Styleguidist: https://gist.github.com/willhlaw/6134856f30a2bf076b829ebec8ee4fd9

    So something in Uglify plugin or webpack was changes but I don’t understand what.

    Artem Sapegin
    @sapegin
    @jvanbruegge Will you have time to finish this PR soon? andywer/webpack-blocks#231
    Jan van Brügge
    @jvanbruegge
    done
    Artem Sapegin
    @sapegin
    @jvanbruegge Could you please lock the version (remove ^) of uglifyjs-webpack-plugin?
    Jan van Brügge
    @jvanbruegge
    ok
    Artem Sapegin
    @sapegin
    Otherwise they will break it again in the next beta ;-0
    Andy Wermke
    @andywer
    Ohhh 🎉
    At work?