Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
    Artem Sapegin
    @sapegin
    http://wow.sapegin.me/073T1F2C3I0n/Image%202017-10-20%20at%203.47.23%20PM.png
    Andy Wermke
    @andywer
    Ohhh 🎉
    At work?
    Artem Sapegin
    @sapegin
    My last commit before two weeks holiday ;-)
    Yep!
    Vlad Zhukov
    @vlad-zhukov
    About the uglify block:
    it's not nice to have a broken block for so long time, what can I help you with so you can release a new version?
    Jan van Brügge
    @jvanbruegge
    in theory it's working (i updated my boilerplate to force the options), but somehow the tests fail
    and I hadnt had the time to investigate
    Andy Wermke
    @andywer
    you are right, @vlad-zhukov. but fixing the build turns out to be quite tricky.
    i just pushed a change to your feature branch, @jvanbruegge, using uglifyjs-webpack-plugin v1.0.1. if the build still fails on node 6, i will just deactivate the failing test for now...
    Jan van Brügge
    @jvanbruegge
    ok
    Andy Wermke
    @andywer
    Good news: Could fix the build in a second PR that includes the uglifyjs-webpack-plugin options fix, disables one test and moves/renames the test-app to packages/sample-app, so lerna can link the local packages
    https://travis-ci.org/andywer/webpack-blocks/builds/292615756
    Andy Wermke
    @andywer
    Can we live with releasing webpack-blocks v1.1.0, shipping the updated uglifyjs-webpack-plugin with the nasty breaking change?
    Actually it would probably rather be webpack-blocks v1.0.0-rc.2 which is even worse
    Good news: Just checked the dependents (fortunately it's only two of them right now and they cause pretty much all downloads right now) and they shouldn't be affected by the change
    So I guess webpack-blocks v1.0.0-rc.2 it is for shipping the uglify fix
    Vlad Zhukov
    @vlad-zhukov
    Hey, would be nice to have some feedback on andywer/webpack-blocks#236
    Andy Wermke
    @andywer
    Hey Vlad. Thx for the PR! :)
    Good ideas. I'd just like to move updating the dependenicies and refactoring the ugly unit test into separate PRs
    Vlad Zhukov
    @vlad-zhukov
    I've found a reason why CI is failing. Travis runs lerna-bootstrap, it upgrades deps across all packages (e.g. typescript), and it fails to build
    This is basically why yarn exists :smirk:
    It's not possible to fix it right now without publishing a new version of typescript block
    Andy Wermke
    @andywer
    Is it a new TypeScript version that crashes the build?
    Vlad Zhukov
    @vlad-zhukov
    kind of
    I wasn't correct about publishing a new version, it's fixable
    The new typescript requires @types/node that are missing in the packages/webpack block
    I've fixed the typescript bug, now fighting an elm one
    elm-make: elm-stuff/packages/elm-lang/core/5.1.1/elm-package.json: openBinaryFile: does not exist (No such file or directory)
    Vlad Zhukov
    @vlad-zhukov
    Alright, the elm test in packages/webpack is completely broken, where did it come from? 🙃
    elm deps are in the elm-stuff folder and it's missing lots of files, how did it even build before?
    Andy Wermke
    @andywer
    Not sure about the elm stuff
    Don't have any troubles with elm right now. But I just opened a PR to fix the typescript e2e tests, assigning you as a reviewer ;)
    Stephan Schneider
    @zcei
    Hej guys :wave: I finally should have some more spare time - I followed the notifications for the repo in the meantime and awesome what you achieved :clap:
    To get back in the treadmill I started typings in #247
    Vlad Zhukov
    @vlad-zhukov
    Hey there! I am finally back on track! :smile:
    Would be great if you could find some time to review these PRs: #246, #249
    Andy Wermke
    @andywer
    Hey guys. Sorry for answering so late! I looked into the PRs before and left comments, but just recognized that the typescript definitions PR (#247) is not done yet.
    I think we need a little bit of group discussion on terminology, since terms like "webpack block" haven't ever been clearly defined. Should probably discuss this in the PR.
    Stephan Schneider
    @zcei
    BTW I just brought blocks to axios :) axios/axios#1334
    Vlad Zhukov
    @vlad-zhukov
    Nice job! :+1: What do you think about having a 'Users' paragraph in the readme?
    Andy Wermke
    @andywer
    Waaat. Good stuff, Stefan 👍👍
    Will tweet about it
    A „users“ paragraph about who uses webpack-blocks? Do we have widely known users apart from axios? 😉
    Artem Sapegin
    @sapegin
    I used to use it at my previous work but wouldn’t dare to add a link. (I’ve asked at my new job if we can add a logo to Prettier site and they said it’s not allowed ;-/
    Andy Wermke
    @andywer
    Ohh, really; not even prettier? That's a pity!
    Btw, https://twitter.com/andywritescode/status/960609482358304768
    Artem Sapegin
    @sapegin
    I mean our logo at any project’s site. I hope it would change eventually.
    Vlad Zhukov
    @vlad-zhukov
    Hello! What do you guys think if I start working on v2 (create a roadmap, merge PRs and so on)? @andywer I need your opinion as an owner.
    Jan van Brügge
    @jvanbruegge
    I'm for it. I'd live to update create-cycle-app to webpack 4
    Andy Wermke
    @andywer
    Sounds great! We should all do a quick review of the v2 roadmap, once we've got a draft.
    @vlad-zhukov Go ahead if you can find some time for it. I'm more than happy about this kind of contribution :)
    Vlad Zhukov
    @vlad-zhukov
    Cool! I'm going to publish a v2 roadmap draft tomorrow!
    Dmytro Meleshko
    @dmitmel
    Hello!