Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 10:09

    sokra on main

    add pure notations to Object ca… Merge pull request #14492 from … (compare)

  • 10:09

    sokra on feat-add-pure-notation

    (compare)

  • 10:09
    sokra closed #14492
  • 10:08
    webpack-bot labeled #14492
  • 10:08
    webpack-bot unlabeled #14492
  • 09:31
    webpack-bot labeled #14492
  • 08:06
    vankop synchronize #14492
  • 08:06

    vankop on feat-add-pure-notation

    add pure notations to Object ca… (compare)

  • 08:05
    vankop synchronize #14492
  • 08:05

    vankop on feat-add-pure-notation

    add pure notations to Object ca… (compare)

  • 08:01
    vankop synchronize #14492
  • 08:01

    vankop on feat-add-pure-notation

    add pure notations to Object ca… (compare)

  • 07:59
    webpack-bot labeled #14492
  • 07:59
    vankop opened #14492
  • 07:56

    vankop on feat-add-pure-notation

    add pure notations to Object ca… (compare)

  • 06:28
    vankop edited #14357
  • Oct 16 21:42
    vankop edited #14357
  • Oct 16 20:35
    webpack-bot unlabeled #14357
  • Oct 16 20:35
    webpack-bot labeled #14357
  • Oct 16 20:35
    vankop edited #14357
Stephen Weiss
@stephencweiss
😅solved!... i think!
thanks for bringing me back to try other solutions rather than wrestling with eject.
Luke Abby
@DavidArchibald
Yup glad I could, rewired is much simpler to use
Stephen Weiss
@stephencweiss
ended up going with craco, fwiw -- just missed the fact that @craco/craco is also a dependency (i think...the plugin readme is not particularly clear on that point) :)
Luke Abby
@DavidArchibald
lol peer dependencies are annoying
Josh Rouwhorst
@joshrouwhorst
Hey, I'm hoping someone can help me out. I'm setting up a really basic project but I'm running into issues with html-loader where I'm getting a "ReferenceError: __filename is not defined" error in the terminal. Here's my gist: https://gist.github.com/joshrouwhorst/42c4f68f5fce4f8163a411da9d183dcb
The src folder just has an empty app.js file, a template.html file, and an asset folder with one image in it. The template.html file has an image tag referencing that image. When I run webpack the image shows up under dist/assets but I get the error that I put in output.txt. Also the index.html that gets generated shows the error as well.
Luke Abby
@DavidArchibald
try target, it looks like you're running it in a non node environment but it's using the node pseudo-global __filename
That's not guaranteed to change the source generation if the loader is ill behaved
Josh Rouwhorst
@joshrouwhorst
Hi @DavidArchibald, I put target: 'web' as a top level attribute and got the same result.
Luke Abby
@DavidArchibald
what's your node version and are all the dependencies, i.e. plugins/loaders/webpack all up to date?
Josh Rouwhorst
@joshrouwhorst
My node version is v14.15.1 and I just added my package.json to the gist
I just created the project so they should be up to date
Luke Abby
@DavidArchibald
right html-loader in general might be out of date. I see a deprecation warning here:
(node:43091) [DEP_WEBPACK_COMPILATION_ASSETS] DeprecationWarning: Compilation.assets will be frozen in future, all modifications are deprecated.
BREAKING CHANGE: No more changes should happen to Compilation.assets after sealing the Compilation.
        Do changes to assets earlier, e. g. in Compilation.hooks.processAssets.
        Make sure to select an appropriate stage from Compilation.PROCESS_ASSETS_STAGE_*.
(Use `node --trace-deprecation ...` to show where the warning was created)
this suggests we have a module that's not well behaving for Webpack 5
Josh Rouwhorst
@joshrouwhorst
Ahhhh, ok. I figured I was just configuring it wrong.
Luke Abby
@DavidArchibald
I don't know if the deprecation warning is actually coming from html-loader until this is checked
BTW do you want to be importing the HTML as a string? I'm not sure you're aware that's its behaviour
Josh Rouwhorst
@joshrouwhorst
So, what I'm trying to do is to have images referenced in the template brought over to the dist/assets folder. And maybe this isn't the right way to do that.
joshrouwhorst@Josh-Rouwhorsts-MacBook-Pro-7 Test % node --trace-deprecation node_modules/webpack/bin/webpack
(node:43540) [DEP_WEBPACK_COMPILATION_ASSETS] DeprecationWarning: Compilation.assets will be frozen in future, all modifications are deprecated.
BREAKING CHANGE: No more changes should happen to Compilation.assets after sealing the Compilation.
        Do changes to assets earlier, e. g. in Compilation.hooks.processAssets.
        Make sure to select an appropriate stage from Compilation.PROCESS_ASSETS_STAGE_*.
    at /Users/joshrouwhorst/Documents/Projects/_Joshs/Test/node_modules/html-webpack-plugin/index.js:286:49
    at processTicksAndRejections (internal/process/task_queues.js:93:5)
asset assets/Image.png 2.61 MiB [emitted] [from: src/assets/Image.png]
asset main.c74f277f0931dd2347b7.js 1.18 KiB [emitted] [immutable] (name: main)
asset index.html 954 bytes [emitted]
./src/app.js 1 bytes [built] [code generated]

ERROR in   Error: /Users/joshrouwhorst/Documents/Projects/_Joshs/Test/src/template.html:121
  /******/  __webpack_require__.b = require("url").pathToFileURL(__filename);
                                                                 ^
  ReferenceError: __filename is not defined

  - template.html:121 
    /Users/joshrouwhorst/Documents/Projects/_Joshs/Test/src/template.html:121:65

  - template.html:140 
    /Users/joshrouwhorst/Documents/Projects/_Joshs/Test/src/template.html:140:13

  - template.html:150 
    /Users/joshrouwhorst/Documents/Projects/_Joshs/Test/src/template.html:150:12

  - index.js:327 HtmlWebpackPlugin.evaluateCompilationResult
    [Test]/[html-webpack-plugin]/index.js:327:28

  - index.js:243 
    [Test]/[html-webpack-plugin]/index.js:243:22

  - task_queues.js:93 processTicksAndRejections
    internal/process/task_queues.js:93:5

  - async Promise.all

  - async Promise.all
That's with trace-deprecation added
Luke Abby
@DavidArchibald
Yup definitely looks like html-loader is out of date as the deprecation is coming from it as well.
let me find you some alternatives
Josh Rouwhorst
@joshrouwhorst
Thank you!
Josh Rouwhorst
@joshrouwhorst
That looks like it works! Thank you for your help, @DavidArchibald! I appreciate it.
Luke Abby
@DavidArchibald
glad it helped
Gabriel Ayham Semaan
@Gabson1
Hey - could someone help me with some issues I am facing while upgrading webpack from 4 to 5?
Luke Abby
@DavidArchibald
sure what're the problems
Gabriel Ayham Semaan
@Gabson1
To keep my problem short, only certain pages render when I run the app in either dev mode or prod mode. For example, an action like logging in will result in Status Code:
{"statusCode":500,"error":"Internal Server Error","message":"An internal server error occurred"}
Luke Abby
@DavidArchibald
is this using some system that works around Webpack?
like create-react-app etc
Gabriel Ayham Semaan
@Gabson1
Here'S a gist of my webpack: https://gist.github.com/Gabson1/8a94f74e696dc052b2397b7d9771244b
no, it's a custom webpack, build from scratch
its a react - hapi app
I first posted my question on stackoverflow, but barely any help there (as always...). It includes some more issues and detail, may I post the link or not?
Luke Abby
@DavidArchibald
sure
Luke Abby
@DavidArchibald
did the commenter's point about polyfilling help at all?
regarding the buffer issue
Also are you able to traceback the error better? An internal server error could happen for many reasons, if you've updated dependencies besides webpack that could do it or if they worked with some other polyfills that suddenly don't exist etc
Gabriel Ayham Semaan
@Gabson1
I wasn't quite sure how to implement the fallback for buffer... my way did not work unfortunately

Webpack mentions that not the full error message is being displayed,

1 WARNING in child compilations (Use 'stats.children: true' resp. '--stats-children' for more details) 1 warning has detailed information that is not shown. Use 'stats.errorDetails: true' resp. '--stats-error-details' to show it.

however whatever I try, I can't get webpack to spit out some more info

Luke Abby
@DavidArchibald
iirc you have to do this:
module.exports = {
  //...
  stats: {
    children: true,
  },
};
might actually be different
Gabriel Ayham Semaan
@Gabson1
it's exactly what I tried, lemme do it one more time
Webpack still outputs the same message and no more details for my errors
Luke Abby
@DavidArchibald
What's your node version
Gabriel Ayham Semaan
@Gabson1
v14.15.4
npm is 6.14.10 if you want this info as well