irc-discord-bot <09Alex Krunch> That would be more practical than the Glitter one
irc-discord-bot <02Borewit> Yeah I think so
rom1504 however for this specific use case, if you setup a nginx server in that internal network, that would also work
irc-discord-bot <08alxhotel> Yeah @Kaze#2913, I think we need to make bittorrent-tracker be able to scale horizontally. Since it's all in memory, maybe some kind of message passing will be needed
irc-discord-bot <11recox> 1- WMA is supported on webtorrent-desktop? weird because all the other formats works fine, except WMA...
irc-discord-bot <11recox> 2- do we have any integration with last.fm ?
irc-discord-bot <11recox> So in case im interested in implement this on my fork (https://github.com/refreex/refreex-webtorrent-desktop) Im interested in implement it in a way that is useful to WebTorrent and then when is ready on webtorrent i do a git pull upstream master and then i merge it to my fork the same with the playlists that I explain there on my posts. So what are the suggestions to implement those functionalities on
irc-discord-bot webtorrent-desktop?
irc-discord-bot <11recox> the main "problem" or "difference" between webtorrent and my fork is the interface.... (and is not too way different, but still yes)
irc-discord-bot <11recox> so if you can guide me to help you implement the "refreex-playlists" and the "scrobbling" functionality will be awesome
irc-discord-bot <02Borewit> @recox wma audio tracks should be recognized as audio, based on it's extension. wma metadata is supported as well. But wma is native Microsoft technology, I don't think the audio format is supported by Chromium, which may prevent it from playing directly in Electron.
irc-discord-bot <11recox> mmm weird as i though that in webtorrent-desktop is not using the <audio> html tag and is using something custom, as is working with FLACs and those are not supported by chromium by default
irc-discord-bot <02Borewit> https://www.chromium.org/audio-video
irc-discord-bot <11recox> I see yes is using the <audio> tag // Unfortunately, play/pause can't be done just by modifying HTML. // Instead, grab the DOM node and play/pause it if necessary // Get the <video> or <audio> tag const mediaElement = document.querySelector("audio") i found it in the code XD
irc-discord-bot <11recox> so i think there is a bug // Checks whether a fileSummary or file path is playable audio function isAudio (file) { return mediaExtensions.audio.includes(getFileExtension(file)) } torrent-player.js line 24
irc-discord-bot <02Borewit> What about the ability to define an external audio player? Just like VLC.
irc-discord-bot <11recox> yes, im gonna do that i think 🙂
irc-discord-bot <11recox> but the "bug" i think is wma is in the whitelist of extensions playlable by webtorrent
irc-discord-bot <11recox> audio: [ '.aac', '.aif', '.aiff', '.asf', '.dff', '.dsf', '.flac', '.m2a', '.m4a', '.m4b', '.mp2', '.mp3', '.mpc', '.oga', '.ogg', '.opus', '.spx', '.wma', '.wav', '.wv', '.wvp'],
irc-discord-bot <02Borewit> I don't think there is an distiction between audio files, and audio files which are actually playable in the "browser".
irc-discord-bot <02Borewit> Those extensions are used to determine what the main content type of a torrent is.
irc-discord-bot <02Borewit> From there on, it need to find the best way of playing the tracks. Either it be native, AirPlay, external player.
irc-discord-bot <02Borewit> From video files it is neither garenteed it can be played back. For example, DD 5.1 (AC3) audio is not supported .
irc-discord-bot <11recox> I get it, but as I see in the code. we have the function updatePlayer in playback-controller.js that function does this: if (!TorrentPlayer.isPlayable(fileSummary)) { torrentSummary.mostRecentFileIndex = undefined return cb(new UnplayableFileError()) } function isPlayable (file) { return isVideo(file) || isAudio(file) } The only way I see opening files with an external player is if the option
irc-discord-bot this.state.saved.prefs.openExternalPlayer is true but not if the file is unplaylable does that make sense?
irc-discord-bot <02Borewit> No true, that switch is manual. But if you would set FooBar2000 (on Windows) as the external play, would the wma play?
irc-discord-bot <11recox> yes
irc-discord-bot <11recox> what im trying to say is
irc-discord-bot <02Borewit> If we kick out wma from the audio extension, we would break that.
irc-discord-bot <11recox> use chromium as default player, but in case the extension is not playable in chromium open the external program
irc-discord-bot <11recox> is one if more in the updatePlayer function i guess
irc-discord-bot <02Borewit> That would be nice. Let the OS maybe handle the format?
irc-discord-bot <11recox> yup
irc-discord-bot <11recox> i can do a pr of that in you agree with the idea.
irc-discord-bot <02Borewit> Maybe audio elements throws an error, which we can use to trigger alternative play method.
irc-discord-bot <11recox> that sounds cool too 🙂
irc-discord-bot <11recox> let me check what can i do
irc-discord-bot <02Borewit> Great. And there maybe a few more audio formats which are not in the list, which may work playing it external.