Trying to finalize #95 but got stuck in
Geocoder Unit test specs for methods (e.g. querySelections()): quite some async stuff going on: setTimeout(), Promise and fetch() combined (to realize "search while typing"). Trying Sinon fake timers and fake xhr but no success...
Ok:
One tip: to get rid of all the (non-fatal) warnings like ERROR LOG: '[Vue warn]: Unknown custom element: <v-icon> - did you register the component correctly?..., Vuetify needs to be installed globally in the unit tests
Karma, Mocha, Chai, Sinon, vue/test-utils: finding my way a bit...https://vue-test-utils.vuejs.org/ is helpful.One tip: to get rid of all the (non-fatal) warnings like ERROR LOG: '[Vue warn]: Unknown custom element: <v-icon> - did you register the component correctly?..., Vuetify needs to be installed globally in the unit tests
.spec file (like in Weguemain.js): import Vue from 'vue';
import Vuetify from 'vuetify';
Vue.use(Vuetify);
Forget my last/above Tip: vuejs/vue-test-utils#1272 : warnings go away but new problems (e.g. in
find()) popup...
I plan to update the application template since the one Wegue was derived from isn't maintained anymore. Same thing could be achieved with vue-cli3. This would also update our dev-dependencies which are currently a nightmare to update. Maybe updated test-libs will be more straight forward. See #94. I hope I'll find some time in the near future.
I would say go ahead. Got a bit further with testing, other two stumbling blocks are 1) the long time a test-run takes, even when only testing the Geocoder
.spec. and 2) not being able to step-wise debug/having breakpoints in the test code. Looks like both can be solved: 1) by using an additional jsdom engine (next to Chromium) and 2) looks there is mocha --inspect-brk. So chugging along, other issue is how to provide input text to the Geocoder Vuetify Combobox/Select widget to have real BDD tests as recommended.
Stepwise debugging tests appeared easier than thought, will add a
README.md under test/ with tips and tricks, e.g.:
I think the screenshot in the README is from an old or adapted version of Wegue. The current feature info window is defined in InfoClickWin to show a Properties and Coordinates table. Or maybe it is a HelpWin. In that case you can configure a
content props-value as regular HTML. For the InfoClickWin one would need a specialized Vue Template section to render attributeData coming from the clicked Feature. For later: Vue slots could help to allow implementations to have a customized template/styling.
Ok, overlooked, there is a FeatureInfoWindow. It is not configured in an example config. Looks like one needs to configure a
"wgu-feature-info-window": under modules with props: layerId (name of the Layer) and the attribute names of the title and image (imageProp) within Features of that Layer. It should listen to Map events and when a Feature selected display its info (title, image) but not sure if/how that works. This approach looks more loosely coupled than InfoClickWin, so quite versatile, but also unclear to me how to enable...
Did a PoC with
FeatureInfoWindow with success. Code in local branch https://github.com/justb4/wegue/tree/featureinfowindow. Modified 3 files: WguAppTemplate.vue, FeatureInfoWindow.vue and app-conf.json. Could actually use the new OGC API Features (aka WFS3) using pygeoapi demo: https://demo.pygeoapi.io/master/collections/dutch_windmills/. The source is actually a WFS v2 proxied with pygeoapi. But the "Windmills featureset" contains both image links and "more info" attributes so was a good fit. The essence is that FeatureInfoWindow needs to be loaded and configured. Don't know if I followed the right pattern for this though...Result is nice, even the "More Info.." link works.
Yes, the FeatureInfoWindow is one of the first components of the project and currently not very well maintained due to the limited use-cases, which can be handled with that ("just" showing an image and a text). Also a lack of datasets satisfyijng the data model (offering an image, etc.) was the reason it was somehow neglected. Due to the messages in here it seems that it might be good having the FeatureInfoWindow working again. So thanks @justb4 for working this :thumbsup: . Let us know when it is ready to review.
Yes I think there is always a need for a generic "GIS-datatable-like FeatureInfo" like currently Wegue InfoClickWin , we should consider the very versatile Vuetify Datatable with
Vuex there. Plus there is a need for a more "user-friendly/media-rich" InfoWin-type like currently FeatureInfoWindow. For now via #107 I hope to have a PR for FeatureInfoWindow somewhere today.
Agree on the general strategy. Having a GIS-Table component (like InfoClickWin) and a media-rich (like FeatureInfoWindow) and extendable (by slots) Info component would be good.
Regarding a more versatile GIS-Table component: I had a customer project, where I used the Vuetify Datatable. Worked quite well. But no need to use Vuex for that. I would like to keep things simple. Redux (or similar) brings a higher complexity IMHO, which I want to keep at a low level for Wegue.
Maybe we can re-use some of the customer code for the data-table.
Regarding a more versatile GIS-Table component: I had a customer project, where I used the Vuetify Datatable. Worked quite well. But no need to use Vuex for that. I would like to keep things simple. Redux (or similar) brings a higher complexity IMHO, which I want to keep at a low level for Wegue.
Maybe we can re-use some of the customer code for the data-table.
I opened a PR adding WFS layer support (#105). If someone is willing to review, this would be very appreciated.
Agree on the general strategy. Having a GIS-Table component (like InfoClickWin) and a media-rich (like FeatureInfoWindow) and extendable (by slots) Info component would be good.
Regarding a more versatile GIS-Table component: I had a customer project, where I used the Vuetify Datatable. Worked quite well. But no need to use Vuex for that. I would like to keep things simple. Redux (or similar) brings a higher complexity IMHO, which I want to keep at a low level for Wegue.
Maybe we can re-use some of the customer code for the data-table.
Ok, looks good. Vuex is not a must, reminded me of the GeoExt FeatureStore :-), keeping things simple is always good!
waiting for the Wegue Pres live stream: https://streaming.media.ccc.de/fossgis20/rundbau good luck/have fun!
Had network problems then, but viewed last night via https://media.ccc.de/c/fossgis2020. In the end it all worked out, thanks for waiving!
just discovered the online IDE Gitpod. Seems to work with Wegue:
https://gitpod.io/#https://github.com/meggsimum/wegue all
https://gitpod.io/#https://github.com/meggsimum/wegue all
npm commands work and the website can be run. Both fascinating and a bit scary. However I still prefer to stay on my local machine.
Hi Wegue Folks, Hope you are doing well in these times. You may have noticed quite some PRs, mainly originating from Geolicious and more upcoming (i18n!). I know it takes time to review (also I need to respond some) and several WIPs need mainly Unit Tests (sometimes more work than the feature itself). Of all the PRs meggsimum/wegue#125 is IMHO very complete and extremely useful for e.g. Dutch (tilegrids). It is a personal contrib btw.
Hi all,
I hope you're doing well. I just reviewed and merged #124 and #126. Thanks @justb4!
I am quite busy and therefore it was and will be quite quite from my side. I have some half-ready work-in-progess things like loading config from the app-folder and a Vuetify upgrade to v2. But no idea when I can finish them.
#105 (WFS support) seems IMHO ready and would be a nice enhancement.
I am willing to merge this, if no one vetos
Hey there, the first experimental version of QGIS2Wegue is available in the offical QGIS plugin repository: https://plugins.qgis.org/plugins/qgis2wegue/
I am happy about any feedback
Could be interesting if you have time, like the yearly Vue.js conf in A'dam but virtual, link with discount: https://www.eventbrite.co.uk/e/vue-global-online-conference-tickets-105505078530?discount=vuejsglobal#tickets or https://vuejs.amsterdam/
I was also not able to attend. Think the most important talk was this: Keynote Evan You on Vue v3: https://www.youtube.com/watch?v=Vp5ANvd88x0&feature=youtu.be (note they also use StreamYard.com for their conf!).
I just released version 0.10.0 in order to release the work of the last ~14 month(!) and to preserve the state compatible to Vuetify v1: https://github.com/meggsimum/wegue/releases/tag/v0.10.0
By now I will merge #142 so Wegue master is on Vuetify v2 --> necessary due to end of LTS for Vuetify v1 a while ago (see https://twitter.com/vuetifyjs/status/1268234130136989696)
I also added a branch
I also added a branch
vuetify-v1-legacy in order to have a maintenance branch for "old" versions, since not everybody (including me) can upgrade existing apps immediately.
Vuejs Amsterdam takes place Friday 26th January through till Saturday 27th February 2021. 30+ Talks, Hot Topics, Panel Discussions, In-depth Interviews & Updates from Creators of Libraries & Authors. Friday 26th February we begin with Vuejs Amsterdam 24 Hour. Conference the Largest & Most Epic Vue.js Conference in the World