These are chat archives for whereat/contrib

8th
Apr 2016
Meitar M.
@meitar
Apr 08 2016 05:21
I have another newbie contributor question, I hope it's okay to ask this here. Here goes:
So, I'm still working my way through @aguestuser's "React primer for new contributors" and I'm finding myself stumbling in a lot of places. I finally figured out that this has to do with how much ES6 syntax the React docs, tools, and tutorials use. I'm not new to JavaScript, but I am new to ES6 (hell, ES6 itself is kinda new), so I'm finding myself having to separate what is ES6 versus what is React/JSX.
aguestuser
@aguestuser
Apr 08 2016 05:24
Yes! Was thinking the other day we should add something to the primer about that!
Meitar M.
@meitar
Apr 08 2016 05:24
At the top of the primer, there's a link to a Nodeschool workshop and a book about JavaScript, but neither of these resources cover the "ES6 stuff" that all the React docs expect me to know. Hence, the question: does anyone know of a "primer"-like read for ES6 stuff that I can pair with this primer so that I'm not stopping to look up stuff in the MDN JavaScript docs every other freakin' sentence? Thanks. :)
aguestuser
@aguestuser
Apr 08 2016 05:25
Ponyfoo has an excellent series of blog posts on ES6 that are how I found my way into it... (digging up link...)
Meitar M.
@meitar
Apr 08 2016 05:26
Cool, I think I want to get a grip on ES6 before I continue the primer. Something like that would help. :) (This question was inspired by the fact that I just spent fifteen minutes trying to find the definition of arrow functions in the React docs because I kept seeing stuff like () => {} in those blogs.)
aguestuser
@aguestuser
Apr 08 2016 05:27
That's the summary of the series (which functions as a good reference point)
But the link at the top pulls up all the relevant posts in the series
Meitar M.
@meitar
Apr 08 2016 05:27
Yay, thank you!
aguestuser
@aguestuser
Apr 08 2016 05:28
You bet! Sorry I failed to link to that before! Will add to primer tomorrow! (If I forget feel free to add... and point to parts you think are most helpful! -- assuming you find some helpful parts, which I hope you do!!)
Meitar M.
@meitar
Apr 08 2016 05:29
Yeah. I mean, to be fair, I know a lot of people can just do this thing where they accept that something is magic and just roll with it, but I have never enjoyed doing that because IME it always meant I lost lots of time debugging things I got wrong.
So I don't know if every contributor needs to know or care about these details, but I definitely find the distinctions helpful.
aguestuser
@aguestuser
Apr 08 2016 05:35
With you on that! I'm very much of the school of thought that understanding how things you use actually work is both more empowering and in the long run WAY more productive/efficient.
Meitar M.
@meitar
Apr 08 2016 06:32
Yeah, I'm half-way through the ES2015 bullet points and I've already learned things. So that's good. Gonna put this on the primer in the wiki because yeah, this would've helped. Too many React articles use this syntax because they already use Babel for JSX but they never actually mention these aren't the same.
ziggy
@aepyornis
Apr 08 2016 12:45
@meitar I find it super confusing to keep straight what is JSX what is ES6. Not to mention that unless you use babel (which can handle everything) each browser accepts a different number of es6 features and nodejs (without a transpiler) also don't implement all of them.. But anyways, it's probably worth mentioning on the wiki that reading up on es6 before jumping into react is a good idea! I can't remember if this is on the wiki, but I use this guide a lot as a reference: https://github.com/lukehoban/es6features
@meitar p.s. I'm ziggy, nice to digitally meet you!
Bradley Menchl
@brmenchl
Apr 08 2016 20:32
@aepyornis just got to the same stopping point for testID on Android that you did.
This is probably going to call for a PR of some kind on React Native, but for now, I found people saying they are setting the accessibility label on Android (perhaps conditionally based on whether it's a dev build or not). TestID sets something that Appium can access on iOS, but on Android, it just changes the tag name, which Appium deprecated a long time ago. We can still find by accessibility label, so I'm thinking that's what we do for now.. Of course, this is user-facing information, but only if they use a talkback utility and it's not a security risk because all of our code is available publicly anyway.
@aguestuser thoughts
Alexander Martin
@alxmrtn
Apr 08 2016 20:51
could we add a step to remove the accessibility lables for production packaging?
labels*
aguestuser
@aguestuser
Apr 08 2016 22:46
Sorry @/all was at a protest! I like @alxmrtn 's idea of removing for a prod build. I've seen people do that with test ref fields for plain old React apps before. But those builds had webpack do that. Not sure how we'd leave similar instructions in RN-land...
Meitar M.
@meitar
Apr 08 2016 23:18
@aepyornis Thanks for the additional compact ES6 reference. :) Also, hi, I'm maymay, nice to digitally meet you, too.