These are chat archives for whereat/contrib

14th
Apr 2016
ziggy
@aepyornis
Apr 14 2016 19:27
This message was deleted
Git question: if I rebase my fork (with the open pull request) to reflect the changes to the whereat-native master branch, what happens to the pull request?
Meitar M.
@meitar
Apr 14 2016 19:36
@aepyornis The pull request simply shows the current commits in the branch. If you change the commits for any reason, including rebasing, the pull requests's list of commits changes, too (after you push the branch to GitHub of course).
This is very much like force-updating a branch with an open pull request, such as if you're --squashing locally.
ziggy
@aepyornis
Apr 14 2016 19:39
oh awesome.
thank you!
Meitar M.
@meitar
Apr 14 2016 19:41
Yeah. :) For the record, the commits aren't removed from the git history (i.e., they still exist within git's object store), but they're only accessible via commit hash if they're no longer associated with any ref (branch name, tag name, etc).
ziggy
@aepyornis
Apr 14 2016 19:44
oh interesting, I didn't realize that.
Meitar M.
@meitar
Apr 14 2016 19:46
Yeah, I am not totally clear on the machinations of how or when git decides to clean up such commits, because the git-gc man page isn't clear about it. But I learned this the hard way after thinking I'd removed a password from my repository and then OH LOOK THERE IT IS. :(
ziggy
@aepyornis
Apr 14 2016 21:21
git is wild.
ziggy
@aepyornis
Apr 14 2016 21:49
You can find those lost git blobs with this: git fsck --lost-found