Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
Buddhika Chathuranga
@buddhikac96

We can search for both winsw.xml and winsw.yml, and use .xml as a first choice.

Yeah, we talk about this. But I think we did not confirm that. Sorry, I think I have misunderstood that :(

Oleg Nenashev
@oleg-nenashev
I suggest we reintroduce the weekly voice chat to ensure that we are on the same page
Buddhika Chathuranga
@buddhikac96
Would be great!
Anyway how should I continue on that? I can allocate time for this.
Oleg Nenashev
@oleg-nenashev
Just send a doodle. If you have slots before 11 am UTC, it would be great
5 replies
Buddhika Chathuranga
@buddhikac96
Sure. I will. Anyway I mean I can spend time working on that feature right now if we can confirm a workaround?
Oleg Nenashev
@oleg-nenashev
Yes, it would be better to focus on that
Taking our time and the velocity, it is likely that New CLI does not get finished in time. So I suggest to focus on the deliverables critical for the next evaluation
Buddhika Chathuranga
@buddhikac96
Sure. I will.
dave-q
@dave-q
Hi,
Is there a reccomended way for updating the wrapped application that winsw is wrapping? Can we just swap out the file mentioned in the config and it will continue happily? Does it need a restart or an uninstall?
Next Turn
@NextTurn
@dave-q Windows doesn't allow replacing running executable files. See https://github.com/winsw/winsw/issues/184#issuecomment-666890996 for some workarounds.
A service restart is required in order to run the new version of the wrapped application.
Oleg Nenashev
@oleg-nenashev
@dave-q @NextTurn If this is not about runtime update, there is a feature which allows to download new application binaries on the startup. https://github.com/winsw/winsw/blob/master/doc/xmlConfigFile.md#download
1 reply
Oleg Nenashev
@oleg-nenashev
@buddhikac96 could you please push your code from this week into a pull request? Even if this is not ready, it would help to start initial reviews
Buddhika Chathuranga
@buddhikac96
Buddhika Chathuranga
@buddhikac96
https://doodle.com/poll/6tq5dves6t9x426c Doodle for the Monday meeting.
Oleg Nenashev
@oleg-nenashev
Voted
13 replies
Oleg Nenashev
@oleg-nenashev
omw. Will be a few min late, sry
Buddhika Chathuranga
@buddhikac96
no problem
Oleg Nenashev
@oleg-nenashev
joined
Oleg Nenashev
@oleg-nenashev
winsw/winsw#641 is ready to go IMHO. WDYT @NextTurn ?
Buddhika Chathuranga
@buddhikac96
@oleg-nenashev Now YAML and XML support Pull request is merged. So as we discuss, the next most critical thing is extension support. Am I right?
2 replies
Buddhika Chathuranga
@buddhikac96
@oleg-nenashev thanks to yesterday's discussion I finish the extension support. It's functioning now. But there is a lot of changes from the pull request that I have already created. So shall I create a new PR after closing the old one?
2 replies
Buddhika Chathuranga
@buddhikac96
@NextTurn after reading few articles I found that I can clean my pull request by interactive rebase. Am I correct?
Hi @all
Oleg Nenashev
@oleg-nenashev
hi all
Buddhika Chathuranga
@buddhikac96
This week Updates
  • xml and yaml support PR get merged
  • create the PR for extension support
Oleg Nenashev
@oleg-nenashev
there are ,ultiple ways to cleanup the PR. Is it just about wrong commit history? Or are there just multiple commits?
Buddhika Chathuranga
@buddhikac96
Unnecessary commits. Some commits I made in the early is no needed
Oleg Nenashev
@oleg-nenashev
We can always squash-merge commits and so be it.
I am not too concerned about it
@NextTurn FTR in Jenkins we use a label to highlight PRs which need to be squash-merged. Just added a similar one in WinSW for discussion: https://github.com/winsw/winsw/labels/squash-merge-me
I will do some manual testing for winsw/winsw#638 tonight
Buddhika Chathuranga
@buddhikac96
thanks. I will read about that.
would be great
I will try to finish the test coverage for shared directory mapper today night.
So the main deliverables left is
  • finish extension support
  • YAML schema validation
  • config validate on startup
  • yaml support unit test coverage
Am I correct?
Oleg Nenashev
@oleg-nenashev
Yes though I would alter the order a bit
Unit test coverage looks to be a reasonable next step to get it over the line
After extensions
What is your plan for the XSD schema @buddhikac96 ? Is this pull request still relevant
Maybe we could merge/release the XSD without the validation on startup, but it still lacks documentation
Buddhika Chathuranga
@buddhikac96
If it is possible then I will update do the documentation first. Then I will do the validation on startup in a later PR?
Oleg Nenashev
@oleg-nenashev
yup
smaller steps make total sense there
Standalone XSD is already an added value for users
Buddhika Chathuranga
@buddhikac96
great. I will do the documentation immediately.
Oleg Nenashev
@oleg-nenashev
No need to do it immediately