Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
Buddhika Chathuranga
@buddhikac96
Buddhika Chathuranga
@buddhikac96
https://doodle.com/poll/6tq5dves6t9x426c Doodle for the Monday meeting.
Oleg Nenashev
@oleg-nenashev
Voted
13 replies
Oleg Nenashev
@oleg-nenashev
omw. Will be a few min late, sry
Buddhika Chathuranga
@buddhikac96
no problem
Oleg Nenashev
@oleg-nenashev
joined
Oleg Nenashev
@oleg-nenashev
winsw/winsw#641 is ready to go IMHO. WDYT @NextTurn ?
Buddhika Chathuranga
@buddhikac96
@oleg-nenashev Now YAML and XML support Pull request is merged. So as we discuss, the next most critical thing is extension support. Am I right?
2 replies
Buddhika Chathuranga
@buddhikac96
@oleg-nenashev thanks to yesterday's discussion I finish the extension support. It's functioning now. But there is a lot of changes from the pull request that I have already created. So shall I create a new PR after closing the old one?
2 replies
Buddhika Chathuranga
@buddhikac96
@NextTurn after reading few articles I found that I can clean my pull request by interactive rebase. Am I correct?
Hi @all
Oleg Nenashev
@oleg-nenashev
hi all
Buddhika Chathuranga
@buddhikac96
This week Updates
  • xml and yaml support PR get merged
  • create the PR for extension support
Oleg Nenashev
@oleg-nenashev
there are ,ultiple ways to cleanup the PR. Is it just about wrong commit history? Or are there just multiple commits?
Buddhika Chathuranga
@buddhikac96
Unnecessary commits. Some commits I made in the early is no needed
Oleg Nenashev
@oleg-nenashev
We can always squash-merge commits and so be it.
I am not too concerned about it
@NextTurn FTR in Jenkins we use a label to highlight PRs which need to be squash-merged. Just added a similar one in WinSW for discussion: https://github.com/winsw/winsw/labels/squash-merge-me
I will do some manual testing for winsw/winsw#638 tonight
Buddhika Chathuranga
@buddhikac96
thanks. I will read about that.
would be great
I will try to finish the test coverage for shared directory mapper today night.
So the main deliverables left is
  • finish extension support
  • YAML schema validation
  • config validate on startup
  • yaml support unit test coverage
Am I correct?
Oleg Nenashev
@oleg-nenashev
Yes though I would alter the order a bit
Unit test coverage looks to be a reasonable next step to get it over the line
After extensions
What is your plan for the XSD schema @buddhikac96 ? Is this pull request still relevant
Maybe we could merge/release the XSD without the validation on startup, but it still lacks documentation
Buddhika Chathuranga
@buddhikac96
If it is possible then I will update do the documentation first. Then I will do the validation on startup in a later PR?
Oleg Nenashev
@oleg-nenashev
yup
smaller steps make total sense there
Standalone XSD is already an added value for users
Buddhika Chathuranga
@buddhikac96
great. I will do the documentation immediately.
Oleg Nenashev
@oleg-nenashev
No need to do it immediately
While you are not blocked on extensions, I would suggest to focus on that and avoid ontext switching
Buddhika Chathuranga
@buddhikac96
great. I will manage that.. BTW thanks 100+ for yesterday meeting. That helps a lot to understand the extension support.
I am used to do what I was given to do. when it comes to planning I am not that smart. thank you so so much for the guidance
Oleg Nenashev
@oleg-nenashev
Well, all of us have something to learn from GSoC :D
If you were my colleague at my current company this week, you could have discovered that I am also not that smart at planning :(
Buddhika Chathuranga
@buddhikac96
:) can't agree more. GSoC is the best thing I got to learn. I think every university should add a course module of Open source contributing.
Oleg Nenashev
@oleg-nenashev
:+1:
Next Turn
@NextTurn
It's not a matter of whether to squash the PR or not. #638 contained 12 (now 17) commits, only 5 of which are relevant. The irrelevant commits were squashed commits and merge commits on the feature branch. These should only appear on the main branch.
git rebase master feature simply resolves this. Time to learn something new.
Buddhika Chathuranga
@buddhikac96
thanks.. I will check this :)
Buddhika Chathuranga
@buddhikac96
@NextTurn I did this and resolve conflicts. Now there are commits. Should I squash them before push?
7 replies
Buddhika Chathuranga
@buddhikac96
@oleg-nenashev What sort of documentation should be added in XSD validation ?
Oleg Nenashev
@oleg-nenashev
@buddhikac96
Buddhika Chathuranga
@buddhikac96
thanks. I'll check this. btw I updated the extension support PR. reviewing would be helpful. after finishing that I can move into test coverage.
Oleg Nenashev
@oleg-nenashev
will try to do it tonight