Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Aug 30 21:14

    kocsismate on master

    Add missing code coverage driver (compare)

  • Aug 30 21:04

    kocsismate on master

    Do not test on PHP 8.0 Because… (compare)

  • Aug 30 16:10

    kocsismate on master

    Fix binary (compare)

  • Aug 30 16:09

    kocsismate on master

    Fix variable name (compare)

  • Aug 30 16:08

    kocsismate on master

    Update GitHub Actions config (compare)

  • Aug 30 14:12

    kocsismate on master

    Add qa make command (compare)

  • Jul 21 22:00

    kocsismate on master

    Increase PHPStan level (compare)

  • Jun 23 17:19

    kocsismate on master

    Fix another license file link (compare)

  • Jun 23 08:28

    kocsismate on 2.3.1

    (compare)

  • Jun 23 08:24

    kocsismate on master

    Fix link to license file Add support for PHP 8 Update PHPStan config and 3 more (compare)

  • Apr 26 10:41

    kocsismate on master

    Do not install Xdebug unnecessa… (compare)

  • Apr 24 09:24
    kocsismate closed #28
  • Apr 24 09:24
    kocsismate commented #28
  • Apr 24 09:24
    kocsismate commented #28
  • Apr 24 09:16

    kocsismate on 2.3.0

    (compare)

  • Apr 24 09:16

    kocsismate on master

    Update Docker image to PHP 7.3 (compare)

  • Apr 24 09:08

    kocsismate on master

    Update dependencies (compare)

  • Apr 24 07:57

    kocsismate on master

    Do not install PHP 7.4 separate… (compare)

  • Apr 23 08:51
    kocsismate commented #28
  • Apr 22 07:21
    holtkamp commented #28
Samuel Ryan
@citricsquid
Hi!
Christian Weiske
@cweiske
Hi. Why are all the non-public methods in ClassHydrator private instead of protected?
I wanted to extend the hydrator to instantiate objects of the correct classes instead of "stdClass", but the "private" on most of the methods make that harder than it could be
Máté Kocsis
@kocsismate
Hey @cweiske! I made them private because I didn't think that someone want to override the methods. To be honest, it's also easier for me because I don't have to deal with the case when someone extends this class, so I am free to make my changes. Wouldn't it make sense for you to copy the ClassHydrator's code to a new class and customize it? I believe it would be a more stable way to deal with the situation because my changes in the implementation of the ClassHydrator won't affect you in any way.