These are chat archives for wooorm/remark

12th
Apr 2016
Khoa Nguyen
@thangngoc89
Apr 12 2016 01:48
:+1: @denysdovhan
Titus
@wooorm
Apr 12 2016 13:29
Whoops, missed this!
@thangngoc89 That’s weird, and shouldn’t happen. Could you show me how you use remark/remark-lint?
@denysdovhan Wow! Very awesome!
Khoa Nguyen
@thangngoc89
Apr 12 2016 13:32
@wooorm markdow files contains in content folder
I use this command this start remark lint:
remark --quiet --frail content
  "remarkConfig": {
    "plugins": {
      "lint": {
        "maximum-heading-length": false,
        "maximum-line-length": false,
        "no-html": false,
        "no-heading-punctuation": false,
        "no-multiple-toplevel-headings": false,
        "no-shortcut-reference-link": false,
        "no-undefined-references": false,
        "list-item-indent": "space",
        "list-item-spacing": false,
        "no-emphasis-as-heading": false
      }
    }
  },
see full package.json here
And it lint my images (jpg, png)
I have to create a .remarkignore file like this to ignore images :
content/images
content/**/**.png
content/**/**.jpg
content/**/**.gif
Titus
@wooorm
Apr 12 2016 13:36
:(
I’ll dig in
Khoa Nguyen
@thangngoc89
Apr 12 2016 13:36
:+1: thanks
Titus
@wooorm
Apr 12 2016 13:57
You’re right, this previously worked though, weird.
Khoa Nguyen
@thangngoc89
Apr 12 2016 14:01
:/
Titus
@wooorm
Apr 12 2016 14:45
Fixed, will release soon. I tested it on your repo and it works
Khoa Nguyen
@thangngoc89
Apr 12 2016 14:45
@wooorm nice !!!
thanks a lot
Titus
@wooorm
Apr 12 2016 14:45
When the next version is released, you can remove your .remarkignore file
Khoa Nguyen
@thangngoc89
Apr 12 2016 14:46
defintely ;)
what kind of glob pattern are you using for .remarkignore ?
content/**/**.{png|jpg|gif} doesn't work ;)
content/**/**.(png|jpg|gif) too
Weird that it didn’t work
Khoa Nguyen
@thangngoc89
Apr 12 2016 14:49
it's weird
I familiar with minimatch
I usually use globby which uses glob which uses minimatch under the hood :D
:/ npm
Titus
@wooorm
Apr 12 2016 14:51
I think remark uses both glob and minimatch
Oh: should you go for content/**/**.{png|jpg|gif} > content/**/**.{png,jpg,gif}
As in, the latter, not the first?
Khoa Nguyen
@thangngoc89
Apr 12 2016 14:51
aha
But I don't think I need to change it anymore :)
Titus
@wooorm
Apr 12 2016 14:52
Indeed ;)
Khoa Nguyen
@thangngoc89
Apr 12 2016 14:52
just wait for a new release and remove the file ;)
Titus
@wooorm
Apr 12 2016 15:14
Released!
Khoa Nguyen
@thangngoc89
Apr 12 2016 15:58
@wooorm :+1: that's fast and awesome