WP Emerge/Lobby

Calvin Alkan

@calvinalkan

Just confirmed this also happens on a fresh install of wpemerge.

Given the following view:

<?php


?>

<h2> Foobar</h2>

<?php

    non_existing_function();

?>

and the following route:

 \App\App::route()->get()->url('foo')->handle(function () {

        return \App\App::view('view.php');

    });

The output is the following with the default WP error page:

"Foobar

Fatal error: Uncaught Error: Call to undefined function non_existing_function() in /Users/calvinalkan/valet/booking/wp-content/plugins/test-plugin/view.php:10 Stack trace: #0 /Users/calvinalkan/valet/booking/wp-content/plugins/snicco-bookings-"

It also makes sense why this happens:

Inside the PhpView:

public function toString() {

        if ( empty( $this->getName() ) ) {
            throw new ViewException( 'View must have a name.' );
        }

        if ( empty( $this->getFilepath() ) ) {
            throw new ViewException( 'View must have a filepath.' );
        }

        $this->engine->pushLayoutContent( $this );

        if ( $this->getLayout() !== null ) {
 // ERROR HAPPENS HERE
            return $this->getLayout()->toString();
        }

        return $this->engine->getLayoutContent();
    }

The output buffering will be cleaned automatically when the script shuts down. The exception in the view causes this. But ofc we dont want to render a half baked view to the user which is why any exceptions need to be caught here and the output buffer needs to be flushed

Atanas Angelov

@atanas-dev

Could you please post an issue on GitHub for this so I can keep track of it? Thanks!

Calvin Alkan

@calvinalkan

done htmlburger/wpemerge#27

Also how do we ensure that the rendered view is not bigger than the max outbut buffer size? This would break the entire routing flow I assume. Is this something very unlikely to happen?

Alexander

@xenx-efy

Hi there, when I'm using \MyApp::core()->assets()->getBundleUrl('frontend', '.css') I'm getting this url http://localhost:80/styles/frontend.css, but it not works. When I using getAssetUrl all works, for what getBundleUrl() function?

Alexander

@xenx-efy

I set 'SCRIPT_DEBUG' to false and all works, thank you). I found the solution above in chat.

gixan

@gixan

Hey. I am trying to get started with WP Emerge. I've been following 0 to 100 Setup.

However it states I am supposed to get the error:

Fatal error: Uncaught Error: Class '\App\Controllers\Web\HomeController' not found

But instead I receive:

There has been a critical error on this website.

I assumed it was just because maybe the newer version has a different error but as I kept following the steps where it is supposed to resolve the error, it did not. Everything was fine until I reached that stage and double checked that I pasted in the code correctly in the .php and .json files.

Does anyone have any pointers on what could be happening or links to any resources? I can't find any resources online on WP Emerge besides this site itself.

gixan

@gixan

The issue seems to have resolved it self I think?
I executed compser dump-autoloader a few times and it did nothing, then sat around googling and typing this up. When I returned to it, I turned off my MAMP server and turned it on again. Not sure what resolved it.

Calvin Alkan

@calvinalkan

@atanas-dev submitted another possible bug htmlburger/wpemerge#28

Branislav Stojanovic

@djex808

@atanas-dev Is it likely that PHP 8 will be supported in the next 3-4 months? I need to decide if I am going to use the framework for the next project and I would really like to but PHP 8 would be required:)

Atanas Angelov

@atanas-dev

There are plans but I cannot give you an exact ETA :)

Atanas Angelov

@atanas-dev

Just as an FYI, PHP 8 support is in master but there are some other unrelated complications that need to be resolved before a new release happens. I might make a separate branch/hotfix depending on how long it takes.

Branislav Stojanovic

@djex808

If you could at least find some time in the the next few months to make a hotfix for the routes issue that I experienced that would be great :). Though, in the end, I can work around it then rewrite the code later when it becomes available.

Atanas Angelov

@atanas-dev

What specific routes issue are you referring to?

Atanas Angelov

@atanas-dev

Ah, you're referring to the PHP 8 one.

Branislav Stojanovic

@djex808

Yes, yes - sorry for the confusion :)

Jennifer Eberlei

@jennifer.eberlei_gitlab

Hey There, I just did my first release and uploaded it to my staging server. Unfortunately I can't activate it as I get the following error:

Warning: Use of undefined constant WPEMERGE_APPLICATION_FILESYSTEM_KEY - assumed 'WPEMERGE_APPLICATION_FILESYSTEM_KEY' (this will throw an Error in a future version of PHP) in /var/www/vhosts/rechtsanwalt.com/dev.rechtsanwalt.com/wp-content/plugins/racom-directory/app/src/WordPress/AssetsServiceProvider.php on line 29

Fatal error: Uncaught Pimple\Exception\UnknownIdentifierException: Identifier "WPEMERGE_APPLICATION_FILESYSTEM_KEY" is not defined. in /wp-content/plugins/racom-directory/vendor/pimple/pimple/src/Pimple/Container.php:101 Stack trace: #0 /wp-content/plugins/racom-directory/app/src/WordPress/AssetsServiceProvider.php(29): Pimple\Container->offsetGet() #1 //wp-content/plugins/racom-directory/vendor/htmlburger/wpemerge/src/Application/LoadsServiceProvidersTrait.php(107): RacomDirectory\WordPress\AssetsServiceProvider->bootstrap() #2 /var/www/vhosts/rechtsanwalt.com/dev.rechtsanwalt.com/wp-content/plugins/racom-directory/vendor/htmlburger/wpemerge/src/Application/LoadsServiceProvidersTrait.php(82): WPEmerge\Application\Application->bootstrapServiceProviders() #3 /var/www/vhosts/rechtsanwalt.com/dev.rechtsanwalt.com/wp-content/plugins/racom-directory/vendor/htmlburger/wpem in /var/www/vhosts/rechtsanwalt.com/dev.rechtsanwalt.com/wp-content/plugins/racom-directory/vendor/pimple/pimple/src/Pimple/Container.php on line 101

When I look for taht definition it is located in AssetsServiceProviderPHP Line 29

        $this->filesystem = $container[ WPEMERGE_APPLICATION_FILESYSTEM_KEY ];

Do I have to set that somewhere?

Jennifer Eberlei

@jennifer.eberlei_gitlab

I already fixed the warning by adding quotes to the constant but I still get the Fatal Error.

Atanas Angelov

@atanas-dev

Hi @jennifer.eberlei_gitlab ,

You shouldn't need to edit any files inside /vendor/ for everything to work. My first guess would be is that you need to run composer install --no-dev to install the production dependencies on your server.

Alternatively, you can use the yarn release command: https://docs.wpemerge.com/#/starter/scripts?id=yarn-release
This will build all assets, install production dependencies and zip up your theme which you can then upload to your server and unzip.

Jennifer Eberlei

@jennifer.eberlei_gitlab

Thank you for your answer, I did the yarn release command beforehand and uploaded the created zip file

that's when the error occured

Atanas Angelov

@atanas-dev

The only reason that the constants are not defined is that the WP Emerge framework is not loaded so you'll need to make sure the /vendor/ dependencies are present and the correct path to the autoloader is loaded in functions.php

Arthos

@taliesinpenbardd

hey all. i have a minor problem: chrome requests a HTTPS connection to the sites, even local ones with a .test tld, but the files during yarn hot are served with an HTTP protocol, and are blocked, stopping the HMR to work properly. I've tried to valet secure the local domain, to indicate the HTTPS url in config.json, but without any luck until now. any idea on what i should modify to make it work? thanks

Alexander

@xenx-efy

Hi, appeared problem with webpack, it is shuffle order media queries which we're using for adaptive design, and bundler not save mixins order in source file. And maybe it is not a problem?

Atanas Angelov

@atanas-dev

Hi @xenx-efy ,
You can disable media query concatenation by editing resources/build/postcss.js and removing require('./lib/combine-media-queries'), from the array of plugins
This plugin will be disabled by default in future versions as this is an issue that has been reported quite a bit

Alexander

@xenx-efy

@atanas-dev, thank you very much) But it little problem that many developers, in particular backend, don't know how to configure webpack. If this problem would not be solved I start to use laravel-mix) Or just need to learn webpack?)

codemonkeynorth

@codemonkeynorth

should this work: <img src="{{ \App::core()->assets()->getAssetUrl("images/foo.png") }}" /> to load images/foo.png from resources?

i actually have an asset() function for it but ignore that for now

i just get "unknown"

codemonkeynorth

@codemonkeynorth

ah i still need to do a dummy import as per htmlburger/wpemerge-theme#61

codemonkeynorth

@codemonkeynorth

@atanas-dev shouldn't filehashfilter contain the path? module.exports.filehashFilter = file =>[path][name].${module.exports.filehash(file).substr(0, 10)}.[ext];

doesnt work tho

i cant get images in subfolders to output correctly

my assets/index.js build script runs import '@images/photos/photo1.jpg'; (see github link above).. this should import and output the image to dist but it's not keeping the subfolder i have to reference it as <img src="{{ asset('images/photo1.jpg') }}" /><

codemonkeynorth

@codemonkeynorth

the webpack file function needs to get the relative path.. eg

const relativePath = path.relative('resources', path.dirname(file));
  //return `${relativePath}/[name].${module.exports.filehash(file).substr(0, 10)}.[ext]`;

and then not set an output path

codemonkeynorth

@codemonkeynorth

something like this:

name(file) {
   const relativePath = path.relative('resources/images', path.dirname(file));
   return `${relativePath}/${utils.filehashFilter(file)}`;
 },
 outputPath: 'images',

or you could remove the "/images" part from resources relative and have no output path

Atanas Angelov

@atanas-dev

Image relative path will be preserved in the next version: htmlburger/wpemerge-theme@90b0910 + htmlburger/wpemerge-theme@eef47b1

codemonkeynorth

@codemonkeynorth

ok thanks

codemonkeynorth

@codemonkeynorth

can i apply these changes manually to the current build or do they rely on anything else?

codemonkeynorth

@codemonkeynorth

ok seems to work thanks

Calvin Alkan

@calvinalkan

@atanas-dev any updates on htmlburger/wpemerge#27 and htmlburger/wpemerge#28 ?

gus-at-2122

@gus-at-2122

Greetings and thanks in advance.

How can I create a middleware that detects a subdomain and passes it as $ _GET type argument?

For example: london.mysite.com => mysite.com/q=london

codemonkeynorth

@codemonkeynorth

@atanas-dev new wpemerge site ... I didn’t use much of the backend features on this actually other than blade, but having the whole webpack/tailwind/asset pipeline setup in the starter theme is great for getting started quickly https://www.meatisdead.co.uk/

Much gratitude to you!

Where communities thrive

People

Repo info

Activity