Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    Jan Christopher Vogt
    @cvogt
    Right, that should fix it. I believe we can solve it in a slightly clearer way. What do you think about this?
    def show( keys: List[K], m: Map[K, V] ) = keys.map( k => DiffShow.show( k ) -> DiffShow.show( m( k ) ) )
    and then
                show( removed, left ).map( ( arrow _ ).tupled ).map( red ),
                show( added, right ).map( ( arrow _ ).tupled ).map( green )
    Matthew Pocock
    @drdozer
    yes, that's nicer
    #24
    I'll just test it in my codebase to be sure
    Jan Christopher Vogt
    @cvogt
    thx!
    let me know if it worked :)
    Matthew Pocock
    @drdozer
    yes, it worked perfectly
    Jan Christopher Vogt
    @cvogt
    great.
    xdotai/diff#25
    Matthew Pocock
    @drdozer
    I'll just double-check ...
    yeah, it definitely works
    Jan Christopher Vogt
    @cvogt
    cool. thx for the report :)
    Matthew Pocock
    @drdozer
    tested it on a few hundred maps of various shapes and sizes ;)
    Jan Christopher Vogt
    @cvogt
    hehe, cool
    Matthew Pocock
    @drdozer
    do you have scalajs builds of diff?
    Jan Christopher Vogt
    @cvogt
    Not right now. Please submit a ticket.
    Matthew Pocock
    @drdozer
    #26
    Jan Christopher Vogt
    @cvogt
    thx!
    Matthew Pocock
    @drdozer
    it's not a blocking issue for me -- it just means I'm not currently running tests for my js build
    Jan Christopher Vogt
    @cvogt
    Is the browser app that you’d want to show diffs open source?
    I am curious
    @drdozer
    Matthew Pocock
    @drdozer
    this is what I'm working on right now
    it's a little domain-specific language
    at some point in the on-line editor/debug tool I'd like to display interactive diffs of what the evaluation pipeline has done
    Jan Christopher Vogt
    @cvogt
    Interesting? Who are users/intended audience?
    Matthew Pocock
    @drdozer
    an extremely small number of code-savy synthetic biologistss
    Jan Christopher Vogt
    @cvogt
    Hehe. Bi
    *nice :)!
    Erik LaBianca
    @easel
    any thoughts of doing a 2.12 release for ai.x % diff?
    Jan Christopher Vogt
    @cvogt
    I can look into it. Is there a ticket already? Maybe create or bump one
    Erik LaBianca
    @easel
    Looks like xdotai/diff#22
    somebody’s published a fork it looks like
    would be nice to avoid fiddling with somebody elses repo though =p
    scala.js build would be nice too, that’s xdotai/diff#26
    Yuriy Badalyantc
    @LMnet
    @cvogt Is there any plans to publish new release? Some fixes are in the master, but there is no release version with them.
    Jan Christopher Vogt
    @cvogt
    @LMnet Don’t have time right now to work on this. Happy to give this up for adoption or get back to it later. Maybe publish a fork for now?
    Miguel Iglesias
    @caente
    hello! is there any active collaborator here that has objections on migrating this project to sbt?
    Jan Christopher Vogt
    @cvogt
    Go for it! You guys are using it a lot more than I am, so whatever works best for you!
    @caente
    Jack Low
    @wjlow
    I'm so glad I found this library! The README says Lists are treated as Sets, i.e. ignoring order.
    scala> val diff = DiffShow.diff[List[String]](List("a", "b", "c"), List("c", "b", "a"))
    diff: ai.x.diff.Comparison =
    Different($colon$colon(
      head = "a" -> "c",
      tl$access$1 = $colon$colon( ..., tl$access$1 = $colon$colon( ..., head = "c" -> "a" ) )
    ))
    How come I get Different when comparing List("a", "b", "c") and List("c", "b", "a")?
    They should be equal using Set equality right?
    scala> Set("a", "b", "c") == Set("c", "b", "a")
    res4: Boolean = true
    Oh damn it's because I missed the import ai.x.diff.conversions._ import!
    Looks like that import brings in a seqAsSet implicit
    Guillaume Massé
    @MasseGuillaume
    @cvogt Hey oh, I don't know if this project is dead, but I got a bunch of ideas for improvements. Should I fork the project and take care of the maintenance?