xvik/dropwizard-guicey

Dropwizard guice integration

Eddie Xie

@oeddyo

let me try it out. was missing the "each" part

ah!

oh my god can't believe this is real

yes your solution works!

Vyacheslav Rusakov

@xvik

))

Eddie Xie

@oeddyo

amazing! Not going to be ass kissing but this guicey project is the most amazing one-man OS project I've seen lol

Vyacheslav Rusakov

@xvik

thank you))

Eddie Xie

@oeddyo

Hi @xvik ! I'm using a guava cache in my filter: ``` @Inject
private SessionFactory sessionFactory;

@Inject
public CredentialRequiredFilter(AppDao appDao, Cache<String, App> appCache) {
this.appDao = appDao;
this.appCache = appCache;
}
```

sorry gitter code format is always a mystery to me

now I'm trying to replace the cache with a mock cache in test. I saw in GuiceyHook it's possible but I'm using junit-5. Is there anything I can do now or shall I wait for your changes?

Vyacheslav Rusakov

@xvik

hi!

hooks is a generic mechanism:

GuiceyConfigurationHook hook  = builder -> builder.extensions(...);

here lambda used instead of direct inteface implementation

to register hook: hook.register()

there only problem is to register it before application startap

your junit extension use BeforeAll hook, so it is impossible to register anything beofre extension execution

so you will have to add hooks support inside your extension (to register them before startup)

Eddie Xie

@oeddyo

i see. I'll try out and see if I can get it work

Vyacheslav Rusakov

@xvik

and about formatting: just start ''' on new line. To activate syntax highlighting put language name after it like '''java

Eddie Xie

@oeddyo

ah ok
thanks

Vyacheslav Rusakov

@xvik

http://xvik.github.io/dropwizard-guicey/5.0.1/guide/hooks/

hooks doc

Eddie Xie

@oeddyo

neat!

Eddie Xie

@oeddyo

I seem to get it working in the extension via:

i pass the overrideModule in the extension's constructor, and in the overrideModule I override the cache I wanted to mock. from the guice print it seems to be overridden

does this sound reasonable?

Vyacheslav Rusakov

@xvik

yes ofc, report confirms that

Eddie Xie

@oeddyo

it works!

Fazeem Mohammed

@fazeem84

@xvik i had a suggestion to dropwizard core project to add the application build version during startup,which is rejected unfortunately..i want to know your opinion about this feature dropwizard/dropwizard#3331

Vyacheslav Rusakov

@xvik

I agree that it is too specific addition (and could be easily done in the application if required).

Fazeem Mohammed

@fazeem84

Ok.. thanks for your opinion :)

Eddie Xie

@oeddyo

Hi @xvik I'm seeing my customized Exceptionmapper registered but it's not called when exception happens. The exception is thrown in one of the filter I created

Dynamic features
        CredentialRequiredFeature    (c.k.restful.filter)       
        LoginRequiredFeature         (c.k.restful.filter)       

    Exception mappers
        IndexNotFoundException         IndexNotFoundExceptionMapper (c.k.r.exceptionmapper)

ERROR [2020-06-16 18:22:29,915] io.dropwizard.jersey.errors.LoggingExceptionMapper: Error handling a request: c6536299f686a565
! org.apache.lucene.index.IndexNotFoundException: index 7617868c-fb63-41b5-81e6-50290cdc903exx does not exist
! at com.kalasearch.restful.filter.CredentialRequiredFilter.filter(CredentialRequiredFilter.java:61)
! at org.glassfish.jersey.server.ContainerFilteringStage.apply(ContainerFilteringStage.java:108)

maybe I'm not registering it correctly?

    bootstrap.addBundle(GuiceBundle.builder()
        .extensions(IndexNotFoundExceptionMapper.class)
        .extensions(
            AccountResource.class,
            AppResource.class,
            IndexResource.class,
            DocResource.class,
            CredentialRequiredFeature.class,
            LoginRequiredFeature.class
        )

Eddie Xie

@oeddyo

ah I found it probably has something to do with the exception is thrown in the ContainerRequestFilter

if it's thrown elsewhere, the ExceptionMapper can actually catch it

Vyacheslav Rusakov

@xvik

hi @oeddyo ! Actually LoggingExceptionMapper (shown in error log) is the default dropwizard mapper, so mappers mechanism was used. It is better to debug exception handling to see why it choose default handler instead of your custom mapper. org.glassfish.jersey.internal.ExceptionMapperFactory#find(java.lang.Class<T>, T) - mapper selection logic

Eddie Xie

@oeddyo

@xvik looks like in the function you mentioned, it's trying to search for which is the most "suitable" exceptionMapper by looking at distance

Eddie Xie

@oeddyo

it's interesting... i didn't do anything new but now it seems be able to recognize the exp mapper :|

Eddie Xie

@oeddyo

hmm... it happened again. I'm throwing an exception in resource now, but for some reason the mapperFactory you mentioned keep finding the default mapper so my IndexNotFoundExceptionMapper is not used

Eddie Xie

@oeddyo

The code in resource is very simple. I'm testing if an indexId exists, if not throw this exception:

  public Index getIndex(@PathParam("indexId") String indexId) {
    Optional<Index> indexOpt = indexDao.findById(indexId);
    if (indexOpt.isPresent()) {
      return indexOpt.get();
    } else {
      throw new IndexNotFoundException(indexId);
    }
  }

exception mapper:


@Provider
public class IndexNotFoundExceptionMapper
    implements ExceptionMapper<IndexNotFoundException> {

  @Override
  public Response toResponse(IndexNotFoundException indexNotFoundException) {
    int errorCode = ErrorConstants.INDEX_NOT_FOUND_CODE;
    String errorMessage =
        String.format(
            ErrorConstants.INDEX_NOT_FOUND,
            indexNotFoundException.getIndexId()
        );

    return Response
        .status(Response.Status.NOT_FOUND)
        .entity(
            new KalaErrorEntity(
                errorMessage,
                errorCode
            )
        )
        .build();
  }
}

Where communities thrive

People

Repo info

Activity