Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Jan 17 08:02

    greenkeeper[bot] on eslint-plugin-react-7.12.4

    (compare)

  • Jan 17 07:49

    greenkeeper[bot] on eslint-plugin-react-7.12.4

    chore(package): update eslint-p… (compare)

  • Jan 16 20:22

    greenkeeper[bot] on eslint-plugin-react-7.12.3

    (compare)

  • Jan 16 20:13

    greenkeeper[bot] on eslint-plugin-react-7.12.3

    chore(package): update eslint-p… (compare)

  • Jan 03 01:54

    greenkeeper[bot] on lerna-3.8.4

    (compare)

  • Jan 03 01:52

    greenkeeper[bot] on lerna-3.8.4

    chore(package): update lerna to… (compare)

  • Jan 03 01:36

    greenkeeper[bot] on lerna-3.8.2

    (compare)

  • Jan 03 01:31

    greenkeeper[bot] on lerna-3.8.2

    chore(package): update lerna to… (compare)

  • Jan 03 01:11

    greenkeeper[bot] on eslint-plugin-react-7.12.2

    (compare)

  • Jan 03 00:17

    greenkeeper[bot] on eslint-plugin-react-7.12.2

    chore(package): update eslint-p… (compare)

  • Jan 01 22:51

    greenkeeper[bot] on eslint-plugin-react-7.12.1

    (compare)

  • Jan 01 22:48

    greenkeeper[bot] on eslint-plugin-react-7.12.1

    chore(package): update eslint-p… (compare)

  • Dec 31 2018 23:58

    greenkeeper[bot] on lerna-3.8.1

    (compare)

  • Dec 31 2018 23:56

    greenkeeper[bot] on lerna-3.8.1

    chore(package): update lerna to… (compare)

  • Dec 28 2018 08:18

    greenkeeper[bot] on eslint-plugin-react-7.12.0

    (compare)

  • Dec 28 2018 08:15

    greenkeeper[bot] on eslint-plugin-react-7.12.0

    chore(package): update eslint-p… (compare)

  • Dec 21 2018 02:26

    greenkeeper[bot] on lerna-3.8.0

    (compare)

  • Dec 21 2018 02:25

    greenkeeper[bot] on lerna-3.8.0

    chore(package): update lerna to… (compare)

  • Dec 21 2018 01:30

    greenkeeper[bot] on lerna-3.7.2

    (compare)

  • Dec 21 2018 01:28

    greenkeeper[bot] on lerna-3.7.2

    chore(package): update lerna to… (compare)

Seth Bertalotto
@redonkulus
We use library that auto finds all the stores and auto registers them at start up time on the server and init time on client
@pwmckenna
We use the npm package locator to find them all
Store the output of that file and then just loop over all the stores found and register them
Patrick Williams
@pwmckenna
interesting. is the library public? by npm package locator do you just mean npm ls? do you have a naming convention that makes finding them possible?
Seth Bertalotto
@redonkulus
You define rule sets for each package and that tells locator how to give them semantic meaning
Patrick Williams
@pwmckenna
do you guys use that with webpack by any chance?
Seth Bertalotto
@redonkulus
We do
We use webpacks bundle loader feature to load the bundles on demand
So we use locator to locate all the bundles, basically npm packages. Then use webpack to load them on the client when they are needed.
Patrick Williams
@pwmckenna
is there any magic to the way fluxible/react packages/bundles are arranged? do they all have stores/actions/components...also how do you deal with events being dispatched prior to the store that would handle the event being loaded?
Seth Bertalotto
@redonkulus
So we create a bundle.js file and require the actions stores and components there.
Then locator finds these bundle and files.
We then create a loader file of these bundles that uses the webpack bundle loader to load them on demand
I'm not at my computer otherwise I could show you an example
Patrick Williams
@pwmckenna
no worries, this is great
which bits of that do you reuse on the server?
just the bundle.js creation, but then just require them directly?
Seth Bertalotto
@redonkulus
@mridgway has an example of the bundle plugin that we use internally. With an example loader file https://gist.github.com/mridgway/53745e0da019058cc277
This is a simplified version of what we use
Patrick Williams
@pwmckenna
very cool. thanks!
Seth Bertalotto
@redonkulus
The loader is at the bottom
I need to document this on the fluxible site
tibbes
@tibbes
Quick question for fluxible developers:
Should the the unit-tests for fluxible-router unmount the components they use, or is this in general unnecessary and not done?
(at the end of each test, that is)
Seth Bertalotto
@redonkulus
@tibbes the jsdom env should be cleaned up after each test so the components would be unmounted/destroyed anyways.
@pwmckenna did that plugin sample help you at all?
tibbes
@tibbes
@redonkulus, OK thanks, that cleans up but I don't think it causes componentWillUnmount to be called. I noticed because there is a historyCreated variable which was supposed to stop the history handler from being instantiated more than once, but the variable is never set to true. Doing the obvious fix breaks the unit tests
Patrick Williams
@pwmckenna
@redonkulus yeah, I don't think we'll be able to go down that path, but it is helpful to see these problems being solved in different ways
question about getServiceMeta...given that the the fetchr middleware sets response headers using the meta field for requests from the client, should server code be using getServiceMeta to set response headers manually? or is the fetchr middleware somehow automagically doing it in that case as well?
Sebastian Marcusson
@sebastiansson_twitter

I'm trying to override the default props on the NavLink by creating a custom NavLink Component using the createNavLinkComponent. I can't seem to override the props.

My code:

var createNavLinkComponent = require('fluxible-router').createNavLinkComponent; module.exports = createNavLinkComponent({activeClass: "overrideClass" });

The activeClass is not being used.
Sebastian Marcusson
@sebastiansson_twitter
@redonkulus
Seth Bertalotto
@redonkulus
I would have to take a look the code to see why. There is a new PR open to make className easier to configure yahoo/fluxible#574. Maybe a similar change for activeClass is needed as well.
Raja Sekar Durairaj
@rajsek
Hi All,
I am new to react & fluxible combination. earlier i used redux for state management and i am bit fan of redux debugging extension.
is there any such extension for fluxible?
Seth Bertalotto
@redonkulus
We have a plug-in available that lets you track all the actions executed https://github.com/yahoo/fluxible/tree/master/packages/fluxible-plugin-devtools
Our doc site has an example how to use it
luyi985
@luyi985
Hi Guys, a small question, I need to migrate a flexible app to react 16 for my company, just wonder which version support react16?
Seth Bertalotto
@redonkulus
We upgraded the fluxible libraries a few months ago so it should work out of the box. We have not upgraded to the new context API yet.
raviksha
@raviksha
Cannot read property 'actions' of undefined Where it occured: in storeConnector(t) in div in t in storeConnector(t) in div in div in t in storeConnector(t) in t in t in storeConnector(t) in div in t in Root in HistoryHandler in RouteHandler in storeConnector(RouteHandler) in contextProvider(storeConnector(RouteHandler)) in IntlProvider"
I am facing this issue which blows my page ... Upon page refresh it works fine
it seems to be stemming from fluxible-addons-react/connectToStores.js
raviksha
@raviksha
On a button click, the event fires an action which in turn updates a UserStore
any idea guys, why this cud be happening, intermittently ?
Patrick Williams
@pwmckenna
@redonkulus I have a fluxible based library that I'm planning to upgrade to use the new context api, but it looks like the consuming application is going to need to have access to the same context object to use as a provider as my library will need as a consumer (rather than just knowing which contextTypes to specify). I'm curious if you'd be up for just creating a new FluxibleContext export in fluxible-addons-react that is literally just React.createContext() so that folks that want to start using it can at least share the fluxible context. We'll have to provide context in two ways for the time being so that connectToStores etc still work, as well as any code using the new api. The upside is that we can then migrate connectToStores etc over at a more leisurely pace (maybe once react 17 is released) while allowing people to use the new features.
as an alternative, how would you feel about a sweeping major bump to use the new context api
not sure if any of the apis would have to change, but it would definitely break existing applications (though maybe provideContext could be rewritten to spare most of the casualties)
Seth Bertalotto
@redonkulus
@pwmckenna thanks for bringing this up. We need to think about the best way to support the legacy API, while adding ability for apps to use the new. I would prefer to maintain backwards capability if possible. Can you open an issue in our repo so we can discuss further?
Patrick Williams
@pwmckenna
yeah, it'll be interesting trying to get the two contexts to interop...anyhow, dropped some comments in the existing new context issue: yahoo/fluxible#584