Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Jan 17 2019 08:02

    greenkeeper[bot] on eslint-plugin-react-7.12.4

    (compare)

  • Jan 17 2019 07:49

    greenkeeper[bot] on eslint-plugin-react-7.12.4

    chore(package): update eslint-p… (compare)

  • Jan 16 2019 20:22

    greenkeeper[bot] on eslint-plugin-react-7.12.3

    (compare)

  • Jan 16 2019 20:13

    greenkeeper[bot] on eslint-plugin-react-7.12.3

    chore(package): update eslint-p… (compare)

  • Jan 03 2019 01:54

    greenkeeper[bot] on lerna-3.8.4

    (compare)

  • Jan 03 2019 01:52

    greenkeeper[bot] on lerna-3.8.4

    chore(package): update lerna to… (compare)

  • Jan 03 2019 01:36

    greenkeeper[bot] on lerna-3.8.2

    (compare)

  • Jan 03 2019 01:31

    greenkeeper[bot] on lerna-3.8.2

    chore(package): update lerna to… (compare)

  • Jan 03 2019 01:11

    greenkeeper[bot] on eslint-plugin-react-7.12.2

    (compare)

  • Jan 03 2019 00:17

    greenkeeper[bot] on eslint-plugin-react-7.12.2

    chore(package): update eslint-p… (compare)

  • Jan 01 2019 22:51

    greenkeeper[bot] on eslint-plugin-react-7.12.1

    (compare)

  • Jan 01 2019 22:48

    greenkeeper[bot] on eslint-plugin-react-7.12.1

    chore(package): update eslint-p… (compare)

  • Dec 31 2018 23:58

    greenkeeper[bot] on lerna-3.8.1

    (compare)

  • Dec 31 2018 23:56

    greenkeeper[bot] on lerna-3.8.1

    chore(package): update lerna to… (compare)

  • Dec 28 2018 08:18

    greenkeeper[bot] on eslint-plugin-react-7.12.0

    (compare)

  • Dec 28 2018 08:15

    greenkeeper[bot] on eslint-plugin-react-7.12.0

    chore(package): update eslint-p… (compare)

  • Dec 21 2018 02:26

    greenkeeper[bot] on lerna-3.8.0

    (compare)

  • Dec 21 2018 02:25

    greenkeeper[bot] on lerna-3.8.0

    chore(package): update lerna to… (compare)

  • Dec 21 2018 01:30

    greenkeeper[bot] on lerna-3.7.2

    (compare)

  • Dec 21 2018 01:28

    greenkeeper[bot] on lerna-3.7.2

    chore(package): update lerna to… (compare)

Seth Bertalotto
@redonkulus
Fetch mr supports POST, you should be able to make POST requests from your app
raviksha
@raviksha
where do I set the POST method option @redonkulus ?
Seth Bertalotto
@redonkulus
Once you register your service with the plugin you just have to call the context.create method in your action to execute a POST request https://github.com/yahoo/fluxible/blob/master/packages/fluxible-plugin-fetchr/lib/fetchr-plugin.js#L82
raviksha
@raviksha
Thank you @redonkulus .. Thats helps :-)
Seth Bertalotto
@redonkulus
No problem. Hope it helps.
raviksha
@raviksha
hi Guys .. is there a way to set response headers for fetcher plugin xhr calls .. I need to redirect the user to the login page when the cookie in the xhr call from browser is expired ...
my current xhr is set up as :
app.plug(fetchrPlugin({
xhrPath: '/api', // Path for XHR to be served from
xhrTimeout: 60000
}));
what wud be the rite approach to handle this flow for cookie expiration ?
palacios
@pablopalacios

@redonkulus, @lingyan do you know how we should approach to solve bugs in the latest stable versions of fluxible packages?

The latest solved bug was this one: yahoo/fluxible#623. It was merged in the yahoo:fluxible-router-1.x branch and backported to master.

Currently, there is this opened issue yahoo/fluxible#616 which is also related to the latest router stable version. However , the yahoo:fluxible-router-1.x branch doesn't exist anymore. Because of this we can't create a PR to have the bug solved in the 1.x version.

Any idea how we should proceed? Would it be possible to create the 1.x branch again so we could release the bugfix? Or is there any other flow (or no flow anymore) to solve this kind of situation?

Seth Bertalotto
@redonkulus
@pablopalacios thanks for bringing this up. what about fixing it in master and using the 2.x version?
otherwise we can create branch from the 1.x git tag
Seth Bertalotto
@redonkulus
@pablopalacios actually i backported that change and published it into fluxible-router@1.5.4. Please test it out!
palacios
@pablopalacios
Oh cool! Thanks @redonkulus !
palacios
@pablopalacios
@redonkulus is there any breaking change in fluxible-router 2? I've quickly checked the diffs and I was not able to see anything. Also, is there anything missing to end its beta stage? If so, I would gladly volunteer to finish it in case nobody is moving it forward.
Seth Bertalotto
@redonkulus
@pablopalacios the only change was to remove create-react-class from the library to reduce the package size. I don’t think that was a breaking change but we did it be safe. We have a lot of internal code at yahoo that is running in product that relies on the current 1.x. We did the major bump to be safe.
We can probably remove the beta now. I don’t think we intended to make anymore breaking changes.
Seth Bertalotto
@redonkulus
I was looking at https://github.com/yahoo/fluxible/issues/584#issuecomment-508352121 and looks like we may need to make more changes to fluxible-router to support the new context API. If it is necessary, I would prefer to do that in the 2.x beta as well.
palacios
@pablopalacios
@redonkulus I see, and what do you think about releasing version 2 just to make it simple to fix small issues (so we don't have to create a 1.x branch again) and then we work on the upgrading context in a new major version?
I would say that because my gutter feeling says that people are not using version 2 because it is on beta. At least at my company this is the reason.
This would be also an opportunity to drop support for older react versions if it is possible on your side.
Seth Bertalotto
@redonkulus
Since it’s still in beta, I’m less concerned about breaking people on 2.x. I think we can just make the changes there. Those on the beta could always lock their version down too.
palacios
@pablopalacios
Right, so I'll update to beta at my company.
Seth Bertalotto
@redonkulus
Ok perfect
palacios
@pablopalacios
@redonkulus , regarding yahoo/fluxible#646, I also tested it on IE11 and MSEdge. On IE11 it doesn't work (but neither before the patch because we are using Object.assign anyway). On edge it works fine.
Seth Bertalotto
@redonkulus
Makes sense. We require that apps polyfill many of these native APIs for older browsers.
palacios
@pablopalacios
Got it. So then I believe that there should be no issues with the patch.
palacios
@pablopalacios
@redonkulus I was just wondering, what browsers should we support?
Seth Bertalotto
@redonkulus
I'd say since we are going major version bump the add-ons package in the next release, we should support modern browsers only (Chrome, Safari, Firefox and Edge). This allows us to remove deprecated code and polyfills.
Seth Bertalotto
@redonkulus
@pablopalacios I'm going to open an issue to track all the changes needed. This will help us track the necessary work.
Seth Bertalotto
@redonkulus
@pablopalacios here is the ticket yahoo/fluxible#654
palacios
@pablopalacios
All right! Cool!
palacios
@pablopalacios
thanks @redonkulus for the beta release! I'll start working in the examples/generator. But I will also start migrating my company website to see if I catch any thing.
Seth Bertalotto
@redonkulus
also beta released fluxible-router as well