Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 15:41
    ljharb commented #1759
  • 07:15
    Adnan-Bacic commented #1759
  • May 24 19:42
    ljharb commented #3289
  • May 24 19:40
    GuillaumeAmat commented #3289
  • May 24 16:07
    ljharb commented #3292
  • May 24 15:49
    Belco90 commented #3292
  • May 24 15:44
    ljharb commented #3292
  • May 24 15:16
    ljharb commented #1759
  • May 24 11:36
    Adnan-Bacic commented #1759
  • May 24 11:32
    Adnan-Bacic commented #1759
  • May 24 03:00
    ljharb closed #3293
  • May 24 03:00

    ljharb on master

    [Docs] `jsx-key`: split the exa… (compare)

  • May 23 23:42
    codecov[bot] commented #3293
  • May 23 23:42
    codecov[bot] commented #3293
  • May 23 23:39
    codecov[bot] commented #3293
  • May 23 23:38
    codecov[bot] commented #3293
  • May 23 23:37
    codecov[bot] commented #3293
  • May 23 23:35
    codecov[bot] commented #3293
  • May 23 23:34
    codecov[bot] commented #3293
  • May 23 23:32
    codecov[bot] commented #3293
Berkeley Martinez
@BerkeleyTrue
Woot!
Mathieu M-Gosselin
@mathieumg
I didn't know this room existed, might want to add the Gitter badge! :P
Mathieu M-Gosselin
@mathieumg
@yannickcr Did you have a release in mind soon? I don't mean to press, but it's been a couple of weeks and there have been two eslint releases since the last eslint-plugin-react minor release. :)
Mathieu M-Gosselin
@mathieumg
Well, that answers it! :tada:
Mathieu M-Gosselin
@mathieumg
ok last message here is mine 2 months ago, is anyone using this room? :P
I was wondering how https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-indent-props.md behaves for single-line components (with one or no prop)
webmato
@webmato

hello to all.
I have this issue with ESLint and React props / propTypes

...
this.props.hasOwnProperty('modelConfig');   /* =>  ESLint error: "no-prototype-builtins"   */
this.props.hasOwnProperty.call('modelConfig');   /*  => ESLint error: "react/prop-types"  (underlined is the "call" word) */
...
MyClass.propTypes = {
  modelConfig: ImmutablePropTypes.map,
};

How to solve it?

webmato
@webmato
edit: I have typo, instead this.props.hasOwnProperty.call('modelConfig') should be this.props.hasOwnProperty.call(this.props, 'modelConfig') , but still the same ESLint issue.
webmato
@webmato
good bye hasOwnProperty - so easy solution with ES6 :clap:
const { modelConfig } = this.props;
if(modelConfig) { ... }
Ghost
@ghost~54ca789adb8155e6700f3aff

Hi - so in one of the PRs it was mentioned that the code base should ideally only contain const and let, and no more var. So would you be interested in a PR for this?

I don't mind to do it as it would provide me a good opportunity to go through the code, but it would still take a couple of days as I want to take my time and read the code rather than just skim through it and just do find/replace.

Ghost
@ghost~54ca789adb8155e6700f3aff
@yannickcr any chance to get a new version released? Many people have asked because of yannickcr/eslint-plugin-react#1290 -- it gives an annoying warning in the IDE when using ESLint 4.2.0
Erwann Mest
@kud
Hello
is there someone here? :D