These are chat archives for yasp-dota/yasp

20th
Jul 2015
Ramana Venkata
@vramana
Jul 20 2015 12:49
@howardc93 I tried lossy compression on the original image at https://compressor.io/compress
The compressed image size is 187 KB and the image looks almost similar to my eye. May be that would be quick fix.
Ramana Venkata
@vramana
Jul 20 2015 13:16
Hey, can you explain why you attach libraries to the window for example
window.moment = require('moment'); To my best knowledge it is not a good practice.
Howard Chung
@howardchung
Jul 20 2015 14:09
Well, in practice i think including the script via a <script> tag generally does the same thing (so you can call moment() at any point afterward). So probably require('moment') by itself would be equivalent. If you think you can improve it, please submit a pull request!
Ramana Venkata
@vramana
Jul 20 2015 16:45
I want add a eslint to the project. Have you heard of babel? I want to change the code to using es6. Is it okay?
Howard Chung
@howardchung
Jul 20 2015 17:56
You may want to discuss this with @albertcui . I have not used babel/ES6 before.
Ramana Venkata
@vramana
Jul 20 2015 18:51
I am hoping that it would be nice to follow a style guide like this https://github.com/airbnb/javascript
Ramana Venkata
@vramana
Jul 20 2015 18:58
I started working on doing some prelimnary fixes. Currently it throws around 1000 warnings.
Howard Chung
@howardchung
Jul 20 2015 20:03
Submit pull requests when you've got something you want to merge. You should do so in small pieces since there may be merge conflicts.
Ramana Venkata
@vramana
Jul 20 2015 20:08
Okay.