These are chat archives for zalando/play-swagger

22nd
Feb 2016
Simon Hafner
@reactormonk
Feb 22 2016 14:42
I'm using apib2swagger (which makes the parser puke because of the generated $schema, but I grepped that one out), but now I hit requirement failed: Support for object definitions without properties is not implemented yet - but I checked manually, all of the schema objects have properties.
On another note, the compilers aren't run on swaggerDefinitions := Seq(file("api.json")) - I have thePlaySwagger` plugin enabled and the tasks exists.
Simon Hafner
@reactormonk
Feb 22 2016 14:54
Ok, found the issue on the first one.
Simon Hafner
@reactormonk
Feb 22 2016 15:06
Would you guys accept a PR for apib that depends on an external binary (snowcrash parser to json) and argonaut for json decoding?
slavaschmidt
@slavaschmidt
Feb 22 2016 17:15
Hi @reactormonk
So you've resolved the issue with requirement failed?
for the second one, yep, we currently have a couple of issues with task sometimes not run and i currently working on that
could you please be more specific about the PR?
Simon Hafner
@reactormonk
Feb 22 2016 18:01
@slavaschmidt, yeah, apib2swagger doesn't support Attributes, which creates an invalid swagger file.
the PR would require https://github.com/apiaryio/drafter to parse the apib file to ast-style json (which requires a bit more work to map to case classes) - it's a c++ lib that does the parsing, so you'd have to install the drafter outside of jars.
Simon Hafner
@reactormonk
Feb 22 2016 18:12
I'd do the decoding from json to case classes via argonaut.
slavaschmidt
@slavaschmidt
Feb 22 2016 21:15
so the PR is about adding support for apib additionally to swagger?
Simon Hafner
@reactormonk
Feb 22 2016 21:16
Exactly.
slavaschmidt
@slavaschmidt
Feb 22 2016 21:20
I'm pretty sure it won't work like that strait away. But of course if you already have something to offer we will be very happy to look at it