Looks like we correctly load the local schema as a JsonNode and then pass that to our JsonSchemaValidator with redirects setup for just http://json-schema.org/draft-04. I think, when validating the local schema internal references are being found and translated into absolute references, but nothing in the underlying validation understands that this is the the local schema that the process is starting from, and loads over http instead. Consequently adding an extra redirect for the originally loaded schema seems to hack around the problem - although I still suspect it means we're unnecessarily loading the original schema multiple times.
damned, this schema is also missing.
not that bad. may be we should do this for openapi-2-schema too. And how about http://json-schema.org/draft-04?
and 3 points to https://cdn.rawgit.com/googleapis/gnostic/master/OpenAPIv3/openapi-3.0.json which 404s
"If you're currently using RawGit, please stop using it as soon as you can."
"GitHub repositories that served content through RawGit within the last month will continue to be served until at least October of 2019"
all from http://rawgit.com
https://raw.githubusercontent.com/OAI/OpenAPI-Specification/master/schemas/v3.0/schema.json works, but we should not use this too.
I'm a bit puzzled that the schema is different.
so for now lets go with the current.
I wonder how much we've benefited from being able to softcode those references?
local test was as expected successful.
@vadeg can you approve?
done
Hello everyone, I have a question regarding adding my own rule. I'm a little lost because I'm not really sure where I should be creating my own rules, and how to know if they are being implemented correctly.
Should I just add them in a package on zally/server or is it different from the way zalando/zally rulset are implemented? Also do I have to create a rulset if I want to add a single rule?
I'm sorry for all the questions but I can't find much info about it (besides the documentation) or even another project that uses zally (if anyone has an example it would be super useful). I'm checking different ways to validate an api and zally caught my attention. Any help is appreciated, thank you!
Should I just add them in a package on zally/server or is it different from the way zalando/zally rulset are implemented? Also do I have to create a rulset if I want to add a single rule?
I'm sorry for all the questions but I can't find much info about it (besides the documentation) or even another project that uses zally (if anyone has an example it would be super useful). I'm checking different ways to validate an api and zally caught my attention. Any help is appreciated, thank you!
All rules need to be in a ruleset, but you can likely add to ZallyRuleSet unless you really have a bunch of related rules that would make better sense as a set.
Hi again, I have a question regarding creating my own set of rules. I tried to create a RuleSet in a similar way to ZallyRuleSet but it doesn's seem to be working because when I try to add a Rule to it (ruleSet = MyRuleSet::class) it doesn't work. Is there another thing I should be doing besides creating the MyRuleSet class and setting it?
I started on an example external ruleset in a separate project last night - it's still work in progress but I'll push it somewhere tonight and share it
So, good news here's my example as promised: https://github.com/roxspring/zally-ruleset-example
Bad news: It doesn't quite work as I haven't yet figured out a good way to get the rules onto the Zally server's class path.
Bad news: It doesn't quite work as I haven't yet figured out a good way to get the rules onto the Zally server's class path.
Once we have official published jars and docker images then I suspect this can serve as the basis for some official docs.