Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    Rob Oxspring
    @roxspring
    I'm a bit puzzled that the schema is different.
    so for now lets go with the current.
    Vadim Shaigorodskiy
    @vadeg
    We have all schemas locally, no?
    Tronje Krop
    @tkrop
    yes
    Rob Oxspring
    @roxspring
    seems a bit crazy that we're bundling local copies of hte relevant schemas, and falling back to using them - but our default configuration is to pull fresh copies down from the internet
    I wonder how much we've benefited from being able to softcode those references?
    Tronje Krop
    @tkrop
    have pushed the other redirect to zalando/zally#1120
    local test was as expected successful.
    Rob Oxspring
    @roxspring
    :thumbsup:
    Tronje Krop
    @tkrop
    @roxspring thanks for proposing this fix.
    @vadeg can you approve?
    Rob Oxspring
    @roxspring
    np - was very concerned that i'd caused it with my recent refactoring so was extra motivated to understand - the fix/hack was a bonus
    Vadim Shaigorodskiy
    @vadeg
    @tkrop sure
    done
    Tronje Krop
    @tkrop
    thanks. i role out as quick as possible.
    loretop
    @loretop
    Hello everyone, I have a question regarding adding my own rule. I'm a little lost because I'm not really sure where I should be creating my own rules, and how to know if they are being implemented correctly.
    Should I just add them in a package on zally/server or is it different from the way zalando/zally rulset are implemented? Also do I have to create a rulset if I want to add a single rule?
    I'm sorry for all the questions but I can't find much info about it (besides the documentation) or even another project that uses zally (if anyone has an example it would be super useful). I'm checking different ways to validate an api and zally caught my attention. Any help is appreciated, thank you!
    Rob Oxspring
    @roxspring
    Hi. Work to make developing custom rules easier is coming along but still not there yet, so the viable options for now are (1) contribute your new rule to Zally itself or (2) forking the repo and adding private rules to your own fork.
    All rules need to be in a ruleset, but you can likely add to ZallyRuleSet unless you really have a bunch of related rules that would make better sense as a set.
    Rob Oxspring
    @roxspring
    Hopefully some of that helps. If you're able to keep notes of progress and discoveries along the way then I suspect they could be an invaluable starting point for some sort of user/developer guide!
    loretop
    @loretop
    Thank you! I'm keeping some notes, if they prove to be useful I'll send them
    loretop
    @loretop
    Hi again, I have a question regarding creating my own set of rules. I tried to create a RuleSet in a similar way to ZallyRuleSet but it doesn's seem to be working because when I try to add a Rule to it (ruleSet = MyRuleSet::class) it doesn't work. Is there another thing I should be doing besides creating the MyRuleSet class and setting it?
    Rob Oxspring
    @roxspring
    MyRuleSet needs to implement the RuleSet interface, and likely can extend AbstractRuleSet
    I started on an example external ruleset in a separate project last night - it's still work in progress but I'll push it somewhere tonight and share it
    loretop
    @loretop
    Thank you so much! That would be very helpful
    Rob Oxspring
    @roxspring
    So, good news here's my example as promised: https://github.com/roxspring/zally-ruleset-example
    Bad news: It doesn't quite work as I haven't yet figured out a good way to get the rules onto the Zally server's class path.
    Rob Oxspring
    @roxspring
    Actually, forget that bad news. I've updated the example to patch the new rules into zally.jar and it seems to work.
    Once we have official published jars and docker images then I suspect this can serve as the basis for some official docs.
    loretop
    @loretop
    Thanks!
    Vadim Shaigorodskiy
    @vadeg
    Hi all,
    I wonder what is it purpose having zally-rule-api and zally-core separate? Do we have plans to support other rule implementation?
    Rob Oxspring
    @roxspring
    Yes, the intention is to get to a point where people can plug in custom rulesets
    Think it was issue #560 from memory
    Vadim Shaigorodskiy
    @vadeg
    But if I implement a new ruleset using only zally-rule-api I can not run it or test it without zally-core
    Rob Oxspring
    @roxspring
    the theory was that rules should only need to depend on -api ... but -core is needed to run meaningful tests, and ended up a dependency of the ruleset in each case so far
    I don't have any major objections to collapsing -api back into -core
    Rob Oxspring
    @roxspring
    Splitting out -api was a very early step where we thought it would be useful to split out api and models - #748 for details
    Vadim Shaigorodskiy
    @vadeg
    I like your idea more: zally-rules.jar = Rule APIs, annotations and core rule framework.
    Having API as a separate jar make sense in cases when something may have many different implementations. For example Java Servlet API is the separate API jar because web servers may have different implementations. Or Java Persistence API which has Hibernate, Toplink or JEE implementation (do not remember it’s name).
    To implement a separate RuleSet user will need some implementation to test with.
    Rob Oxspring
    @roxspring
    :thumbsup:
    nardevar23
    @nardevar23
    hi
    I've used build-and-run.sh to setup zally
    but my server container is in un-healthy state
    could you please help
    [root@localhost zally]# docker ps -a
    CONTAINER ID IMAGE COMMAND CREATED STATUS PORTS NAMES
    5a7cb77af1eb zally_web-ui "node server.js" 13 minutes ago Up 2 minutes 0.0.0.0:8080->3000/tcp zally_web-ui_1
    2718bf554728 zally_server "/bin/sh -c 'java $(…" 13 minutes ago Up 2 minutes (unhealthy) 0.0.0.0:8000->8000/tcp, 8080/tcp zally_server_1
    0c15a58683a0 postgres:9.6 "docker-entrypoint.s…" 13 minutes ago Up 2 minutes 0.0.0.0:54321->5432/tcp zally_postgres_1
    nardevar23
    @nardevar23
    also facing issue with CLI as well
    [root@localhost zally]# go build
    app.go:4:2: cannot find package "github.com/urfave/cli" in any of:
    /usr/lib/golang/src/github.com/urfave/cli (from $GOROOT)
    /root/go/src/github.com/urfave/cli (from $GOPATH)
    app.go:5:2: cannot find package "github.com/zalando/zally/cli/zally/commands" in any of:
    /usr/lib/golang/src/github.com/zalando/zally/cli/zally/commands (from $GOROOT)
    /root/go/src/github.com/zalando/zally/cli/zally/commands (from $GOPATH)
    main.go:7:2: cannot find package "github.com/zalando/zally/cli/zally/domain" in any of:
    /usr/lib/golang/src/github.com/zalando/zally/cli/zally/domain (from $GOROOT)
    /root/go/src/github.com/zalando/zally/cli/zally/domain (from $GOPATH)
    unable to install go CLI
    Rob Oxspring
    @roxspring
    @nardevar23 are you seeing any "unhealthy" indicators other than that string? is the web ui functional?? is the server responding??
    Rob Oxspring
    @roxspring
    FWIW you can definitely ignore the "unhealthy" indicator - it's badly configured and can never report healthy - zalando/zally#1133
    malakIN2020
    @malakIN2020

    Hi All, have done the zally setup on windows machine and successfully able to run web ui on localhost:3000. As part of minor text changes on UI hav modified the bundle.js file located at \zally-webui\node_modules\zally-web-ui\src\client\public\assets, the changes are reflected fine.

    The setup on AWS linux EC2 instance is also working fine however i am not able to do similar UI changes on ec2 after modifying the bundle.js file. After modifying the file i restarted both docker container and ec2 instance too but the changes are not reflected.

    Please help to mitigate issue with bundle.js file, changes are not reflected on zally web ui. Is there any other file which can be modified under docker to modify the text.